[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350479#comment-15350479 ] ASF subversion and git services commented on SOLR-7374: --- Commit

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350478#comment-15350478 ] ASF subversion and git services commented on SOLR-7374: --- Commit

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348204#comment-15348204 ] Varun Thacker commented on SOLR-7374: - I was looking at

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346907#comment-15346907 ] ASF subversion and git services commented on SOLR-7374: --- Commit

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346820#comment-15346820 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] bq. Do you plan on tackling SOLR-9242 as

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346795#comment-15346795 ] Varun Thacker commented on SOLR-7374: - I've got precommit to pass. Running the test suite one more time

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346787#comment-15346787 ] Hrishikesh Gadre commented on SOLR-7374: [~markrmil...@gmail.com] Thanks for the insight.

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344893#comment-15344893 ] Mark Miller commented on SOLR-7374: --- bq. So developers end up diagnosing and fixing such issues after

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344773#comment-15344773 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] Oh BTW let's not hold up the patch for

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344745#comment-15344745 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] Thanks for the review. I think the changes

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343072#comment-15343072 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] I have filed a JIRA to track the work

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342235#comment-15342235 ] Varun Thacker commented on SOLR-7374: - Yeah we can tackle that in another Jira . Whether we enforce a

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342117#comment-15342117 ] Mark Miller commented on SOLR-7374: --- I have no strong preference on whether that needs to use a

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342101#comment-15342101 ] Hrishikesh Gadre commented on SOLR-7374: [~markrmil...@gmail.com] bq. So I think we do want it

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341858#comment-15341858 ] Varun Thacker commented on SOLR-7374: - Regarding the cloud level changes required, I agree with you'll

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341836#comment-15341836 ] Varun Thacker commented on SOLR-7374: - FYI I created SOLR-9239 for discussing the two approaches that

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341289#comment-15341289 ] Mark Miller commented on SOLR-7374: --- So I think we do want it configurable in ReplicationHandler config,

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341266#comment-15341266 ] Mark Miller commented on SOLR-7374: --- I don't see a problem with breaking off the full cloud work into

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341157#comment-15341157 ] Varun Thacker commented on SOLR-7374: - bq. Do we need to incorporate these changes in the replication

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340439#comment-15340439 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] bq. Alternatively how do you feel about

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340021#comment-15340021 ] Varun Thacker commented on SOLR-7374: - Hi Hrishikesh, bq. So in case there are multiple repositories

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339971#comment-15339971 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] bq. Let's stick to the current model of

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339700#comment-15339700 ] Mark Miller commented on SOLR-7374: --- [~varunthacker], do you want to take this back for the commit now

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339387#comment-15339387 ] Varun Thacker commented on SOLR-7374: - Changes look good! bq. It looks like we are also creating a

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334985#comment-15334985 ] Hrishikesh Gadre commented on SOLR-7374: bq. For the scope of this Jira can we just support it in

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334905#comment-15334905 ] Hrishikesh Gadre commented on SOLR-7374: bq. For the scope of this Jira can we just support it in

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334233#comment-15334233 ] Varun Thacker commented on SOLR-7374: - bq. Also building two parallel implementations for the same

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334207#comment-15334207 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] Thanks for the comments. bq. In

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333604#comment-15333604 ] Varun Thacker commented on SOLR-7374: - Also i found {{ZkStateReader#BACKUP_LOCATION}} constant. We

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333537#comment-15333537 ] Varun Thacker commented on SOLR-7374: - Hi Hrishikesh, Thanks for the updated patch! Looks good While

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332291#comment-15332291 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] [~markrmil...@gmail.com] Thanks for the

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332029#comment-15332029 ] Mark Miller commented on SOLR-7374: --- bq. deprecate the usage of cluster prop and look at query param

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331958#comment-15331958 ] Mark Miller commented on SOLR-7374: --- bq. "location" in the solr.xml The baseLocation in the test

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331898#comment-15331898 ] Mark Miller commented on SOLR-7374: --- I have the following changes already in my local copy: * fixed

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331892#comment-15331892 ] Varun Thacker commented on SOLR-7374: - Hi Hrishikesh, Patch is looking good! Here are my main two

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329707#comment-15329707 ] Hrishikesh Gadre commented on SOLR-7374: Looking into this... > Backup/Restore should provide a

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329679#comment-15329679 ] Mark Miller commented on SOLR-7374: --- Looks like for the test fail we may just have to check the backup

Re: [jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

I can beast it a bit if that's useful On Tue, Jun 14, 2016 at 7:07 AM, David Smiley (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329554#comment-15329554 > ] > > David

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329554#comment-15329554 ] David Smiley commented on SOLR-7374: bq. One comment: Shouldn't we make BackupRepository an abstract

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329512#comment-15329512 ] Mark Miller commented on SOLR-7374: --- Just found the follow fail. Does not seem to be repeatable by seed,

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329338#comment-15329338 ] Mark Miller commented on SOLR-7374: --- Thanks, I'm pretty much ready with this. One comment: Shouldn't we

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323481#comment-15323481 ] Hrishikesh Gadre commented on SOLR-7374: [~markrmil...@gmail.com] Let me know if you need anything

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316839#comment-15316839 ] Mark Miller commented on SOLR-7374: --- I'm try to pinpoint if this has destabilized

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312753#comment-15312753 ] Mark Miller commented on SOLR-7374: --- I'm going to steal this issue ;) > Backup/Restore should provide a

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307998#comment-15307998 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] could you please review the patch? >

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302519#comment-15302519 ] Mark Miller commented on SOLR-7374: --- Where are we at here? I'd really like to get this in so that

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292559#comment-15292559 ] Hrishikesh Gadre commented on SOLR-7374: [~tomasflobbe] Thanks for the review. Let me submit an

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292265#comment-15292265 ] Tomás Fernández Löbbe commented on SOLR-7374: - I came to this issue following the discussion in

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228886#comment-15228886 ] David Smiley commented on SOLR-7374: +1 to a specifying protocol/impl as a prefix. Presumably there

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211148#comment-15211148 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] Sure. I think at the high-level we can

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211093#comment-15211093 ] Varun Thacker commented on SOLR-7374: - Hi Hrishikesh, Please feel free to work on it. I've not got

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207510#comment-15207510 ] Hrishikesh Gadre commented on SOLR-7374: [~varunthacker] are you still working on this? If not, I

[jira] [Commented] (SOLR-7374) Backup/Restore should provide a param for specifying the directory implementation it should use

[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493005#comment-14493005 ] Jan Høydahl commented on SOLR-7374: --- Looking forward to a collection backup command, we