[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991132#comment-12991132
]
Shai Erera commented on LUCENE-2609:
Thanks Steven !
Committed revision 1067623 (3x)
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990027#comment-12990027
]
Uwe Schindler commented on LUCENE-2609:
---
Hi Shai, patch looks fine (applies only to
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990002#comment-12990002
]
Uwe Schindler commented on LUCENE-2609:
---
Hi Shai,
I will try this out today, also w
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989995#comment-12989995
]
Shai Erera commented on LUCENE-2609:
I plan to commit this sometime today or tomorrow
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989727#comment-12989727
]
Shai Erera commented on LUCENE-2609:
I think we should compile test-framework under c
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988994#comment-12988994
]
Robert Muir commented on LUCENE-2609:
-
Sorry Shai... I'll try to blame this one on th
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987578#action_12987578
]
Uwe Schindler commented on LUCENE-2609:
---
bq.I think we can make the Solr changes her
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987568#action_12987568
]
Grant Ingersoll commented on LUCENE-2609:
-
Sounds good. I think we can make the S
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987560#action_12987560
]
Uwe Schindler commented on LUCENE-2609:
---
That was exactly my proposal. In addition I
On Jan 27, 2011, at 6:55 AM, Shai Erera (JIRA) wrote:
>
>[
> https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987514#action_12987514
> ]
>
> Shai Erera commented on LUCENE-2609:
> --
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987552#action_12987552
]
Shai Erera commented on LUCENE-2609:
To summarize the plan then:
* We'll separate test
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987540#action_12987540
]
Robert Muir commented on LUCENE-2609:
-
bq. The real tests are compiled later and not j
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987536#action_12987536
]
Uwe Schindler commented on LUCENE-2609:
---
{quote}
bq. If it will make things any simp
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987534#action_12987534
]
Shai Erera commented on LUCENE-2609:
It was just a suggestion. If we have utilities th
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987530#action_12987530
]
Robert Muir commented on LUCENE-2609:
-
bq. If it will make things any simpler, then le
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987526#action_12987526
]
Shai Erera commented on LUCENE-2609:
Agreed - tests improvement should be our main con
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987525#action_12987525
]
Robert Muir commented on LUCENE-2609:
-
bq. It's always hard to argue with arguments li
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987524#action_12987524
]
Shai Erera commented on LUCENE-2609:
What backwards compatibility policy Robert? This
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987523#action_12987523
]
Shai Erera commented on LUCENE-2609:
bq. but what else does it use/might it use in the
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987520#action_12987520
]
Uwe Schindler commented on LUCENE-2609:
---
bq. But is anyone concerned about the file
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987521#action_12987521
]
Robert Muir commented on LUCENE-2609:
-
bq. BaseTokenSteamTestCase should be really ava
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987516#action_12987516
]
Uwe Schindler commented on LUCENE-2609:
---
My problem with the large JAR file is: as i
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987515#action_12987515
]
Robert Muir commented on LUCENE-2609:
-
{quote}
We can jar up all *.java to reduce the
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987514#action_12987514
]
Shai Erera commented on LUCENE-2609:
So Robert, I don't really follow the BUILD FAILUR
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987513#action_12987513
]
Grant Ingersoll commented on LUCENE-2609:
-
bq. Hard to break what?
I just meant i
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987512#action_12987512
]
Robert Muir commented on LUCENE-2609:
-
{quote}
While agree with the "Build Failed" not
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987509#action_12987509
]
Robert Muir commented on LUCENE-2609:
-
Just to sum up, I think we should go back to th
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987508#action_12987508
]
Grant Ingersoll commented on LUCENE-2609:
-
Mostly, I think I need the SolrTestCase
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987502#action_12987502
]
Robert Muir commented on LUCENE-2609:
-
bq. I don't think this should hold us back when
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987499#action_12987499
]
Shai Erera commented on LUCENE-2609:
This is good point Robert, but I don't like the o
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987496#action_12987496
]
Robert Muir commented on LUCENE-2609:
-
I don't know about the changes here guys... if
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987460#action_12987460
]
Uwe Schindler commented on LUCENE-2609:
---
Commit it, was just a suggestion because I
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987450#action_12987450
]
Shai Erera commented on LUCENE-2609:
I think two files for such a tiny .jar is an over
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987447#action_12987447
]
Simon Willnauer commented on LUCENE-2609:
-
looks good to me!
> Generate jar conta
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987444#action_12987444
]
Uwe Schindler commented on LUCENE-2609:
---
+1
That was exactly wht I had in mind. I wo
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987429#action_12987429
]
Simon Willnauer commented on LUCENE-2609:
-
Hey shai,
I just collected some classe
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987427#action_12987427
]
Uwe Schindler commented on LUCENE-2609:
---
+1, the main problem with this JAR file is
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987406#action_12987406
]
Simon Willnauer commented on LUCENE-2609:
-
bq. think it'll be more compelling to
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987404#action_12987404
]
Shai Erera commented on LUCENE-2609:
Was the purpose of this issue to create a .jar wi
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904613#action_12904613
]
Drew Farris commented on LUCENE-2609:
-
Grant, What version of maven-ant-tasks are you
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904595#action_12904595
]
Grant Ingersoll commented on LUCENE-2609:
-
The issue is the artifact id, etc. are
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904367#action_12904367
]
Grant Ingersoll commented on LUCENE-2609:
-
Both trunk and 3.x of Lucene.
> Genera
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904337#action_12904337
]
Drew Farris commented on LUCENE-2609:
-
Grant, I'll take a look. So I can reproduce the
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904330#action_12904330
]
Grant Ingersoll commented on LUCENE-2609:
-
ant generate-maven-artifacts does not a
[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901394#action_12901394
]
Grant Ingersoll commented on LUCENE-2609:
-
Drew,
If you want this to be pub'd as
45 matches
Mail list logo
