Re: Friendly reminder: please run precommit

For these type of things i use a very simple script that creates a tmp dir and checks out the latest git commit (can be local) and then runs a build. That way you can keep working in your current work directory and don't need to maintain 2 checkouts, or move commits around.

Re: Friendly reminder: please run precommit

Simon, I ran "ant precommit" on my Dell 4-core laptop with SSD's, three years old, just an hour ago. 23 minutes. So obviously your mileage varies. "ant documentation-lint" on just Lucene is much faster, and is within the tolerable zone. Karl On Thu, Apr 26, 2018 at 10:08 AM, David Smiley

Re: Friendly reminder: please run precommit

FWIW I have a second machine that I rsync my changes to in order to run "ant test". I occasionally use it for precommit as well. I wrote a small script to helps me automate this. Perhaps others here will find this script useful: https://gist.github.com/dsmiley/daff3c978fe234b48a69a01b54ea9914

Re: Friendly reminder: please run precommit

everyone here is collaborating: it causes confusion and takes up other people's time when you break the build. I would ask to just run precommit before committing. you don't have to sit and watch it, you can go work on something else while it runs. On Thu, Apr 26, 2018 at 9:23 AM, Karl Wright

Re: Friendly reminder: please run precommit

precommit: BUILD SUCCESSFUL Total time: 10 minutes 48 seconds on a my like 2 year old macbook pro I think that is reasonable? On Thu, Apr 26, 2018 at 3:23 PM, Karl Wright wrote: > :-) > > 25 minutes is an eternity these days, Robert. This is especially true when > others

Re: Friendly reminder: please run precommit

:-) 25 minutes is an eternity these days, Robert. This is especially true when others are collaborating with what you are doing, as was the case here. The other approach would be to create a branch, but I've been avoiding that on git. "ant documentation-lint" is what I'm looking for, thanks.

Re: Friendly reminder: please run precommit

I don't understand the turnaround issue, why do the commits need to be rushed in? There is patch validation recently hooked in to avoid keeping your computer busy for 25 minutes. If you are not changing third party dependencies or anything "heavy" like that you should at least run "ant

Re: Friendly reminder: please run precommit

How long does precommit take you to run? For me, it's a good 25 minutes. That really impacts turnaround, which is why I'd love a precommit that looked only at certain things in the local package I'm dealing with. Karl On Thu, Apr 26, 2018 at 6:14 AM, Simon Willnauer

Friendly reminder: please run precommit

Hey folks, I had to fix several glitches lately that are caught by running precommit. It's a simple step please take the time running `ant clean precommit` on top-level. Thanks, Simon - To unsubscribe, e-mail: