Re: Lucene 9.7 release

2023-06-13 Thread Michael McCandless
On Tue, Jun 13, 2023 at 6:14 AM Uwe Schindler wrote: > P.S.: We should update the Smoketester to accept an arbitrary number of > alternative JDKs to run tests. Currently it is fixed to Java 11 and 17 (I > think). > +1, open an issue? Mike McCandless http://blog.mikemccandless.com >

Re: Lucene 9.7 release

2023-06-13 Thread Uwe Schindler
Hi, we merged Java 21 support for both MMapDirectory and VectorUtil to main and branch_9x. As JDK is in Rampdown Phase 1, it is very unlikely that there will be hard API changes till release. In fact, the Java 21 version of vector support was working without code change, we just enabled

Re: Lucene 9.7 release

2023-06-12 Thread Alessandro Benedetti
Friday should be doable, thanks! it's true it's a new feature, the only reason is "urgent" is because it's half of the work we needed to bring this to Solr and we wuld prefer to not lose traction over there (and have to wait much longer). Not a blocker by any means! But I hope we bring it in :)

Re: Lucene 9.7 release

2023-06-12 Thread Adrien Grand
Hi Alessandro, It's ok to merge changes before feature freeze, currently planned for Friday. From a quick look, this is a new feature rather than a bug fix, so if it's not ready by Friday it could wait until the next minor? On Mon, Jun 12, 2023 at 6:15 PM Alessandro Benedetti wrote: > Hi, > we

Re: Lucene 9.7 release

2023-06-12 Thread Alessandro Benedetti
Hi, we are finalizing https://github.com/apache/lucene/pull/12253, we got some last-minute valuable review comments and we would like to apply the suggestions and bring them in 9.x . Cheers -- *Alessandro Benedetti* Director @ Sease Ltd. *Apache Lucene/Solr Committer*

Re: Lucene 9.7 release

2023-06-09 Thread Uwe Schindler
Hi, BTW, there was a slight change in APIJARs caused by this API change: https://github.com/openjdk/jdk/commit/5fc9b5787dc4d7f00d2c59288bc8d840fdf5b495 (this does not affect our code, but it was done 3 weeks ago). I hope something like this won't happen. I updated the PR, no code changes

Re: Lucene 9.7 release

2023-06-09 Thread Uwe Schindler
Let me merge and backport the java 21 map PR first. It has all new source directories and APIJAR files. For safety I will regenerate the 21 APIJAR with newest jdk build. Fyi, to regenerate you need to have an environment variable with jdk21 as autoprovisioning doesn't work. After that we can

Re: Lucene 9.7 release

2023-06-09 Thread Chris Hegarty
Hi, > On 9 Jun 2023, at 17:19, Uwe Schindler wrote: > > Hi, > > if possible I would like to get the Java 21 changes (MemorySegments and > Vector) into the release. I'd like to ask Chris who has better knowledge how > to proceed. If he suggests to wait maybe a week or 2, I'd suggest to wait

Re: Lucene 9.7 release

2023-06-09 Thread Michael Wechner
Thank you very much, Adrien! Am 09.06.23 um 18:20 schrieb Tomás Fernández Löbbe: +1 Thanks Adrien On Fri, Jun 9, 2023 at 9:19 AM Michael McCandless wrote: +1, thanks Adrien! Mike McCandless http://blog.mikemccandless.com On Fri, Jun 9, 2023 at 12:11 PM Patrick Zhai

Re: Lucene 9.7 release

2023-06-09 Thread Ignacio Vera
+1 On Fri, Jun 9, 2023 at 6:20 PM Tomás Fernández Löbbe wrote: > +1 > Thanks Adrien > > On Fri, Jun 9, 2023 at 9:19 AM Michael McCandless < > luc...@mikemccandless.com> wrote: > >> +1, thanks Adrien! >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Fri, Jun 9, 2023 at

Re: Lucene 9.7 release

2023-06-09 Thread Tomás Fernández Löbbe
+1 Thanks Adrien On Fri, Jun 9, 2023 at 9:19 AM Michael McCandless wrote: > +1, thanks Adrien! > > Mike McCandless > > http://blog.mikemccandless.com > > > On Fri, Jun 9, 2023 at 12:11 PM Patrick Zhai wrote: > >> +1, thank you Adrien! >> >> On Fri, Jun 9, 2023, 09:08 Adrien Grand wrote: >>

Re: Lucene 9.7 release

2023-06-09 Thread Uwe Schindler
Hi, if possible I would like to get the Java 21 changes (MemorySegments and Vector) into the release. I'd like to ask Chris who has better knowledge how to proceed. If he suggests to wait maybe a week or 2, I'd suggest to wait that time. Chris Hegarthy: Do you know if the API of JDK 21 is

Re: Lucene 9.7 release

2023-06-09 Thread Michael McCandless
+1, thanks Adrien! Mike McCandless http://blog.mikemccandless.com On Fri, Jun 9, 2023 at 12:11 PM Patrick Zhai wrote: > +1, thank you Adrien! > > On Fri, Jun 9, 2023, 09:08 Adrien Grand wrote: > >> Hello all, >> >> There is some good stuff that is scheduled for 9.7 already, I found the >>

Re: Lucene 9.7 release

2023-06-09 Thread Patrick Zhai
+1, thank you Adrien! On Fri, Jun 9, 2023, 09:08 Adrien Grand wrote: > Hello all, > > There is some good stuff that is scheduled for 9.7 already, I found the > following changes in the changelog that look especially interesting: > - Concurrent query rewrites for vector queries. > - Speedups