Re: Lucene 9.9.0 Release

2023-11-29 Thread Chris Hegarty
Hi Feng, > On 29 Nov 2023, at 11:25, Guo Feng wrote: > > Hi Chris, > > Nightly benchmark shows that #12699 gets back some speed. I've backport it to > 9.9.0. I think it is ready now. Awesome! > Sorry for delaying the release! No apology needed. I appreciate your speedy work here. I’ll

Re: Lucene 9.9.0 Release

2023-11-29 Thread Guo Feng
Hi Chris, Nightly benchmark shows that #12699 gets back some speed. I've backport it to 9.9.0. I think it is ready now. Sorry for delaying the release! Feng On 2023/11/28 08:32:59 Chris Hegarty wrote: > Hi Guo, > > Thanks for the update. > > Let’s push the 9.9.0 branch cut until tomorrow

Re: Lucene 9.9.0 Release

2023-11-28 Thread Chris Hegarty
Hi Guo, Thanks for the update. Let’s push the 9.9.0 branch cut until tomorrow (rather than today as previously suggested), which should allow time to determine the outstanding issues you mentioned below. That should be more straightforward all round. New 9.9.0 branch cut 12:00 29th Nov 2023

Re: Lucene 9.9.0 Release

2023-11-27 Thread Guo Feng
+1, thanks for volunteering Chris! #12699 is merged to main. I plan to backport it to 9.9 if it fixes the performance drop, otherwise revert #12699 and #12631 (the PR introduced regression) and push them to the next version. On 2023/11/21 09:51:43 Chris Hegarty wrote: > Hi, > > It's been a

Re: Lucene 9.9.0 Release

2023-11-27 Thread Adrien Grand
Thanks Chris for checking. I had been too optimistic for #12180, I'll push it to 9.10. Fingers crossed that #12699 fixes the performance drop. Le lun. 27 nov. 2023, 07:17, Chris Hegarty a écrit : > Hi Adrien, > > Comments inline. > > On 21 Nov 2023, at 12:31, Adrien Grand wrote: > > +1 9.9

Re: Lucene 9.9.0 Release

2023-11-27 Thread Chris Hegarty
Hi Adrien, Comments inline. > On 21 Nov 2023, at 12:31, Adrien Grand wrote: > > +1 9.9 has plenty of great changes indeed! Thanks for volunteering as a RM, > Chris. > > It would be good to try and fix the PKLookup regression that was introduced > since 9.8:

Re: Lucene 9.9.0 Release

2023-11-23 Thread Jan Høydahl
+1 to a 9.9.0 release, thanks for volunteering. And also positive to immediately start planning the 10.0 release. JDK bump -> 17 is a major "feature" in itself, so we can bump main branch to 21 too. And discontinue support for 8.x after the 8.11.3 release. Jan > 22. nov. 2023 kl. 17:11 skrev

Re: Lucene 9.9.0 Release

2023-11-22 Thread Michael Sokolov
+1 thanks for volunteering! Hijacking the thread a bit, sorry, I started looking into whether this is a good time to start looking ahead to 10? I know we had some rumblings about releasing that so we can start requiring newer JDKs. But looking at CHANGES it feels like we already back-ported most

Re: Lucene 9.9.0 Release

2023-11-21 Thread Patrick Zhai
+1, thank you Chris! On Tue, Nov 21, 2023, 06:49 Benjamin Trent wrote: > +1 9.9 will be a stellar release! > > Thank you Chris! > > On Tue, Nov 21, 2023 at 7:31 AM Adrien Grand wrote: > >> +1 9.9 has plenty of great changes indeed! Thanks for volunteering as a >> RM, Chris. >> >> It would be

Re: Lucene 9.9.0 Release

2023-11-21 Thread Benjamin Trent
+1 9.9 will be a stellar release! Thank you Chris! On Tue, Nov 21, 2023 at 7:31 AM Adrien Grand wrote: > +1 9.9 has plenty of great changes indeed! Thanks for volunteering as a > RM, Chris. > > It would be good to try and fix the PKLookup regression that was > introduced since 9.8: >

Re: Lucene 9.9.0 Release

2023-11-21 Thread Adrien Grand
+1 9.9 has plenty of great changes indeed! Thanks for volunteering as a RM, Chris. It would be good to try and fix the PKLookup regression that was introduced since 9.8: http://people.apache.org/~mikemccand/lucenebench/PKLookup.html. Is it just about getting #12699

Re: Lucene 9.9.0 Release

2023-11-21 Thread Michael McCandless
+1 Thank you for volunteering as RC Chris! Mike McCandless http://blog.mikemccandless.com On Tue, Nov 21, 2023 at 4:52 AM Chris Hegarty wrote: > Hi, > > It's been a while since the 9.8.0 release and we’ve accumulated quite a > few changes. I’d like to propose that we release 9.9.0. > > If