Re: Solr Gradle build (SOLR-13452)

2019-11-14 Thread Dawid Weiss
> org.asciidoctor:asciidoctorj=1.6.0-alpha.5 > > with > > org.asciidoctor:asciidoctor-ant=1.6.2 > org.asciidoctor:asciidoctorj=1.6.2 You don't need to add asciidoctor-ant - it isn't used anywhere as an explicit dependency. > If I remove one or both, and try “gw jarChecksums” Bad Things Happen.

Re: Solr Gradle build (SOLR-13452)

2019-11-14 Thread Anshum Gupta
Sorry, I am just looking at this now and about to call it a night soon. I'll try and get to it tomorrow/todayi.e Friday but if you get to it before I do, please move forward. On Wed, Nov 13, 2019 at 4:26 PM Erick Erickson wrote: > Anshum et. al. : > > It’s been a busy day, never got back to

Re: Solr Gradle build (SOLR-13452)

2019-11-13 Thread Erick Erickson
OK, so I went ahead and added my changes to make parallel license directories for the nonce (Lucene and Solr). Dawid: If you’d like to see if this now breaks for you like it did for me, feel free ;). It works for me _AFTER_ I replaced the line in the top level versions.props file (this is what

Re: Solr Gradle build (SOLR-13452)

2019-11-13 Thread Erick Erickson
It looks like it’ll be very difficult to have the “jar checksum” stuff work seamlessly between Ant and Gradle, they tend to overwrite each other resulting in a zillion changes depending on which one you ran last. I see three options: 1> tell people NOT to run the Gradle jarChecksums. I doubt

Re: Solr Gradle build (SOLR-13452)

2019-11-13 Thread Erick Erickson
Anshum et. al. : It’s been a busy day, never got back to it. I’ll try to push my changes, mostly updating the dependencies tonight. It’s not ready to merge into master yet, there’s this problem: ant -Dtestcase=TestKoreanTokenizer test fails with: java.lang.RuntimeException: Cannot find

Re: Solr Gradle build (SOLR-13452)

2019-11-13 Thread Anshum Gupta
Hey Erick, Any updates on this? Just checking in and though I'm not a gradle guru, I'd be happy to help as much as I can :) -Anshum On Tue, Nov 12, 2019 at 7:32 PM Erick Erickson wrote: > Final note before I turn in. “ant -Dtestcase=TestKoreanTokenizer” fails > OOB on the gradle_8 branch

Re: Solr Gradle build (SOLR-13452)

2019-11-13 Thread Dawid Weiss
I would really like you help out but you seem special. ;) Is your checkout clean (git clean -xfd .), do you have any locally modified files (git status)? I just ran ./gradlew jarChecksums on two different machines (Windows, Linux) and everything passed, look: :~/work-ssd/lucene-solr$ ./gradlew

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Erick Erickson
Final note before I turn in. “ant -Dtestcase=TestKoreanTokenizer” fails OOB on the gradle_8 branch with: java.lang.RuntimeException: Cannot find userdict.txt in test classpath! I see on master that that file is copied into

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Erick Erickson
Apparently org.asciidoctor:asciidoctorj=1.6.2 also cures my problem. Mark had put org.asciidoctor:asciidoctorj=1.6.0-alpha.5 in the top level versions.props so I don’t quite know if it belongs there or not. Erick > On Nov 12, 2019, at 4:35 PM, Dawid Weiss wrote: > > Oh, sorry -- I thought

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Erick Erickson
Dawid: I took my change back out and I’m failing again. Both gw jarChecksums and ./gradlew build -x test error out with: Execution failed for task ':solr:jarChecksums'. > Could not resolve all dependencies for configuration > ':solr:solr-ref-guide:tools'. > Could not find

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Dawid Weiss
Oh, sorry -- I thought you meant this line to be added to the main dependencies section (not buildScript's). D. On Tue, Nov 12, 2019 at 10:14 PM Anshum Gupta wrote: > > I didn't add this. This is already in the gradle_8 branch. > > What branch are you looking at? Don't you see this too ? > > >

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Anshum Gupta
I didn't add this. This is already in the gradle_8 branch. What branch are you looking at? Don't you see this too ? On Tue, Nov 12, 2019 at 12:56 PM Dawid Weiss wrote: > > Looking at the following file: > > solr/solr-ref-guide/build.gradle > > > > I see the apparently missing dependency: > >

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Dawid Weiss
> Looking at the following file: > solr/solr-ref-guide/build.gradle > > I see the apparently missing dependency: The buildscript dependency is there because, well, we use it from the script itself. For the "tools" configuration classpath the dependency is not missing, it's correct without the

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Anshum Gupta
Looking at the following file: *solr/solr-ref-guide/build.gradle* I see the apparently missing dependency: *dependencies {* *classpath "org.asciidoctor:asciidoctorj:1.6.0-alpha.5"* *}* I also see this TODO: *// TODO 4: currently buildscript dependencies are hardcoded

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Dawid Weiss
What command did you use? Are you sure you're running the "wrapper" script (gradlew) and not just any gradle version installed on the system? I ask because I just ran this and everything is fine: ./gradlew -p solr/solr-ref-guide buildSite The exception you're getting indicates a missing

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Erick Erickson
I just pulled down the new gradle_8 branch and got this error: * What went wrong: Execution failed for task ':solr:solr-ref-guide:compileToolsJava'. > Could not resolve all files for configuration ':solr:solr-ref-guide:tools'. > Could not find org.asciidoctor:asciidoctorj:. Required by:

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Erick Erickson
Dawid: Cassandra is away for a bit, so I created SOLR-13922 and assigned it to you. I don’t have much real understanding of the problem so the JIRA statement may need amending. Best, Erick > On Nov 12, 2019, at 4:05 AM, Dawid Weiss wrote: > >> There’s one current problem with it, which may

Re: Solr Gradle build (SOLR-13452)

2019-11-12 Thread Dawid Weiss
> There’s one current problem with it, which may be something in my env: in the > grade_7_refguide branch the HTML files were generated in > ./solr/solr-ref-guide/build, but now they are in the top-level ./build > directory. I think Mark has configured gradle defaults to be specifically this

Re: Solr Gradle build (SOLR-13452)

2019-11-11 Thread Cassandra Targett
I was able to get the changes Dawid and I worked out in the gradle_7_refguide branch merged into the gradle_8 branch. There’s one current problem with it, which may be something in my env: in the grade_7_refguide branch the HTML files were generated in ./solr/solr-ref-guide/build, but now they

Solr Gradle build (SOLR-13452)

2019-11-11 Thread Erick Erickson
I’m trying to push this forward. I intend to keep working on the latest branch of Mark’s Gradle build (jira/SOLR-13452_gradle_8). This is a plea for anyone interested to at least glance at any updates to that JIRA and chime in if you have any hints. Also, feel free to update that branch