Re: svn commit: r1363272 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java

2012-07-23 Thread Martijn v Groningen
Thanks for also taking a look at the test failures! On 20 July 2012 19:14, Robert Muir rcm...@gmail.com wrote: Hi Martinj: thanks for looking into this! I think have a better fix for these: the problem is actually in the AssertingAtomicReaders that AssertingDirectoryReader wraps its

RE: svn commit: r1363272 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java

2012-07-23 Thread Uwe Schindler
Hi, Thanks for also taking a look at the test failures! On 20 July 2012 19:14, Robert Muir rcm...@gmail.com wrote: Hi Martinj: thanks for looking into this! I think have a better fix for these: the problem is actually in the AssertingAtomicReaders that AssertingDirectoryReader

Re: svn commit: r1363272 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java

2012-07-23 Thread Martijn v Groningen
That is wanted! We want to test SlowMultiReaderWrapper and verify that it really behaves like a full conformant AtomicReader. Because of that we sometimes war with it. The fix Robert did is fine and is identical to the one we did in the past. As this is no real Lucene usage pattern, not

RE: svn commit: r1363272 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java

2012-07-23 Thread Uwe Schindler
, 2012 10:44 AM To: dev@lucene.apache.org Subject: Re: svn commit: r1363272 - /lucene/dev/trunk/lucene/test- framework/src/java/org/apache/lucene/util/LuceneTestCase.java That is wanted! We want to test SlowMultiReaderWrapper and verify that it really behaves like a full conformant

Re: svn commit: r1363272 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java

2012-07-20 Thread Robert Muir
Hi Martinj: thanks for looking into this! I think have a better fix for these: the problem is actually in the AssertingAtomicReaders that AssertingDirectoryReader wraps its subreaders with. So I added the invisible-cache-key hack there, and removed it completely from LuceneTestCase. I tested