Re: [JENKINS] Lucene-main-Linux (64bit/jdk-16) - Build # 31986 - Unstable!

2021-12-20 Thread Patrick Zhai
My bad, I should have added 1 to the alphabet size, I assumed it was exclusive. Here's PR fixing it: https://github.com/apache/lucene/pull/559 Policeman Jenkins Server 于2021年12月20日周一 21:34写道: > Build: https://jenkins.thetaphi.de/job/Lucene-main-Linux/31986/ > Java: 64bit/jdk-16

Re: Welcome Haoyu (Patrick) Zhai as Lucene Committer

2021-12-20 Thread Michael Gibney
Congratulations, and welcome! Michael On Mon, Dec 20, 2021 at 1:17 PM Steve Rowe wrote: > Congrats and welcome, Patrick! > > — > Steve > > > On Dec 19, 2021, at 4:11 AM, Dawid Weiss wrote: > > > > Hello everyone! > > > > Please welcome Haoyu Zhai as the latest Lucene committer. You may also >

Re: [Heads up] Test framework package rename

2021-12-20 Thread Dawid Weiss
> You are correct (you’re safe). Lucene has bumped the minimum JDK > to 17, right? If so, you could use MethodHandles.Lookup::ensureInitialized. It'll probably go into the 9x branch which will remain on older JDKs. That Class.forName trick is so simple and straightforward that I think I'm going

Re: Welcome Haoyu (Patrick) Zhai as Lucene Committer

2021-12-20 Thread Steve Rowe
Congrats and welcome, Patrick! — Steve > On Dec 19, 2021, at 4:11 AM, Dawid Weiss wrote: > > Hello everyone! > > Please welcome Haoyu Zhai as the latest Lucene committer. You may also > know Haoyu as Patrick - this is perhaps his kind gesture to those of > us whose tongues are less flexible

Re: Welcome Haoyu (Patrick) Zhai as Lucene Committer

2021-12-20 Thread Houston Putman
Congrats Haoyu! On Mon, Dec 20, 2021 at 12:42 PM Anshum Gupta wrote: > Congratulations and welcome, Haoyu! > > On Sun, Dec 19, 2021 at 1:12 AM Dawid Weiss wrote: > >> Hello everyone! >> >> Please welcome Haoyu Zhai as the latest Lucene committer. You may also >> know Haoyu as Patrick - this is

Re: [Heads up] Test framework package rename

2021-12-20 Thread Chris Hegarty
Hi David, > On 20 Dec 2021, at 17:12, Dawid Weiss wrote: > > [snip] > >> I think that the approach is reasonable (to inject ’test’ into the package >> name between the reverse DNS prefix and the specific logical technology >> suffix). > > It's actually '.tests'... Robert (Muir) suggested

Re: Welcome Haoyu (Patrick) Zhai as Lucene Committer

2021-12-20 Thread Anshum Gupta
Congratulations and welcome, Haoyu! On Sun, Dec 19, 2021 at 1:12 AM Dawid Weiss wrote: > Hello everyone! > > Please welcome Haoyu Zhai as the latest Lucene committer. You may also > know Haoyu as Patrick - this is perhaps his kind gesture to those of > us whose tongues are less flexible in

Re: [Heads up] Test framework package rename

2021-12-20 Thread Dawid Weiss
Hi Chris! > [ not a review ] [feedback is always welcome, especially from you] > I think that the approach is reasonable (to inject ’test’ into the package > name between the reverse DNS prefix and the specific logical technology > suffix). It's actually '.tests'... Robert (Muir) suggested

Re: [Heads up] Test framework package rename

2021-12-20 Thread Chris Hegarty
Hi David, [ not a review ] > On 20 Dec 2021, at 14:54, Dawid Weiss wrote: > > > Hello everyone, > > I've completed the task of getting the test framework to not share any > packages with Lucene core - this is here: > > https://issues.apache.org/jira/browse/LUCENE-10301 >

Re: Welcome Haoyu (Patrick) Zhai as Lucene Committer

2021-12-20 Thread Greg Miller
Congrats and welcome! On Mon, Dec 20, 2021 at 6:08 AM Jan Høydahl wrote: > > Welcome Patrick! > > Jan > > 19. des. 2021 kl. 10:11 skrev Dawid Weiss : > > Hello everyone! > > Please welcome Haoyu Zhai as the latest Lucene committer. You may also > know Haoyu as Patrick - this is perhaps his kind

Re: [Heads up] Test framework package rename

2021-12-20 Thread Dawid Weiss
> large that it makes the Github UI unresponsive, so I'll review the > diff locally while check runs. > Right - I did the same, actually. You can grep/throw away most of the lines that have imports in them as these are irrelevant. D.

Re: [Heads up] Test framework package rename

2021-12-20 Thread Robert Muir
Thanks for doing this!! Give me a few minutes, I'll verify everything passes on linux, and review it locally. And I agree, sooner than later is better as it will conflict with anything and everything. Due to the expected noise of the import statements, the change is so large that it makes the

[Heads up] Test framework package rename

2021-12-20 Thread Dawid Weiss
Hello everyone, I've completed the task of getting the test framework to not share any packages with Lucene core - this is here: https://issues.apache.org/jira/browse/LUCENE-10301 https://github.com/apache/lucene/pull/551 Basically everything remains the same, except for the changed package

Re: Welcome Haoyu (Patrick) Zhai as Lucene Committer

2021-12-20 Thread Jan Høydahl
Welcome Patrick! Jan > 19. des. 2021 kl. 10:11 skrev Dawid Weiss : > > Hello everyone! > > Please welcome Haoyu Zhai as the latest Lucene committer. You may also > know Haoyu as Patrick - this is perhaps his kind gesture to those of > us whose tongues are less flexible in pronouncing difficult

Searching Lucene FAQ with Lucene

2021-12-20 Thread Michael Wechner
Hi I am working on a webapp called "Katie" in order to detect duplicated questions https://ukatie.com/ As a test case I have imported the Lucene FAQ https://cwiki.apache.org/confluence/display/LUCENE/LuceneFAQ to https://ukatie.com/#/faq/9f206aec-5223-4e03-a2fc-c16e4b885ef8/en and made