Just for the update, Michael, I went ahead and applied your reverted
changes to the `main` branch as well. I will introduce the new Lucene 94
codec.
On Thu, Jul 21, 2022 at 11:08 AM Mayya Sharipova
wrote:
> Thanks Michael for reverting the changes.
> I think we should do the reversion also on
Thanks Michael for reverting the changes.
I think we should do the reversion also on the main branch, and later
introduce Lucene94 Codecs; otherwise I think it would be more difficult for
us to apply changes from main to branch_9x if they diverge so much.
On Thu, Jul 21, 2022 at 9:18 AM Michael
Ha, yes-- it's now patched on 9.3 (in addition to 9x / main). Thanks Mike!
Cheers,
-Greg
On Thu, Jul 21, 2022 at 3:31 AM Michael McCandless
wrote:
>
> Oh, nevermind! I see the PR/blocker issue, thanks Greg.
>
> EventuallyConsistentMikeException!
>
> Mike McCandless
>
>
Ack, thanks Ignacio for the quick approval. Just merged the fix onto
the 9.3 branch.
Cheers,
-Greg
On Thu, Jul 21, 2022 at 12:32 AM Ignacio Vera wrote:
>
> Hi Greg,
>
> Yes please fix the test in branch 9.3, I have approved the PR.
>
> On Thu, Jul 21, 2022 at 12:08 AM Greg Miller wrote:
>>
>>
OK, I reverted the commit that introduced 93 codec on branch_9x and
branch_9_3. I guess it should probably get reverted on main too, but
since we have PRs that depend on it I wasn't sure if maybe we'd want
to rename to 94 instead of reverting? Anyway either way is fine by me.
On Wed, Jul 20, 2022
Just an update on the migration procedure.
> 2. Send a message to dev@ stating new issues should now be opened in
github
> 3. Start the migration
> I think the difference with this and what was previously described on
this thread is there would be no downtime for new issues.
I confirmed it's safe
OK I have an hour or so before vacation fun begins in earnest - let me
see if this is as easy as I claimed ...
On Wed, Jul 20, 2022 at 7:21 PM Mayya Sharipova
wrote:
>
> Hi Julie,
> thanks for raising this point, I was also thinking about it.
> I think it would be valuable to clarify what
I'm sorry about this no op change that is so intrusive. Indeed it would be
better to roll it back, and I hope in the future we can find a better way
to evolve these codecs.
I would ideally handle this since I added in the first place.
Unfortunately I'm traveling until mid week next week and won't
Super, thanks Ignacio. And thanks for volunteering as RM!
Mike McCandless
http://blog.mikemccandless.com
On Thu, Jul 21, 2022 at 6:32 AM Ignacio Vera wrote:
> indeed, just waiting for him to do the honours and push the PR.
>
> On Thu, Jul 21, 2022 at 12:30 PM Michael McCandless <
>
indeed, just waiting for him to do the honours and push the PR.
On Thu, Jul 21, 2022 at 12:30 PM Michael McCandless <
luc...@mikemccandless.com> wrote:
> Greg fixed a test failure that impacts 9.3, and opened a PR and blocker
> issue: https://issues.apache.org/jira/browse/LUCENE-10659
>
> I
Oh, nevermind! I see the PR/blocker issue, thanks Greg.
EventuallyConsistentMikeException!
Mike McCandless
http://blog.mikemccandless.com
On Thu, Jul 21, 2022 at 6:28 AM Michael McCandless <
luc...@mikemccandless.com> wrote:
> Should this maybe also be backported to the 9.3.0 branch? Did
Greg fixed a test failure that impacts 9.3, and opened a PR and blocker
issue: https://issues.apache.org/jira/browse/LUCENE-10659
I think we should merge it for 9.3.0?
Mike McCandless
http://blog.mikemccandless.com
On Wed, Jul 20, 2022 at 7:43 PM Julie Tibshirani
wrote:
> Hello Mayya, I can
Should this maybe also be backported to the 9.3.0 branch? Did the original
change land before that branch was cut?
Mike McCandless
http://blog.mikemccandless.com
On Wed, Jul 20, 2022 at 5:46 PM Greg Miller wrote:
> OK, I think these test failures should now be resolved (on both main
> and
Hi Greg,
Yes please fix the test in branch 9.3, I have approved the PR.
On Thu, Jul 21, 2022 at 12:08 AM Greg Miller wrote:
> Thanks Ignacio! I just created
> https://issues.apache.org/jira/browse/LUCENE-10659 as a proposed
> blocker for 9.3. It's a small bug fix for a unit test I recently
>
14 matches
Mail list logo