[
https://issues.apache.org/jira/browse/LUCENE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6706.
---
Resolution: Fixed
Support Payload scoring for all SpanQueries
Alan Woodward created LUCENE-6716:
-
Summary: Improve SpanPayloadCheckQuery API
Key: LUCENE-6716
URL: https://issues.apache.org/jira/browse/LUCENE-6716
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6716:
--
Attachment: LUCENE-6716.patch
Improve SpanPayloadCheckQuery API
[
https://issues.apache.org/jira/browse/LUCENE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653614#comment-14653614
]
Alan Woodward commented on LUCENE-6489:
---
Span payloads are a bit nicer now, so I
[
https://issues.apache.org/jira/browse/LUCENE-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6580:
--
Attachment: LUCENE-6580.patch
Patch, taking into account Adrien's suggestion.
Allow
[
https://issues.apache.org/jira/browse/LUCENE-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward reassigned LUCENE-6580:
-
Assignee: Alan Woodward
Allow defined-width gaps in SpanNearQuery
[
https://issues.apache.org/jira/browse/LUCENE-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6580:
--
Attachment: LUCENE-6580.patch
Patch updated to trunk. I'd like to get this in for 5.3 if
[
https://issues.apache.org/jira/browse/LUCENE-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6513:
--
Attachment: LUCENE-6513.patch
Updated to trunk. I don't think there's any easier way to solve
[
https://issues.apache.org/jira/browse/LUCENE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652084#comment-14652084
]
Alan Woodward commented on LUCENE-6706:
---
Bah, sorry Steve, will fix.
Support
[
https://issues.apache.org/jira/browse/LUCENE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward reassigned LUCENE-6706:
-
Assignee: Alan Woodward
Support Payload scoring for SpanOrQuery
[
https://issues.apache.org/jira/browse/LUCENE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647444#comment-14647444
]
Alan Woodward commented on LUCENE-6706:
---
I think rather than having a whole bunch
[
https://issues.apache.org/jira/browse/LUCENE-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6580.
---
Resolution: Fixed
Fix Version/s: 5.3
Allow defined-width gaps in SpanNearQuery
[
https://issues.apache.org/jira/browse/SOLR-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward reassigned SOLR-8194:
---
Assignee: Alan Woodward
> Improve error reporting UpdateRequest
>
[
https://issues.apache.org/jira/browse/SOLR-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971422#comment-14971422
]
Alan Woodward commented on SOLR-8194:
-
Throwing NPE is fine, I think, but we should do that when add()
[
https://issues.apache.org/jira/browse/LUCENE-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967504#comment-14967504
]
Alan Woodward commented on LUCENE-2878:
---
It's a bit disturbing quite how long it takes to scroll to
[
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6845:
--
Attachment: LUCENE-6845_norenames.patch
Ah, I see what you mean now.
I've changed the patch
[
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6845.
---
Resolution: Fixed
> Merge Spans and SpanScorer
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8221:
Attachment: SOLR-8221.patch
Patch changing the solrj tests as well. All tests pass.
> Some
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8221:
Attachment: SOLR-8221.patch
Patch.
MiniSolrCloudCluster now takes a Path to a base directory in its
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978445#comment-14978445
]
Alan Woodward commented on SOLR-8221:
-
Maybe we could add a 'newcollection' parameter to the core
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978584#comment-14978584
]
Alan Woodward commented on SOLR-8221:
-
bq. Would be better to spend that effort on making the wait
[
https://issues.apache.org/jira/browse/SOLR-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976632#comment-14976632
]
Alan Woodward commented on SOLR-8216:
-
I *think* that ADMIN_PATHS can just be replaced with a
[
https://issues.apache.org/jira/browse/SOLR-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976690#comment-14976690
]
Alan Woodward commented on SOLR-8216:
-
Why's that? LukeRequestHandler should be core-specific,
[
https://issues.apache.org/jira/browse/SOLR-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976737#comment-14976737
]
Alan Woodward commented on SOLR-8216:
-
Thinking about this more, /admin/info/system is a node-specific
[
https://issues.apache.org/jira/browse/SOLR-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976715#comment-14976715
]
Alan Woodward commented on SOLR-8196:
-
Bit late to nitpick, sorry, but instead of passing in an
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8221.
-
Resolution: Fixed
Fix Version/s: Trunk
5.4
> Some improvements to
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8221.
-
Resolution: Fixed
> Some improvements to MiniSolrCloudCluster API
>
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward reopened SOLR-8221:
-
> Some improvements to MiniSolrCloudCluster API
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979082#comment-14979082
]
Alan Woodward commented on SOLR-8221:
-
Yes, looks like SSL config is not getting propagated through the
[
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6845:
--
Attachment: LUCENE-6845_norenames.patch.txt
Updated patch, with ScoringWrapperSpans. I also
Alan Woodward created SOLR-8221:
---
Summary: Some improvements to MiniSolrCloudCluster API
Key: SOLR-8221
URL: https://issues.apache.org/jira/browse/SOLR-8221
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8253.
-
Resolution: Fixed
> AbstractDistribZkTestBase can fail to shutdown its ZkServer
>
Alan Woodward created SOLR-8278:
---
Summary: ConfigSetService should use NIO2
Key: SOLR-8278
URL: https://issues.apache.org/jira/browse/SOLR-8278
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-8278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8278:
Attachment: SOLR-8278.patch
Patch. As well as changing ConfigSetService, this also alters
[
https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8260.
-
Resolution: Fixed
> Use NIO2 APIs in core discovery
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8255:
Fix Version/s: 5.4
> MiniSolrCloudCluster doesn't use a thread-safe list for its jetties
>
[
https://issues.apache.org/jira/browse/SOLR-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8254:
Fix Version/s: 5.4
> HttpSolrCall.getCoreByCollection can throw NPE if there are no leaders up
>
[
https://issues.apache.org/jira/browse/SOLR-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8253:
Fix Version/s: 5.4
> AbstractDistribZkTestBase can fail to shutdown its ZkServer
>
[
https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8260:
Fix Version/s: 5.4
> Use NIO2 APIs in core discovery
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-5409.
-
Resolution: Fixed
Assignee: Alan Woodward
Fix Version/s: (was: 4.9)
[
https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997049#comment-14997049
]
Alan Woodward commented on SOLR-8260:
-
bq. We should on working to disallow java.io.File throughout
Alan Woodward created SOLR-8259:
---
Summary: Add getCoreContainer() method to SolrJettyRunner
Key: SOLR-8259
URL: https://issues.apache.org/jira/browse/SOLR-8259
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8254.
-
Resolution: Fixed
Assignee: Alan Woodward
> HttpSolrCall.getCoreByCollection can throw NPE
[
https://issues.apache.org/jira/browse/SOLR-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8259:
Summary: Add getCoreContainer() method to JettySolrRunner (was: Add
getCoreContainer() method to
[
https://issues.apache.org/jira/browse/SOLR-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8259:
Attachment: SOLR-8259.patch
Patch removing JettySolrRunner.getDispatchFilter() and adding
[
https://issues.apache.org/jira/browse/SOLR-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996790#comment-14996790
]
Alan Woodward commented on SOLR-8254:
-
bq. I don't know, we do not tend to put a lot of SolrCloud
Alan Woodward created SOLR-8260:
---
Summary: Use NIO2 APIs in core discovery
Key: SOLR-8260
URL: https://issues.apache.org/jira/browse/SOLR-8260
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8260:
Attachment: SOLR-8260.patch
Patch. Tests pass, running precommit now.
> Use NIO2 APIs in core
[
https://issues.apache.org/jira/browse/SOLR-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8255.
-
Resolution: Fixed
> MiniSolrCloudCluster doesn't use a thread-safe list for its jetties
>
[
https://issues.apache.org/jira/browse/SOLR-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8259.
-
Resolution: Fixed
Fix Version/s: 5.4
> Add getCoreContainer() method to JettySolrRunner
>
[
https://issues.apache.org/jira/browse/SOLR-8278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8278:
Fix Version/s: 5.4
> ConfigSetService should use NIO2
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-8278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8278.
-
Resolution: Fixed
> ConfigSetService should use NIO2
> -
>
>
Alan Woodward created SOLR-8282:
---
Summary: Move Solr internal APIs to NIO2, and ban use of
java.io.File
Key: SOLR-8282
URL: https://issues.apache.org/jira/browse/SOLR-8282
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002079#comment-15002079
]
Alan Woodward commented on SOLR-8260:
-
There isn't, but an overarching JIRA ticket isn't a bad idea.
[
https://issues.apache.org/jira/browse/SOLR-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002125#comment-15002125
]
Alan Woodward commented on SOLR-8282:
-
There are a whole bunch of smallish steps that can be taken here
[
https://issues.apache.org/jira/browse/SOLR-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006470#comment-15006470
]
Alan Woodward commented on SOLR-8280:
-
I have a half-implemented patch hanging around somewhere that
Alan Woodward created SOLR-8255:
---
Summary: MiniSolrCloudCluster can return before all its jetties
are ready
Key: SOLR-8255
URL: https://issues.apache.org/jira/browse/SOLR-8255
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8255:
Description:
MiniSolrCloudCluster uses a LinkedList<> to hold its jetties. However,
multi-threaded
[
https://issues.apache.org/jira/browse/SOLR-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996354#comment-14996354
]
Alan Woodward commented on SOLR-8255:
-
Simple patch:
{code}
diff --git
Alan Woodward created SOLR-8254:
---
Summary: HttpSolrCall.getCoreByCollection can throw NPE if there
are no leaders up
Key: SOLR-8254
URL: https://issues.apache.org/jira/browse/SOLR-8254
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996296#comment-14996296
]
Alan Woodward commented on SOLR-8253:
-
See http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/14548/
[
https://issues.apache.org/jira/browse/SOLR-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996313#comment-14996313
]
Alan Woodward commented on SOLR-8254:
-
Lines 781-794:
{code}
//Hitting the leaders is useful when
Alan Woodward created SOLR-8253:
---
Summary: AbstractDistribZkTestBase can fail to shutdown its
ZkServer
Key: SOLR-8253
URL: https://issues.apache.org/jira/browse/SOLR-8253
Project: Solr
Issue
Alan Woodward created LUCENE-6871:
-
Summary: Move SpanQueries out of .spans package
Key: LUCENE-6871
URL: https://issues.apache.org/jira/browse/LUCENE-6871
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982318#comment-14982318
]
Alan Woodward commented on LUCENE-6870:
---
+1
> Make DisjunctionMaxQuery immutable
>
[
https://issues.apache.org/jira/browse/LUCENE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6871:
--
Attachment: LUCENE-6871.patch
Here is a patch for stage 1
> Move SpanQueries out of .spans
[
https://issues.apache.org/jira/browse/LUCENE-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6884.
---
Resolution: Fixed
Fix Version/s: 5.4
> Analyzer.tokenStream() shouldn't throw
[
https://issues.apache.org/jira/browse/LUCENE-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6884:
--
Attachment: LUCENE-6884.patch
Patch, mostly just removing now-redundant try-catch blocks in
Alan Woodward created LUCENE-6884:
-
Summary: Analyzer.tokenStream() shouldn't throw IOException
Key: LUCENE-6884
URL: https://issues.apache.org/jira/browse/LUCENE-6884
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986069#comment-14986069
]
Alan Woodward commented on LUCENE-6871:
---
The idea is that SpanQueries become just like normal
[
https://issues.apache.org/jira/browse/LUCENE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983133#comment-14983133
]
Alan Woodward commented on LUCENE-6871:
---
Only those Weights associated with Span-like queries, so
[
https://issues.apache.org/jira/browse/LUCENE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987031#comment-14987031
]
Alan Woodward commented on LUCENE-6871:
---
Right, but SpanNot and SpanOr will still be separate
[
https://issues.apache.org/jira/browse/LUCENE-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6844.
---
Resolution: Fixed
> Add 'includeSpanScore' boolean to PayloadScoreQuery
>
Alan Woodward created LUCENE-6844:
-
Summary: Add 'includeSpanScore' boolean to PayloadScoreQuery
Key: LUCENE-6844
URL: https://issues.apache.org/jira/browse/LUCENE-6844
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6844:
--
Attachment: LUCENE-6844.patch
Patch.
> Add 'includeSpanScore' boolean to PayloadScoreQuery
>
[
https://issues.apache.org/jira/browse/SOLR-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8156:
Attachment: SOLR-8156.patch
Patch removing error logging from RequestHandlerBase entirely. I've
Alan Woodward created LUCENE-6845:
-
Summary: Merge Spans and SpanScorer
Key: LUCENE-6845
URL: https://issues.apache.org/jira/browse/LUCENE-6845
Project: Lucene - Core
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6845:
--
Attachment: LUCENE-6845.patch
Patch.
Spans is merged entirely into SpanScorer, various
[
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6845:
--
Attachment: LUCENE-6845_norenames.patch
Patch without the renames, which should make changes
[
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966707#comment-14966707
]
Alan Woodward commented on LUCENE-6845:
---
bq. What is the purpose of SpanNotQueryâs getSpanScorer
[
https://issues.apache.org/jira/browse/LUCENE-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966710#comment-14966710
]
Alan Woodward commented on LUCENE-6850:
---
+1
Another possible optimization here is to check the
[
https://issues.apache.org/jira/browse/SOLR-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved SOLR-8151.
-
Resolution: Fixed
> OverseerCollectionMessageHandler shouldn't be logging informative data as WARN
Alan Woodward created SOLR-8156:
---
Summary: RequestHandlerBase.handleRequest logs stacktraces caused
by user requests
Key: SOLR-8156
URL: https://issues.apache.org/jira/browse/SOLR-8156
Project: Solr
Alan Woodward created SOLR-8151:
---
Summary: OverseerCollectionMessageHandler shouldn't be logging
informative data as WARN
Key: SOLR-8151
URL: https://issues.apache.org/jira/browse/SOLR-8151
Project:
[
https://issues.apache.org/jira/browse/SOLR-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951003#comment-14951003
]
Alan Woodward commented on SOLR-8151:
-
Patch is a trivial fix:
{code}
Index:
[
https://issues.apache.org/jira/browse/SOLR-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-8302:
Attachment: SOLR-8302.patch
Patch for trunk. This changes the SolrResourceLoader constructors to
Alan Woodward created SOLR-8302:
---
Summary: SolrResourceLoader should take a Path to its instance
directory, rather than a String
Key: SOLR-8302
URL: https://issues.apache.org/jira/browse/SOLR-8302
[
https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732020#comment-14732020
]
Alan Woodward commented on LUCENE-6590:
---
This looks great.
I think there's a bug in
[
https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6785:
--
Attachment: LUCENE-6785.patch
Here's a first-pass patch, just changing things in lucene-core.
Alan Woodward created LUCENE-6785:
-
Summary: Consider merging Query.rewrite() into Query.createWeight()
Key: LUCENE-6785
URL: https://issues.apache.org/jira/browse/LUCENE-6785
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738913#comment-14738913
]
Alan Woodward commented on LUCENE-6785:
---
I'm travelling at the moment, will put up a larger patch
[
https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6785:
--
Attachment: LUCENE-6785.patch
Patch with all tests passing.
bq. I don't think weights can
[
https://issues.apache.org/jira/browse/LUCENE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6489:
--
Attachment: LUCENE-6489.patch
Patch, this time with everything compiling properly... All
[
https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742579#comment-14742579
]
Alan Woodward commented on LUCENE-6785:
---
Do you mean the getCacheKey() method? It decouples query
[
https://issues.apache.org/jira/browse/LUCENE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743554#comment-14743554
]
Alan Woodward commented on LUCENE-6489:
---
Or just write another implementation. It's pretty
[
https://issues.apache.org/jira/browse/LUCENE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6489:
--
Attachment: LUCENE-6489.patch
Here's the final patch, after much fighting with svn.
[
https://issues.apache.org/jira/browse/LUCENE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6489.
---
Resolution: Fixed
Assignee: Alan Woodward
> Move span payloads to sandbox
>
[
https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745750#comment-14745750
]
Alan Woodward commented on LUCENE-6785:
---
[~jpountz] are you happy with the latest patch? Or do you
[
https://issues.apache.org/jira/browse/LUCENE-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-6716.
---
Resolution: Fixed
Thanks for the review David. PayloadSpanCollector will be dealt with in
[
https://issues.apache.org/jira/browse/LUCENE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-6489:
--
Attachment: LUCENE-6489.patch
Here is a patch that:
* moves PayloadScoreQuery,
801 - 900 of 2344 matches
Mail list logo