[jira] [Updated] (LUCENE-8368) facet by polygon

[ https://issues.apache.org/jira/browse/LUCENE-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8368: Attachment: LUCENE-8368.patch > facet by polygon > > >

[jira] [Created] (LUCENE-8368) facet by polygon

Robert Muir created LUCENE-8368: --- Summary: facet by polygon Key: LUCENE-8368 URL: https://issues.apache.org/jira/browse/LUCENE-8368 Project: Lucene - Core Issue Type: New Feature

[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension

[ https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520016#comment-16520016 ] Robert Muir commented on LUCENE-8367: - Looking at the code it seems like those ValueSources already

[jira] [Resolved] (LUCENE-8366) upgrade to icu 62.1

[ https://issues.apache.org/jira/browse/LUCENE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-8366. - Resolution: Fixed Fix Version/s: 7.5 trunk master: http://git-wip

[jira] [Commented] (LUCENE-7314) Graduate InetAddressPoint and LatLonPoint to core

[ https://issues.apache.org/jira/browse/LUCENE-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519825#comment-16519825 ] Robert Muir commented on LUCENE-7314: - +1 patch looks good. > Graduate InetAddressPo

[jira] [Commented] (LUCENE-8364) Refactor and clean up core geo api

[ https://issues.apache.org/jira/browse/LUCENE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519478#comment-16519478 ] Robert Muir commented on LUCENE-8364: - Also there is another problem with having Polygon create

[jira] [Commented] (LUCENE-8361) Make TestRandomChains check that filters preserve positions

[ https://issues.apache.org/jira/browse/LUCENE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519406#comment-16519406 ] Robert Muir commented on LUCENE-8361: - Both those limit-filters are broken and buggy by default

[jira] [Updated] (LUCENE-8366) upgrade to icu 62.1

[ https://issues.apache.org/jira/browse/LUCENE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8366: Attachment: LUCENE-8366.patch > upgrade to icu 62.1 > --- > >

[jira] [Created] (LUCENE-8366) upgrade to icu 62.1

Robert Muir created LUCENE-8366: --- Summary: upgrade to icu 62.1 Key: LUCENE-8366 URL: https://issues.apache.org/jira/browse/LUCENE-8366 Project: Lucene - Core Issue Type: Improvement

Re: Lucene/Solr 8.0

How can the end user actually use the biggest new feature: impacts and BMW? As far as I can tell, the issue to actually implement the necessary API changes (IndexSearcher/TopDocs/etc) is still open and unresolved, although there are some interesting ideas on it. This seems like a really big

[jira] [Commented] (LUCENE-8364) Refactor and clean up core geo api

[ https://issues.apache.org/jira/browse/LUCENE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518764#comment-16518764 ] Robert Muir commented on LUCENE-8364: - Also the relate/relatePoint changes to Polygon are a big

[jira] [Commented] (LUCENE-8364) Refactor and clean up core geo api

[ https://issues.apache.org/jira/browse/LUCENE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518757#comment-16518757 ] Robert Muir commented on LUCENE-8364: - Just looking, I have a few concerns: * what is the goal

Re: Status of solr tests

can we disable this bot already? On Fri, Jun 15, 2018, 7:25 PM Martin Gainty wrote: > Erick- > > appears that style mis-application may be categorised as INFO > are mixed in with SEVERE errors > > Would it make sense to filter the errors based on severity ? > > >

[jira] [Commented] (LUCENE-8041) All Fields.terms(fld) impls should be O(1) not O(log(N))

[ https://issues.apache.org/jira/browse/LUCENE-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510220#comment-16510220 ] Robert Muir commented on LUCENE-8041: - {quote} +1 to make term vectors consistent across the index

[jira] [Commented] (LUCENE-8041) All Fields.terms(fld) impls should be O(1) not O(log(N))

[ https://issues.apache.org/jira/browse/LUCENE-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509023#comment-16509023 ] Robert Muir commented on LUCENE-8041: - {quote} That sounds like the cart leading the horse (allowing

[jira] [Commented] (LUCENE-8041) All Fields.terms(fld) impls should be O(1) not O(log(N))

[ https://issues.apache.org/jira/browse/LUCENE-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508692#comment-16508692 ] Robert Muir commented on LUCENE-8041: - This has the downside that it sorts all fields on every call

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504650#comment-16504650 ] Robert Muir commented on LUCENE-8165: - I think these commits may also fix LUCENE-8164 too: I haven't

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504639#comment-16504639 ] Robert Muir commented on LUCENE-8165: - Thanks Adrien: (also for branching first!). I'm sorry I

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504554#comment-16504554 ] Robert Muir commented on LUCENE-8273: - If shinglefilter is the buggy one it should be banned from

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503137#comment-16503137 ] Robert Muir commented on LUCENE-8326: - I feel the same way as before: we shouldn't split up a class

[jira] [Resolved] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-7960. - Resolution: Fixed Fix Version/s: master (8.0) 7.4 Thank you [~iwesp

[jira] [Created] (LUCENE-8348) Remove [Edge]NgramTokenizer min/max defaults consistent with Filter

Robert Muir created LUCENE-8348: --- Summary: Remove [Edge]NgramTokenizer min/max defaults consistent with Filter Key: LUCENE-8348 URL: https://issues.apache.org/jira/browse/LUCENE-8348 Project: Lucene

[jira] [Commented] (LUCENE-7690) TestSimpleTextPointsFormat.testWithExceptions() failure

[ https://issues.apache.org/jira/browse/LUCENE-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501124#comment-16501124 ] Robert Muir commented on LUCENE-7690: - Sorry for the wrong messages: my dyslexia in commit message

discuss: stop adding 'via' from CHANGES.txt entries (take two)

I raised this issue a few years ago, and no consensus was reached [1] I'm asking if we can take the time to revisit the issue. Back then it was subversion days, and you had "patch-uploaders" and "contributors". With git now, I believe the situation is even a bit more extreme, because the

[jira] [Assigned] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-7960: --- Assignee: Robert Muir > NGram filters -- preserve the original token when it is outs

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497871#comment-16497871 ] Robert Muir commented on LUCENE-8165: - yeah, lets split it up. > ban Arrays.copyOfRa

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497498#comment-16497498 ] Robert Muir commented on LUCENE-8165: - This looks good, thanks! I had forgotten about this issue

[jira] [Commented] (LUCENE-8342) Can we enforce more properties on fields like uniquness

[ https://issues.apache.org/jira/browse/LUCENE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497263#comment-16497263 ] Robert Muir commented on LUCENE-8342: - +1: it would be a big improvement to validate this in IW

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497261#comment-16497261 ] Robert Muir commented on LUCENE-8335: - as a followup, I think lets support checkindex validation

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497237#comment-16497237 ] Robert Muir commented on LUCENE-8341: - Yes I agree it is a shame CheckIndex cannot enforce the check

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495109#comment-16495109 ] Robert Muir commented on LUCENE-8335: - Mike, I think nearly all of your same arguments could be made

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491970#comment-16491970 ] Robert Muir commented on LUCENE-8335: - i dont think lucene needs to enforce this. from my perspective

[jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489155#comment-16489155 ] Robert Muir commented on LUCENE-8330: - +1 > Detach IndexWriter from MergePol

[jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488912#comment-16488912 ] Robert Muir commented on LUCENE-8330: - Can we remove the hasDeletions from the interface? It makes

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488345#comment-16488345 ] Robert Muir commented on LUCENE-8326: - First looking at the API change, it would be good

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488317#comment-16488317 ] Robert Muir commented on LUCENE-8326: - Sorry, it may have been my fault. I checked "patch att

[jira] [Commented] (LUCENE-8325) smartcn analyzer can't handle SURROGATE char

[ https://issues.apache.org/jira/browse/LUCENE-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487158#comment-16487158 ] Robert Muir commented on LUCENE-8325: - +1, thank you for fixing this. > smartcn analyzer ca

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483907#comment-16483907 ] Robert Muir commented on LUCENE-8311: - Yeah, I was thinking more along the lines of LowPhrase (still

Re: [More Like This] I would like to contribute

On Tue, May 22, 2018 at 7:03 AM, Alessandro Benedetti wrote: > Hi Robert, > thanks for the feedback. > I read your comment last year and you I agreed completely. > So I started step by step, with the refactor first. > > The first contribution is isolating a part of the

[jira] [Moved] (LUCENE-8326) More Like This Params Refactor

[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir moved SOLR-12299 to LUCENE-8326: Security: (was: Public) Component/s: (was: MoreLikeThis

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483764#comment-16483764 ] Robert Muir commented on LUCENE-8311: - I wonder if its difficult to test with another similarity

[jira] [Commented] (LUCENE-8325) smartcn analyzer can't handle SURROGATE char

[ https://issues.apache.org/jira/browse/LUCENE-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483731#comment-16483731 ] Robert Muir commented on LUCENE-8325: - Patch looks good but i would change two things: The constant

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483721#comment-16483721 ] Robert Muir commented on LUCENE-7960: - looks good. thank you for making the updates. > NGram filt

Re: [More Like This] I would like to contribute

For proposed api, behavior changes or refactoring to these classes, I really recommend using LUCENE issues for those instead of SOLR ones. Otherwise they can get missed. As far as feedback, personally I tried to give it on LUCENE-7498 a year ago but wasn't sure what happened as further comments

[jira] [Commented] (LUCENE-8312) Leverage impacts for SynonymQuery

[ https://issues.apache.org/jira/browse/LUCENE-8312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480733#comment-16480733 ] Robert Muir commented on LUCENE-8312: - I didn't mean to imply it had to be solved on the issue, just

Re: [JENKINS-EA] Lucene-Solr-7.x-Windows (64bit/jdk-11-ea+5) - Build # 597 - Still Unstable!

I am also +1 for throwing IllegalStateException in the WindowsFS constructor if Constants.WINDOWS == true. This way the failure will be 100% clear next time. On Fri, May 18, 2018 at 9:42 AM, Robert Muir <rcm...@gmail.com> wrote: > WindowsFS does not work on window: > https://githu

Re: [JENKINS-EA] Lucene-Solr-7.x-Windows (64bit/jdk-11-ea+5) - Build # 597 - Still Unstable!

WindowsFS does not work on window: https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleTemporaryFilesCleanup.java#L168-L169 But these new tests instantiate WindowsFS explicitly without an assume for

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480559#comment-16480559 ] Robert Muir commented on LUCENE-8273: - is the TokenBuffer class in the patch actually used? >

[jira] [Commented] (LUCENE-8321) Allow composite readers to have more than 2B documents

[ https://issues.apache.org/jira/browse/LUCENE-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480519#comment-16480519 ] Robert Muir commented on LUCENE-8321: - Also I think the IW accounting needs to stay. Considering we

[jira] [Commented] (LUCENE-8312) Leverage impacts for SynonymQuery

[ https://issues.apache.org/jira/browse/LUCENE-8312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480498#comment-16480498 ] Robert Muir commented on LUCENE-8312: - I like the idea of factoring out the DISI, so

[jira] [Commented] (LUCENE-8321) Allow composite readers to have more than 2B documents

[ https://issues.apache.org/jira/browse/LUCENE-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480479#comment-16480479 ] Robert Muir commented on LUCENE-8321: - I have thought about this, I am personally against the idea

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478208#comment-16478208 ] Robert Muir commented on LUCENE-8273: - {quote} In {{TestConditionalFilter}}, converted most

[jira] [Commented] (LUCENE-8313) SimScorer simplifications

[ https://issues.apache.org/jira/browse/LUCENE-8313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477484#comment-16477484 ] Robert Muir commented on LUCENE-8313: - +1 > SimScorer simplificati

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476817#comment-16476817 ] Robert Muir commented on LUCENE-7960: - {quote} *) Even though I'm watching this issue, I'm

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472733#comment-16472733 ] Robert Muir commented on LUCENE-8273: - maybe ConditionalTokenFilter's toString() can be improved

[jira] [Commented] (LUCENE-8308) migrate KeywordRepeatFilter to conditional tokenstreams

[ https://issues.apache.org/jira/browse/LUCENE-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472261#comment-16472261 ] Robert Muir commented on LUCENE-8308: - also maybe terminally deprecate KeywordRepeatFilter, i mean I

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472235#comment-16472235 ] Robert Muir commented on LUCENE-8273: - I opened LUCENE-8308, I think we have to work our way through

[jira] [Commented] (LUCENE-8308) migrate KeywordRepeatFilter to conditional tokenstreams

[ https://issues.apache.org/jira/browse/LUCENE-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472229#comment-16472229 ] Robert Muir commented on LUCENE-8308: - The other idea in mind being that we extend LUCENE-8273

[jira] [Created] (LUCENE-8308) migrate KeywordRepeatFilter to conditional tokenstreams

Robert Muir created LUCENE-8308: --- Summary: migrate KeywordRepeatFilter to conditional tokenstreams Key: LUCENE-8308 URL: https://issues.apache.org/jira/browse/LUCENE-8308 Project: Lucene - Core

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472184#comment-16472184 ] Robert Muir commented on LUCENE-8273: - Thanks for debugging the failure: TestRandomChains is cruel

[jira] [Commented] (LUCENE-8304) Add TermFrequencyQuery

[ https://issues.apache.org/jira/browse/LUCENE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470677#comment-16470677 ] Robert Muir commented on LUCENE-8304: - It is inefficient: because it takes as input something like

[jira] [Commented] (LUCENE-8304) Add TermFrequencyQuery

[ https://issues.apache.org/jira/browse/LUCENE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470226#comment-16470226 ] Robert Muir commented on LUCENE-8304: - Right, I don't think it makes sense to backport this query

[jira] [Commented] (LUCENE-8304) Add TermFrequencyQuery

[ https://issues.apache.org/jira/browse/LUCENE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469107#comment-16469107 ] Robert Muir commented on LUCENE-8304: - Yeah, I mean i don't think it has to block the issue (we could

[jira] [Commented] (LUCENE-8304) Add TermFrequencyQuery

[ https://issues.apache.org/jira/browse/LUCENE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468945#comment-16468945 ] Robert Muir commented on LUCENE-8304: - Can we implement this where it works more efficiently based

[jira] [Commented] (LUCENE-8303) Make LiveDocsFormat only responsible for (de)serialization of live docs

[ https://issues.apache.org/jira/browse/LUCENE-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468822#comment-16468822 ] Robert Muir commented on LUCENE-8303: - nice cleanup! Its also good that it doesn't cast the incoming

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468292#comment-16468292 ] Robert Muir commented on LUCENE-7960: - {quote} I made the min/max parameters required on the factory

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468161#comment-16468161 ] Robert Muir commented on LUCENE-7960: - Also for the full ctor that allows a range, i really still

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468156#comment-16468156 ] Robert Muir commented on LUCENE-7960: - The patch has a little confusion about back compat (e.g

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467968#comment-16467968 ] Robert Muir commented on LUCENE-7960: - then it would behave like you expect an n-gram filter

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467894#comment-16467894 ] Robert Muir commented on LUCENE-7960: - Yes, I think we should deprecate. It helps ppl upgrade

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467407#comment-16467407 ] Robert Muir commented on LUCENE-8273: - For the new TermExclusionFilterFactory: {code} public static

[jira] [Commented] (LUCENE-7960) NGram filters -- preserve the original token when it is outside the min/max size range

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465221#comment-16465221 ] Robert Muir commented on LUCENE-7960: - There is no need to have only one constructor: two many

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465152#comment-16465152 ] Robert Muir commented on LUCENE-7960: - Again I want to re-emphasize that anything more complex than

[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes

[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462592#comment-16462592 ] Robert Muir commented on SOLR-11490: I am against pre-3.1 or any other invalid versions in since tags

[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes

[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462549#comment-16462549 ] Robert Muir commented on SOLR-11490: {quote} We had agreed that pre-3.1 classes will get no since tag

[jira] [Commented] (LUCENE-7964) Remove Solr fieldType XML example from Lucene AnalysisFactories JavaDoc

[ https://issues.apache.org/jira/browse/LUCENE-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461809#comment-16461809 ] Robert Muir commented on LUCENE-7964: - I think this issue shouldn't try to explode the scope

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461782#comment-16461782 ] Robert Muir commented on LUCENE-7960: - Sorry, varargs are completely uncalled for here. Arguing

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461683#comment-16461683 ] Robert Muir commented on LUCENE-7960: - my biggest concern is that these filters would then have two

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461514#comment-16461514 ] Robert Muir commented on LUCENE-7960: - The patch doesn't add up to me. The description of this issue

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458569#comment-16458569 ] Robert Muir commented on LUCENE-8273: - sounds good. yeah i know the resource stuff/keywork marking

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458507#comment-16458507 ] Robert Muir commented on LUCENE-8273: - I'm also curious about common use cases where the condition

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458501#comment-16458501 ] Robert Muir commented on LUCENE-8273: - I like the custom analyzer integration. Can we rename

[jira] [Commented] (LUCENE-8142) Should codecs expose raw impacts?

[ https://issues.apache.org/jira/browse/LUCENE-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456266#comment-16456266 ] Robert Muir commented on LUCENE-8142: - +1 > Should codecs expose raw impa

[jira] [Commented] (LUCENE-8279) Improve CheckIndex on norms

[ https://issues.apache.org/jira/browse/LUCENE-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456261#comment-16456261 ] Robert Muir commented on LUCENE-8279: - +1 > Improve CheckIndex on no

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455543#comment-16455543 ] Robert Muir commented on LUCENE-8273: - just imaging scenarios more, its probably useful if the thing

[jira] [Commented] (LUCENE-8279) Improve CheckIndex on norms

[ https://issues.apache.org/jira/browse/LUCENE-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454244#comment-16454244 ] Robert Muir commented on LUCENE-8279: - or even better maybe just move this check into the postings

[jira] [Commented] (LUCENE-8279) Improve CheckIndex on norms

[ https://issues.apache.org/jira/browse/LUCENE-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454241#comment-16454241 ] Robert Muir commented on LUCENE-8279: - I am thinking of this one: https://github.com/apache/lucene

[jira] [Commented] (LUCENE-8279) Improve CheckIndex on norms

[ https://issues.apache.org/jira/browse/LUCENE-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454222#comment-16454222 ] Robert Muir commented on LUCENE-8279: - the check is implemented as a "slow" check, bu

Re: Friendly reminder: please run precommit

. > > "ant documentation-lint" is what I'm looking for, thanks. > > Karl > > > On Thu, Apr 26, 2018 at 8:21 AM, Robert Muir <rcm...@gmail.com> wrote: >> >> I don't understand the turnaround issue, why do the commits need to be >> rushed in? >>

Re: Friendly reminder: please run precommit

I don't understand the turnaround issue, why do the commits need to be rushed in? There is patch validation recently hooked in to avoid keeping your computer busy for 25 minutes. If you are not changing third party dependencies or anything "heavy" like that you should at least run "ant

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453852#comment-16453852 ] Robert Muir commented on LUCENE-8273: - I feel like the OneTimeWrapper you have is close, it just

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453818#comment-16453818 ] Robert Muir commented on LUCENE-8273: - i mean in the worst case, you could make it "correct"

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453814#comment-16453814 ] Robert Muir commented on LUCENE-8273: - ok i get it, so basically the filter switches between two

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453806#comment-16453806 ] Robert Muir commented on LUCENE-8273: - So you mean that the problem is not related to buffering state

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452428#comment-16452428 ] Robert Muir commented on LUCENE-8273: - {quote} This latter one is a bit clunky, as this TokenFilter

[jira] [Commented] (LUCENE-8275) Unwrap directory to check for FSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452315#comment-16452315 ] Robert Muir commented on LUCENE-8275: - +1 glad it could be only one method. > Unwrap direct

[jira] [Commented] (LUCENE-8275) Unwrap directory to check for FSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452130#comment-16452130 ] Robert Muir commented on LUCENE-8275: - Or even any use of FileSwitchDirectory on windows at all would

[jira] [Commented] (LUCENE-8275) Unwrap directory to check for FSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452114#comment-16452114 ] Robert Muir commented on LUCENE-8275: - maybe FileSwitchDirectory that puts some stuff onto fast

[jira] [Commented] (LUCENE-8275) Unwrap directory to check for FSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452106#comment-16452106 ] Robert Muir commented on LUCENE-8275: - maybe as a followup we should consider pushing pending deletes

[jira] [Commented] (LUCENE-8264) Allow an option to rewrite all segments

[ https://issues.apache.org/jira/browse/LUCENE-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451382#comment-16451382 ] Robert Muir commented on LUCENE-8264: - Its not possible to warn-only: the encoding of things changed

<    1   2   3   4   5   6   7   8   9   10   >