Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Timothy Potter
I'm going to try to fix SOLR-15135 and then kick-off RC2 later today. If you're in the middle of the RC1 smoke test, it's still valuable to let it finish, otherwise, please hold off on testing RC1 Cheers, Tim On Tue, Feb 16, 2021 at 10:53 AM Timothy Potter wrote: > Ha! I pulled in Ishan's

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Timothy Potter
Ha! I pulled in Ishan's fixes for 15138 and now AutoscalingHistoryHandlerTest behaves the same as in 8.7! Beasted 10 out of 10 passed, so no @BadApple'ing needed ;-) On Tue, Feb 16, 2021 at 10:29 AM Anshum Gupta wrote: > Yes, doing a single 8.8.2 release that has all the fixes, especially as we

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Anshum Gupta
Yes, doing a single 8.8.2 release that has all the fixes, especially as we have the fix already is much better for the users. Thanks for your patience, Tim :) On Tue, Feb 16, 2021 at 9:05 AM Timothy Potter wrote: > @Ishan ~ Can you look at the question Mike raised about >

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Timothy Potter
@Ishan ~ Can you look at the question Mike raised about https://issues.apache.org/jira/browse/SOLR-15135 please? So the AutoscalingHistoryHandlerTest has a number of hard-coded wait times in it. While I can appreciate the need for waiting to see state changes occur, tests like this aren't great

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Ishan Chattopadhyaya
Sounds good, Tim. I've ported the fix to the release branch. Just ran the tests to make sure it works fine. Thanks for the extra work you'll have to do (RC2) in order to save me future work (8.8.2). Really owe you one! > Are there other fixes you're aware of that are slated for 8.8.2 @Ishan

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Timothy Potter
I'm beasting AutoscalingHistoryHandlerTest locally now, I haven't seen that one fail on my side yet. As far as respin 8.8.1 RC, it's not a problem for me and I prefer that to doing an 8.8.2 soon after 8.8.1 comes out. Are there other fixes you're aware of that are slated for 8.8.2 @Ishan

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Michael Sokolov
Hmm, I got a failure on org.apache.solr.handler.admin.AutoscalingHistoryHandlerTest.testHistory, but it did not reproduce (tried twice). Would that possibly also be addressed by those fixes? On Tue, Feb 16, 2021 at 7:38 AM Ishan Chattopadhyaya wrote: > > > The failure seems to be because of a

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Ishan Chattopadhyaya
> The failure seems to be because of a timeout during collection > creation Thanks for digging in. Seems like that is the exact class of fix that we did for SOLR-15138 and are planning for 8.8.2. Shall we backport that fix to the release branch now (for RC2 or 8.8.2)? > My h/w is really fast and

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-16 Thread Michael McCandless
Curious, the smoke tester passed for me on the first try: SUCCESS! [0:44:29.979512] Mike McCandless http://blog.mikemccandless.com On Sun, Feb 14, 2021 at 11:26 AM Timothy Potter wrote: > Please vote for release candidate 1 for Lucene/Solr 8.8.1 > > > The artifacts can be downloaded from:

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Noble Paul
@Anshum Gupta The failure seems to be because of a timeout during collection creation. My h/w is really fast and beefy and may be that's why it doesn't get reproduced. We have sped up collection creation significantly in branch_8x. Can you please re run the same tests on 8x branch please? If it's

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Anshum Gupta
Interesting. I didn't use the flag, but just changed the code to comment out the randomization from SolrCloudTestCase.java. I think Tim did the same, so I'm not sure if that's the difference or if there's a difference of environment. On Mon, Feb 15, 2021 at 9:48 PM Ishan Chattopadhyaya <

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Ishan Chattopadhyaya
I did another round of beast, this time setting that flag to true (as suggested to me by Noble). ant -Duse.perreplica=true -Dtests.dups=1 -Dtests.iters=5 -Dbeast.iters=5 -Dtestcase=SolrCloudReportersTest beast -beast: [beaster] Beast round 1 results:

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Anshum Gupta
Ishan/Noble, thanks for taking a look at this. I only just started to look at the cause, so I'm sure you have better context on why this is failing and if it makes sense to still release with this issue. FYI, I was able to get a successful smoke test run finally, but the fact that it took me

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Ishan Chattopadhyaya
I tried light beasting the test on branch_8_8: ant -Dtests.dups=1 -Dtests.iters=5 -Dbeast.iters=5 -Dtestcase=SolrCloudReportersTest beast No failures. [beaster] Beast round 1 results: /home/ishan/code/lucene-solr/solr/build/solr-core/test/1 [beaster] Beast round 2 results:

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Noble Paul
@Anshum Gupta I think we should not hold up the release of RC1 because of that failure. This is a new feature and new features take time to get hardened. However, We can investigate and fix this anyway. If required, we can do a 8.8.3 On Tue, Feb 16, 2021 at 3:10 PM Ishan Chattopadhyaya

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Ishan Chattopadhyaya
Here's my +1 for the RC1. SUCCESS! [0:42:38.936787] On Tue, Feb 16, 2021 at 9:02 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Per Replica States is a new feature introduced in 8.8.0. It will require a > critical bugfix (SOLR-15138) immediately after 8.8.1 (in a 8.8.2 release).

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Ishan Chattopadhyaya
Per Replica States is a new feature introduced in 8.8.0. It will require a critical bugfix (SOLR-15138) immediately after 8.8.1 (in a 8.8.2 release). If this issue is confirmed to be PRS related, then I think we should continue with this release and fix PRS in 8.8.2. However, if you still want us

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Ishan Chattopadhyaya
Surprising. I'll take a look. On Tue, 16 Feb, 2021, 7:29 am Anshum Gupta, wrote: > I've unsuccessfully tried getting the smoketester to pass and have had 6 > fails so far. > > At this point it seems like SolrCloudReporterTest and > AutoscalingHistoryTest tests are failing pretty consistently

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-15 Thread Anshum Gupta
I've unsuccessfully tried getting the smoketester to pass and have had 6 fails so far. At this point it seems like SolrCloudReporterTest and AutoscalingHistoryTest tests are failing pretty consistently for me. The former is a new failure, and seems to be caused by the USE_PER_REPLICA_STATE

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-14 Thread Timothy Potter
Looks like an extra space got added on the end of the python3 command, try this one: python3 -u dev-tools/scripts/smokeTestRelease.py https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.1-RC1-rev6a50a0315ac7e4979abb0b530857c7795bb3b928 On Sun, Feb 14, 2021 at 9:26 AM Timothy Potter

[VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-14 Thread Timothy Potter
Please vote for release candidate 1 for Lucene/Solr 8.8.1 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.1-RC1-rev6a50a0315ac7e4979abb0b530857c7795bb3b928 You can run the smoke tester directly with this command: python3 -u