[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919200#comment-16919200 ] David Smiley commented on SOLR-12638: - Thanks Moshe; you are right. Still, I think there is probably

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-08-13 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906206#comment-16906206 ] mosh commented on SOLR-12638: - {quote}_root_ must be set either as stored (stored="true") or doc values

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894821#comment-16894821 ] David Smiley commented on SOLR-12638: - RE schema: Yes that's right Adi. No special additional

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-28 Thread Adi Kaminski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894628#comment-16894628 ] Adi Kaminski commented on SOLR-12638: - So, in order to support integrity between parent-child

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892757#comment-16892757 ] David Smiley commented on SOLR-12638: - CC [~moshebla] I found the cause of this bug or maybe non-bug

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892157#comment-16892157 ] David Smiley commented on SOLR-12638: - Partial updates of any part of a nested doc (i.e. even to a

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-24 Thread Ronen Nussbaum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891861#comment-16891861 ] Ronen Nussbaum commented on SOLR-12638: --- Thanks for the update David. We're not using a nested

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891514#comment-16891514 ] David Smiley commented on SOLR-12638: - Ronen, your explanation wasn't clear to me since using

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-15 Thread Ronen Nussbaum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885350#comment-16885350 ] Ronen Nussbaum commented on SOLR-12638: --- While child documents are updated as expected, updating a

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-11 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883498#comment-16883498 ] David Smiley commented on SOLR-12638: - Yes all documents (parent/child) can be atomically updated. >

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-11 Thread Ronen Nussbaum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882754#comment-16882754 ] Ronen Nussbaum commented on SOLR-12638: --- Do you consider to support also atomic updates of parent

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-06-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872898#comment-16872898 ] David Smiley commented on SOLR-12638: - What gnaws at me is that this "UpdateLog.openRealtimeSearcher"

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-06-22 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870426#comment-16870426 ] mosh commented on SOLR-12638: - Quoting [~dsmiley]'s comment on ticket SOLR-13523: {quote}I'm also rather

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-05-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831169#comment-16831169 ] ASF subversion and git services commented on SOLR-12638: Commit

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-05-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831165#comment-16831165 ] ASF subversion and git services commented on SOLR-12638: Commit

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-05-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831163#comment-16831163 ] ASF subversion and git services commented on SOLR-12638: Commit

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-05-01 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830921#comment-16830921 ] mosh commented on SOLR-12638: - {quote}Oh, I didn't know this or forgot. Ugh; I wish this weren't so. Since

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-04-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829222#comment-16829222 ] David Smiley commented on SOLR-12638: - This is water under the bridge now, so to speak, but I thought

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-04-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814335#comment-16814335 ] ASF subversion and git services commented on SOLR-12638: Commit

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-04-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814132#comment-16814132 ] ASF subversion and git services commented on SOLR-12638: Commit

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-04-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814131#comment-16814131 ] ASF subversion and git services commented on SOLR-12638: Commit

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-04-09 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814045#comment-16814045 ] mosh commented on SOLR-12638: - After inspecting the test results it seems like the only failure was due to

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-04-08 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812644#comment-16812644 ] Lucene/Solr QA commented on SOLR-12638: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-01-17 Thread Yosef Brown (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745179#comment-16745179 ] Yosef Brown commented on SOLR-12638: If we require the child document's id to begin with the parent's

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661594#comment-16661594 ] David Smiley commented on SOLR-12638: - Hmm; I rather like this idea -- make it mandatory that all

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661581#comment-16661581 ] Yonik Seeley commented on SOLR-12638: - Somewhat related: perhaps it should be best practice to

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661540#comment-16661540 ] David Smiley commented on SOLR-12638: - The UpdateLog and TransactionLog probably need no changes for

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-23 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661479#comment-16661479 ] Cao Manh Dat commented on SOLR-12638: - Hi guys, I don't know much about join code, but skimming

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-22 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658983#comment-16658983 ] mosh commented on SOLR-12638: - {quote}Or, perhaps we insist the user send a _route_ parameter to /update

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658534#comment-16658534 ] David Smiley commented on SOLR-12638: - I think it's very sketchy for Solr to do either (1) or (2). I

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-21 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658100#comment-16658100 ] mosh commented on SOLR-12638: - We have been testing this feature in-house, and have come across a problem

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-10-19 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657301#comment-16657301 ] David Smiley commented on SOLR-12638: - [~caomanhdat] would you mind looking over the goals of this

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-09-16 Thread mosh (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617051#comment-16617051 ] mosh commented on SOLR-12638: - {quote}Aside from misc cleanup I can certainly point out, in your mind what is

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2018-09-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616745#comment-16616745 ] David Smiley commented on SOLR-12638: - Thanks. Please push a GitHub PR to facilitate better review.