Daniel the only thing we're changing is that I am reverting the MR, and
creating a new MR for the engine-server renaming changes. So that we can
give more tests to it.
We do have a docker image that supports running Marvin and R right now.
There is no way I can even test an R engine while we don't
All the issue have description, or am I wrong?
Before upadting, it's good to hear if anyone has any questions about what
needs to be done. I think it's relatively clear.
IMO, better use of your time would be pushing some code to help us to move
forward.
I believe this one is a strong candidate:
h
Hi, Guys
To help ourselves to avoid more misunderstanding I will update all the
issues we need to do to archive this big feature, everybody is ok with this?
Em sex, 9 de nov de 2018 às 00:25, Lucas Bonatto Miguel <
lucasbona...@gmail.com> escreveu:
> Alan, the issues that will help you implement
So, guys, we have three actions over here, and I think we should vote ASAP
to avoid uselessly efforts.
1 - Revert the PR#21
2 - Change the name from engine-executor to engine-server
3 - New PR to allow us to test an review of the new R support.
+1 for number 1
Justification: Because I believe is
Sounds good, I'll do that and I send the new PR link here soon.
Best,
Lucas
On Thu, May 23, 2019 at 12:33 PM Wei Chen wrote:
> One thing that I noticed is that:
> If we go into the code and check the files.
> They are still "executor". ex: EngineExecutorApp.scala
> If we are going to change "ex
One thing that I noticed is that:
If we go into the code and check the files.
They are still "executor". ex: EngineExecutorApp.scala
If we are going to change "executor" to "server",
we might need to modify the packages and most files.
I think it will be simpler for us to revert PR#21 first.
Only
Hi Huys, sorry to give my comments so late but...
I suppose Lucas is talking about these changes over [here|
https://github.com/apache/incubator-marvin/pull/21]
I think our primer rule should avoid changing on the existent structure
right now, once we don't have too many contributors(like chang
Hey guys, in my last MR (https://github.com/apache/incubator-marvin/pull/21)
I added support for building docker images and also started implementing
what we discussed as being the new architecture, that will have its roots
on containers and REPL.
During the work I realized that in the new context
