Re: svn commit: r1695142 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java

2015-08-11 Thread Petar Tahchiev
OK, sorry I wasn't aware that user specifying an input encoding for xml file would be considered as introducing a bug. Great for the test-case - I will revert my changes and work for a fix in the MarkdownParser. Would overriding the getType() method of the MarkdownParser be considered as a valid s

Re: [jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Lennart Jörelid
This is pretty much required whenever one uses a VCS which is not Subversion. Everything in Maven having to do with SCMs is very subversion-centric in that: 1. By default, maven appends module names (not artifactIDs) to parent projects's SCM URLs to form the SCM URL of a child. This does no

Re: Working on MJAVADOC-400

2015-08-11 Thread herve . boutemy
ok, I took time to find back Jira issues related to what I'm fearing: MJAVADOC-171 and related issues I'll need some time to carefully review your patch, since it's quite big and the plugin is already quite complex if others could have a look at it too, that would probably help Regards, Hervé

[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread JIRA
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692588#comment-14692588 ] Hervé Boutemy edited comment on MPIR-234 at 8/12/15 12:07 AM: --

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread JIRA
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692588#comment-14692588 ] Hervé Boutemy commented on MPIR-234: I don't understand the idea of "scm configuration"

Re: svn commit: r1695142 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java

2015-08-11 Thread herve . boutemy
IIUC, your concerns are about Mardown: if Markdown parser has a bug, don't hesitate to fix it but do not break content for normal XML parsers, like fml or xdoc since your change did not make unit tests fail, this proves unit tests are too weak: I just improved them in r1695408 to fail (and show

Re: Working on MJAVADOC-400

2015-08-11 Thread Raymond DeCampo
I checked the major issues in the Maven javadoc plugin JIRA but I couldn't find one referring to multiple executions. In any case I have attached a patch directly to MJAVADOC-400. I did review the patch with an eye towards catching potential multiple executions. In addition I did not encounter t

Re: [VOTE] Release Apache Maven Archetype version 2.4 - TAKE 2

2015-08-11 Thread herve . boutemy
+1 notice that the / is important for the staging site URL: this avoids a redirection to /components see http://maven.apache.org/archetype-archives/archetype-LATEST/ (vs wrong http://maven.apache.org/archetype-archives/archetype-LATEST ) but no problem for the release: great work, thanks for get

[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682341#comment-14682341 ] Robert Scholte edited comment on MPIR-234 at 8/11/15 7:31 PM: --

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682341#comment-14682341 ] Robert Scholte commented on MPIR-234: - The more I think about it, the more I like the id

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Mirko Friedenhagen (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681589#comment-14681589 ] Mirko Friedenhagen commented on MPIR-234: - In regards to [~hboutemy] comment: the si

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Stephen Connolly (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681565#comment-14681565 ] Stephen Connolly commented on MPIR-234: --- Perhaps {{scmParent}} would be better than in

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Stephen Connolly (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681564#comment-14681564 ] Stephen Connolly commented on MPIR-234: --- > Argh! hit Add too soon I wonder should we

[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Stephen Connolly (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681545#comment-14681545 ] Stephen Connolly edited comment on MPIR-234 at 8/11/15 9:49 AM: --

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread Stephen Connolly (JIRA)
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681545#comment-14681545 ] Stephen Connolly commented on MPIR-234: --- Well in general I see the SCM section being i

Re: svn commit: r1695142 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java

2015-08-11 Thread Petar Tahchiev
Hi Herve, I did this because seems like a parser can be of type XML even if it's not parsing only XML - for example the MarkdownParser (which is in doxia and extends from the XmlParser) getType() returns 2 (XML parser type). I guess there are two ways to go here - 1) first would be to allow the us

Re: svn commit: r1695142 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java

2015-08-11 Thread herve . boutemy
wow, I don't like this in XML, encoding is self provided with such feature, an XML-invalid document can be read by Maven (and Maven only, since it is XML-invalid) I'm -1 on this: we can't help people make Maven-specific pseudo XML Regards, Hervé - Mail original - De: ptahch...@apache.

Re: Working on MJAVADOC-400

2015-08-11 Thread herve . boutemy
Hi, AFAIK, there is currently a severe problem with aggregate reports, causing multiple executions: I couldn't find issues references at the moment, but I can provide Then when working on this, please check that the multiple execution problem doesn't get worse Regards, Hervé - Mail orig

[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)

2015-08-11 Thread JIRA
[ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681370#comment-14681370 ] Hervé Boutemy commented on MPIR-234: we need more generic discussion, not only git orien