Re: [VOTE] Release Apache Maven 3.5.0

2017-04-05 Thread Chas Honton
+1 Java 1.8.0_74 Mac OS X 10.12.3 Multi-module project with 562 goals (50 unique) Chas > On Apr 3, 2017, at 3:14 PM, Stephen Connolly > wrote: > > Hi, > > We solved 86 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12336084&styleName=Text > > In

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Tibor Digana
This Vote was canceled and a new TAKE 2 was sent to ML. On Tue, Apr 4, 2017 at 10:12 PM, Tibor Digana wrote: > Hi, > > We solved 65 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12317927&version=12334636 > > There are still a couple of issues left in JIRA: > https

[VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-05 Thread Tibor Digana
Hi, We solved 68 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12334636 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC Staging repo: https://

[GitHub] maven pull request #111: [MNG-6203] Minor cleanup in MavenCli.java

2017-04-05 Thread stefaneicher
Github user stefaneicher closed the pull request at: https://github.com/apache/maven/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Release Apache Maven 3.5.0

2017-04-05 Thread Elliot Metsger
+1 non-binding after testing with a bunch of different projects on MacOS 10.11.6 (15G31) Darwin Elliots-iMac.fios-router.home 15.6.0 Darwin Kernel Version 15.6.0: Thu Jun 23 18:25:34 PDT 2016; root:xnu-3248.60.10~1/RELEASE_X86_64 x86_64 On Wed, Apr 5, 2017 at 7:51 PM, Stephen Connolly < stephen.a

Re: [VOTE] Release Apache Maven 3.5.0

2017-04-05 Thread Stephen Connolly
+1 after testing with a lot of different projects On Thu 6 Apr 2017 at 00:01, Arnaud Héritier wrote: > +1 > > On Wed, Apr 5, 2017 at 8:42 AM, Olivier Lamy wrote: > > > +1 > > > > On 4 April 2017 at 08:14, Stephen Connolly > com> > > wrote: > > > > > Hi, > > > > > > We solved 86 issues: > > > h

Re: [VOTE] Release Apache Maven 3.5.0

2017-04-05 Thread Arnaud Héritier
+1 On Wed, Apr 5, 2017 at 8:42 AM, Olivier Lamy wrote: > +1 > > On 4 April 2017 at 08:14, Stephen Connolly com> > wrote: > > > Hi, > > > > We solved 86 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > projectId=12316922&version=12336084&styleName=Text > > > > In there are

[GitHub] maven issue #111: [MNG-6203] Minor cleanup in MavenCli.java

2017-04-05 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/111 This pull request has been integrated into maven core. Thanks for your support. Please close this pull request. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] maven issue #111: [MNG-6203] Minor cleanup in MavenCli.java

2017-04-05 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/111 If you add the JIRA ticket this PR is automatically added to the JIRA ticket...Thanks for this.. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Petr Široký
Hello Tibor, I've just tried with a local build from the SUREFIRE-1354 branch and I can confirm the issue is gone. I've executed 50 builds on the same config as before. Thanks, Petr On Wed, Apr 5, 2017 at 8:10 PM Tibor Digana wrote: > @Michael > Hi Michael, > A new branch was created > SUREFIR

[GitHub] maven pull request #111: [MNG-6203] Minor cleanup in MavenCli.java

2017-04-05 Thread stefaneicher
GitHub user stefaneicher opened a pull request: https://github.com/apache/maven/pull/111 [MNG-6203] Minor cleanup in MavenCli.java There is some unnecessary code in the MavenCli.java from line #1465 to #1474. The functionality has been moved to line #1215. Signed-off-by

[GitHub] maven-surefire issue #145: Close reportSets tag

2017-04-05 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/145 @flungo Thank You for the fix and let them coming more. Your fix has been merged to master. Please close this pull request. https://issues.apache.org/jira/browse/SUREFIRE-1355

Re: Surefire and Java 9

2017-04-05 Thread Robert Scholte
FYI, it's SUREFIRE-1262[1] where most of the details are for implementing this. Robert [1] htps://issues.apache.org/jira/browse/SUREFIRE-1262 On Wed, 05 Apr 2017 19:08:27 +0200, Jörg Schaible wrote: Hi Tibor, Tibor Digana wrote: Hi Joerg, We will continue on this issue after this re

[CANCELLED] [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Tibor Digana
Hi, I am cancelling the first vote. I will start new Vote in a while. Cheers, Tibor

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
@Michael Hi Michael, A new branch was created SUREFIRE-1354. @Petr Please build the project mvn install -DskipTests and check it out in your project with version 2.20-SNAPSHOT. git clone -b SUREFIRE-1354 https://github.com/apache/maven-surefire On Wed, Apr 5, 2017 at 7:10 PM, Michael Osipov wr

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Michael Osipov
Am 2017-04-05 um 19:02 schrieb Tibor Digana: Yes, I will cancel it, and I will add few more fixes too. Good, tell me when you are ready. I will retest trunk before you prepare the release. On Wed, Apr 5, 2017 at 7:01 PM, Michael Osipov wrote: Am 2017-04-05 um 17:20 schrieb Tibor Digana:

Re: Surefire and Java 9

2017-04-05 Thread Jörg Schaible
Hi Tibor, Tibor Digana wrote: > Hi Joerg, > > We will continue on this issue after this release. > Would you help us with your Java 9 knowhow? actually, I am completely lost with Java 9 for now. I simply assumed that someone managed to run the unit tests by now that opens access to some class

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
Yes, I will cancel it, and I will add few more fixes too. On Wed, Apr 5, 2017 at 7:01 PM, Michael Osipov wrote: > Am 2017-04-05 um 17:20 schrieb Tibor Digana: > >> I found the issue. >> In ForkedBooter we call >> >> encodeAndWriteToOutput( ( (char) BOOTERCODE_BYE ) + ",0,BYE!\n", >> originalOut

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Michael Osipov
Am 2017-04-05 um 17:20 schrieb Tibor Digana: I found the issue. In ForkedBooter we call encodeAndWriteToOutput( ( (char) BOOTERCODE_BYE ) + ",0,BYE!\n", originalOut ); We expect the Maven process to respond. This happens but the listener which is expected to listen to BYE_ACK from Maven process

[GitHub] maven-surefire pull request #145: Close reportSets tag

2017-04-05 Thread flungo
GitHub user flungo opened a pull request: https://github.com/apache/maven-surefire/pull/145 Close reportSets tag Close the `` tag in the usage documentation for "Reporting integration test results". You can merge this pull request into a Git repository by running: $ git pull h

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
I found the issue. In ForkedBooter we call encodeAndWriteToOutput( ( (char) BOOTERCODE_BYE ) + ",0,BYE!\n", originalOut ); We expect the Maven process to respond. This happens but the listener which is expected to listen to BYE_ACK from Maven process is registered after this sending BYE and not b

Re: Surefire and Java 9

2017-04-05 Thread Tibor Digana
Hi Joerg, We will continue on this issue after this release. Would you help us with your Java 9 knowhow? We have a ticket with Java9 issue in Jira. On Wed, Apr 5, 2017 at 11:32 AM, Jörg Schaible wrote: > Hi, > > does anyone already have a setup to execute surefire with Java 9 where the > tested

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
>From the Thread dump it is obvious that Maven process does not send stream to the forked jvm. Forked JVM is waiting for the data to be received. Therefore we need to find a way to grab the stream. Another alternative is to dump it in the code, but this is dejavu because we were doing this in FreeB

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Petr Široký
On Wed, Apr 5, 2017 at 1:13 PM Tibor Digana wrote: > What I see in the thread dump is > that ForkedBooter sent event BOOTERCODE_BYE, waiting for BYE_ACK from > master process in CommandReader. > > Are you able to dump native stream stdout/in of forked JVM? > Not sure I understand what this means.

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
What I see in the thread dump is that ForkedBooter sent event BOOTERCODE_BYE, waiting for BYE_ACK from master process in CommandReader. Are you able to dump native stream stdout/in of forked JVM? On Wed, Apr 5, 2017 at 12:31 PM, Petr Široký wrote: > I've just tried on Windwos 2012R2 + Maven 3.2

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Petr Široký
I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven 3.2.5. The 30s wait is somehow intermittent. I can still reproduce on those platforms, but it takes 10 or 15 tries. On Fedora 25 it happens almost always (but I have seen it pass also there). On Wed, Apr 5, 2017 at 11:50 AM Tibor

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
On my side okay (Maven 3.5.0 Win7). I will check it out on Fedora and Ubuntu. mvn test [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building surefire-2_20-slowdown-reproducer 1.0-SNAPSHOT [INFO] --

Surefire and Java 9

2017-04-05 Thread Jörg Schaible
Hi, does anyone already have a setup to execute surefire with Java 9 where the tested code requires the opening of some modules? I already tried with different configuration stuff, but failed so far. Cheers, Jörg - To unsubsc

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Tibor Digana
@Peter Thx for the test. I have created a new topic for it in ML: surefire-2_20-slowdown-reproducer On Wed, Apr 5, 2017 at 10:33 AM, Petr Široký wrote: > Hello, > > I've tried with several projects and functionally, everything seems OK. > > However, I noticed certain slowdown in case multiple f

surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
Discussion to Release Vote of Surefire 2.20. Project to reproduce an issue https://github.com/psiroky/surefire-2_20-slowdown-reproducer Forked JVM is waiting 30 seconds to die. I guess the JVM does not exit due to non-daemon threads. Question is why we can see RMI Threads however no test is using

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Petr Široký
Hello, I've tried with several projects and functionally, everything seems OK. However, I noticed certain slowdown in case multiple forks are beings used to run the tests. After some investigation, it seems one of the forked VMs gets "stuck" for about 30s before it gets shutdown. So every surefir

[GitHub] maven-indexer pull request #12: resolve performance loss due to lucene 4.8.1...

2017-04-05 Thread tstupka
Github user tstupka closed the pull request at: https://github.com/apache/maven-indexer/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature