CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread John Casey
BTW, I found this comment on line 981 of DefaultMavenProjectBuilder: // [MNG-2339] ensure the system properties are still interpolated for backwards compat, but the model values must win I've checked that issue, and it looks like it was closed for this release...so, not present in

Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread John Casey
Sorry for the spam. Digging deeper through the related links on MNG-2339, it's apparent that the comment in the DefaultMavenProjectBuilder is a touch misleading. The key issues relevant to where sysprops get used during interpolation are: MNG-2745 MNG-2651 It seems that environments

RE: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Brian E. Fox
: [pre vote take 3] 2.0.9-RC3) BTW, I found this comment on line 981 of DefaultMavenProjectBuilder: // [MNG-2339] ensure the system properties are still interpolated for backwards compat, but the model values must win I've checked that issue, and it looks like it was closed

RE: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Brian E. Fox
, 2008 1:16 PM To: Maven Developers List Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3) Sorry for the spam. Digging deeper through the related links on MNG-2339, it's apparent that the comment in the DefaultMavenProjectBuilder is a touch misleading. The key

Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread John Casey
, 2008 1:16 PM To: Maven Developers List Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3) Sorry for the spam. Digging deeper through the related links on MNG-2339, it's apparent that the comment in the DefaultMavenProjectBuilder is a touch misleading. The key

Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Brett Porter
of the properties with big warnings in 2.0.9. -Original Message- From: John Casey [mailto:[EMAIL PROTECTED] Sent: Thursday, March 27, 2008 1:16 PM To: Maven Developers List Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3) Sorry for the spam. Digging

RE: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Brian E. Fox
I can't see why overriding model values makes any sense from the command line - that's not what Olivier wanted but rather a straight substitution. You shouldn't be able to override model values for sure. I was saying that if something is defined on the CLI for everything else, it should take

Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Paul Benedict
Brian, what do you consider the correct fix? That CLI takes precedence over POM properties? I was trying to glean through this chain to find out your proposal. Paul On Thu, Mar 27, 2008 at 2:08 PM, Brian E. Fox [EMAIL PROTECTED] wrote: I can't see why overriding model values makes any sense

Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Brett Porter
On 28/03/2008, at 6:37 AM, Paul Benedict wrote: Brian, what do you consider the correct fix? That CLI takes precedence over POM properties? I was trying to glean through this chain to find out your proposal. The most correct fix is: a) -Dversion should still replace ${version} b)

RE: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Brian E. Fox
: Thursday, March 27, 2008 3:38 PM To: Maven Developers List Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3) Brian, what do you consider the correct fix? That CLI takes precedence over POM properties? I was trying to glean through this chain to find out your

Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)

2008-03-27 Thread Jason van Zyl
27, 2008 1:16 PM To: Maven Developers List Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3) Sorry for the spam. Digging deeper through the related links on MNG-2339, it's apparent that the comment in the DefaultMavenProjectBuilder is a touch misleading