Re: PMD/Checkstyle and threadSafe....

2010-06-08 Thread Daniel Kulp
On Tuesday 08 June 2010 5:51:09 am Olivier Lamy wrote: > done too (and snapshot deployed). > Can you test this with cxf build Looks good. :-) Dan > > 2010/6/8 Olivier Lamy : > > we probably need to add @threadSafe in PMD too. > > I have created MPMD-122 (and will try to do it today) > > > >

Re: PMD/Checkstyle and threadSafe....

2010-06-08 Thread Olivier Lamy
done too (and snapshot deployed). Can you test this with cxf build 2010/6/8 Olivier Lamy : > we probably need to add @threadSafe in PMD too. > I have created MPMD-122 (and will try to do it today) > > 2010/6/8 Daniel Kulp : >> On Monday 07 June 2010 7:03:49 pm Olivier Lamy wrote: >>> Hi, >>> So I

Re: PMD/Checkstyle and threadSafe....

2010-06-08 Thread Olivier Lamy
we probably need to add @threadSafe in PMD too. I have created MPMD-122 (and will try to do it today) 2010/6/8 Daniel Kulp : > On Monday 07 June 2010 7:03:49 pm Olivier Lamy wrote: >> Hi, >> So I have fixed all dependencies issues and deploy a snapshot. >> Can you test on your large cxf build ? >>

Re: PMD/Checkstyle and threadSafe....

2010-06-07 Thread Daniel Kulp
On Monday 07 June 2010 7:03:49 pm Olivier Lamy wrote: > Hi, > So I have fixed all dependencies issues and deploy a snapshot. > Can you test on your large cxf build ? > If all is fine you can close MCHECKSTYLE-139 I just ran "mvn validate" about a dozen times (both checkstyle and pmd bound into va

Re: PMD/Checkstyle and threadSafe....

2010-06-07 Thread Olivier Lamy
Hi, So I have fixed all dependencies issues and deploy a snapshot. Can you test on your large cxf build ? If all is fine you can close MCHECKSTYLE-139 2010/6/3 Daniel Kulp : > On Thursday 03 June 2010 12:54:07 pm John Casey wrote: >> Ah. The package name has changed, but the APIs are the same. So

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Kristian Rosenvold
Before having looked at the source code in question, I could only recommend plexus-utils 2.0.5 (on a general basis), because all of the executeCommandLine methods are deadlock prone prior to that version. I find it quite hard to evaluate if any of the transitive dependencies included in the plugi

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Daniel Kulp
On Thursday 03 June 2010 12:54:07 pm John Casey wrote: > Ah. The package name has changed, but the APIs are the same. So the > imports for the interpolation stuff just need to be adjusted, once the > plexus-interpolation dep is added. Right. But nothing in checkstyle plugin imports anything from

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread John Casey
Ah. The package name has changed, but the APIs are the same. So the imports for the interpolation stuff just need to be adjusted, once the plexus-interpolation dep is added. On 6/3/10 12:50 PM, Daniel Kulp wrote: On Thursday 03 June 2010 12:38:43 pm John Casey wrote: It needs a dependency add

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Daniel Kulp
On Thursday 03 June 2010 12:38:43 pm John Casey wrote: > It needs a dependency added on plexus-interpolation, since the > interpolation stuff was taken out of plexus-utils and migrated there. Didn't help. The stuff in plexus-interpolation has the ValueSource stuff in a different package. Thus

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Olivier Lamy
Hi, Try with adding the following dependency : org.codehaus.plexus:plexus-interpolation:1.9. 2010/6/3 Daniel Kulp : > > I've been working on getting the CXF builds to at least build (not run the > tests yet) with the Maven 3 // mode.    With the updates to the checkstyle > plugin, I've now done ab

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread John Casey
It needs a dependency added on plexus-interpolation, since the interpolation stuff was taken out of plexus-utils and migrated there. On 6/3/10 12:02 PM, Daniel Kulp wrote: I've been working on getting the CXF builds to at least build (not run the tests yet) with the Maven 3 // mode.With th

PMD/Checkstyle and threadSafe....

2010-06-03 Thread Daniel Kulp
I've been working on getting the CXF builds to at least build (not run the tests yet) with the Maven 3 // mode.With the updates to the checkstyle plugin, I've now done about a dozen or so builds with various -T settings without any failures.I'm not quite ready to declare an @threadSafe