Re: Remove M2_HOME setup from download page instructions

2015-01-28 Thread Baptiste Mathus
@Robert yup my bad for being somehow unclear. The -1 was answering to the fact that M2_HOME may be useful in some cases. So I'm indeed +1 for removing it from the docs. Cheers Le 27 janv. 2015 19:14, Robert Scholte rfscho...@apache.org a écrit : @Baptiste, so I guess your vote is actually +1

Re: Remove M2_HOME setup from download page instructions

2015-01-28 Thread Dan Tran
Hi Igor, That confirms the need to deprecate M2_HOME, I will remove it from installation doc first. Will need to talk to Sonatype to remove it from its book Thanks -Dan On Wed, Jan 28, 2015 at 11:58 AM, Igor Fedorenko i...@ifedorenko.com wrote: I see. Yes, this would be a problem. And I

Re: Remove M2_HOME setup from download page instructions

2015-01-28 Thread Mirko Friedenhagen
I use a similar approach to Dan's. I just have ~/lib/apache-mavem-VERSION and symlink the mvn shell script to ~/bin/mvnVERSION_WITHOUT_DOTS. Works flawlessly. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen)

Re: Remove M2_HOME setup from download page instructions

2015-01-28 Thread Dan Tran
So I guess the consensus is to remove M2_HOME from installation instructions and doc the specific usage of M2_HOME at FAQ? Thanks -D On Wed, Jan 28, 2015 at 9:02 AM, Baptiste Mathus m...@batmat.net wrote: @Robert yup my bad for being somehow unclear. The -1 was answering to the fact that

Re: Remove M2_HOME setup from download page instructions

2015-01-28 Thread Jason van Zyl
+1 I think you need to deprecate something like that and not just yank it, but removing the doco is a good first step. I have M2_HOME set even through I don't technically need it but that's how I switch versions of Maven. I have M2_HOME set, it's a symlink, and i just flip the symlink to

Re: Remove M2_HOME setup from download page instructions

2015-01-28 Thread Igor Fedorenko
I see. Yes, this would be a problem. And I think there is already similar incompatibility between maven 2.x and 3.x scripts (launcher class name changed in 3.x). Personally, I never use M2_HOME to switch between maven versions, so I wouldn't mind if it was removed completely. If we want M2_HOME

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Robert Scholte
@Baptiste, so I guess your vote is actually +1 to remove it from documentation, right? M2_HOME is automatically set by the shell or batch script. The M2_HOME variable is here used to easily switch between different Maven distributions. But with this name this can indeed cause

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
Hi Benson, What is your verdict? Thanks -D On Tue, Jan 27, 2015 at 3:15 AM, Benson Margulies bimargul...@gmail.com wrote: I know of two cases where it comes up. 1: some of our own ITs. Those aren't a reason for comprehensive doc. 2: an application I wrote for Aether :-) On Tue, Jan

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
Hi Benson By many tests are you refer to the incident at release plugin 2.5.1, or maven-core IT Thanks -D On Tue, Jan 27, 2015 at 10:28 AM, Benson Margulies bimargul...@gmail.com wrote: On Tue, Jan 27, 2015 at 1:16 PM, Dan Tran dant...@gmail.com wrote: Hi Benson, What is your

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Benson Margulies
On Tue, Jan 27, 2015 at 2:10 PM, Dan Tran dant...@gmail.com wrote: Hi Benson By many tests are you refer to the incident at release plugin 2.5.1, or maven-core IT I'm guessing that the M-R-P integration tests are not the only plugin integration tests that care. I'm pretty sure I've run into

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Benson Margulies
On Tue, Jan 27, 2015 at 1:16 PM, Dan Tran dant...@gmail.com wrote: Hi Benson, What is your verdict? I vote for removing it from the publically facing doc. is there also a thought of removing it from the code? I guess if someone makes sure that all our many tests pass without it, fine with me.

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
IMO, M2_HOME is no longer a required env starting 2.2.1, and there for it is used mainly for the exact use case that Manfred mentioned. I myself use a set a wrapper scripts ( mvn221, mvn311, etc) since it is much easier to remember. I also got bitten a number of times where user had M2_HOME set,

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Baptiste Mathus
-1 it's a problematic variable, removing it is a good idea IMO, and changing mvn version is indeed just a matter of updating your path. I've been hit many a time by an updated PATH pointing to a different mvn version than the one referenced by M2_HOME, which ends with NoClassDefFoundError or

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Igor Fedorenko
You sure you linked the right commit? The commit you linked is from my experimental branch and it does not change how mvn* scripts use M2_HOME environment variable. -- Regards, Igor On 2015-01-27 16:26, Dan Tran wrote: Just see this change [1] at Maven core where the 'mvn' script get altered.

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
Just see this change [1] at Maven core where the 'mvn' script get altered. Not sure about the impact of this change when using M2_HOME to support multiple is distributions. -Dan [1] https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commitdiff;h=0a76e91b On Tue, Jan 27, 2015 at 11:38

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Igor Fedorenko
On 2015-01-27 17:35, Dan Tran wrote: My bad, it is not obvious it is from an experimental branch. However, even if this gets committed master, the configuration changes in that script may impact other distribution using M2_HOME. Can you explain how changes on that branch can impact other

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Chris Graham
I switch between versions all the time; this is useful. Sent from my iPhone On 27/01/2015, at 4:47 PM, Manfred Moser manf...@mosabuam.com wrote: I would still suggest to make sure its documented somewhere. I find it incredibly useful to just change M2_HOME to simply switch Maven versions.

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
My bad, it is not obvious it is from an experimental branch. However, even if this gets committed master, the configuration changes in that script may impact other distribution using M2_HOME. Sorry, I am a little side track here. -D On Tue, Jan 27, 2015 at 2:07 PM, Igor Fedorenko

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
If your changes are specific to 3.2.6, however If user has M2_HOME point to an older version MAVEN, would that be a problem? Thanks -D On Tue, Jan 27, 2015 at 3:01 PM, Igor Fedorenko i...@ifedorenko.com wrote: On 2015-01-27 17:35, Dan Tran wrote: My bad, it is not obvious it is from an

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Dan Tran
Strange I don't have a problem with maven-release build running with -Prun-its -D On Tue, Jan 27, 2015 at 11:20 AM, Benson Margulies bimargul...@gmail.com wrote: On Tue, Jan 27, 2015 at 2:10 PM, Dan Tran dant...@gmail.com wrote: Hi Benson By many tests are you refer to the incident at

Re: Remove M2_HOME setup from download page instructions

2015-01-27 Thread Benson Margulies
I know of two cases where it comes up. 1: some of our own ITs. Those aren't a reason for comprehensive doc. 2: an application I wrote for Aether :-) On Tue, Jan 27, 2015 at 4:04 AM, Baptiste Mathus m...@batmat.net wrote: -1 it's a problematic variable, removing it is a good idea IMO, and

Re: Remove M2_HOME setup from download page instructions

2015-01-26 Thread Manfred Moser
I would still suggest to make sure its documented somewhere. I find it incredibly useful to just change M2_HOME to simply switch Maven versions. manfred Mirko Friedenhagen wrote on 26.01.2015 21:40: Dan, go ahead, I have not set this variable for years. Regards Mirko -- Sent from my

Re: Remove M2_HOME setup from download page instructions

2015-01-26 Thread Kristian Rosenvold
I seem to recall Benson ran into a case with either release or site where it was still required no too long ago ? Kristian 2015-01-27 7:19 GMT+01:00 Anders Hammar and...@hammar.net: I would still suggest to make sure its documented somewhere. I find it incredibly useful to just change M2_HOME

Remove M2_HOME setup from download page instructions

2015-01-26 Thread Dan Tran
Hi, Any objection to remove the need to setup M2_HOME env variable at maven download page? Thanks -Dan https://jira.codehaus.org/browse/MNGSITE-223

Re: Remove M2_HOME setup from download page instructions

2015-01-26 Thread Mirko Friedenhagen
Dan, go ahead, I have not set this variable for years. Regards Mirko -- Sent from my mobile On Jan 27, 2015 5:52 AM, Dan Tran dant...@gmail.com wrote: Hi, Any objection to remove the need to setup M2_HOME env variable at maven download page? Thanks -Dan

Re: Remove M2_HOME setup from download page instructions

2015-01-26 Thread Anders Hammar
I would still suggest to make sure its documented somewhere. I find it incredibly useful to just change M2_HOME to simply switch Maven versions. +1, very useful but I guess it doesn't require the name M2_HOME. /Anders manfred Mirko Friedenhagen wrote on 26.01.2015 21:40: Dan, go