Re: Review Request 19901: Added Termination protobuf message.

2014-04-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19901/ --- (Updated April 4, 2014, 5:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19901: Added Termination protobuf message.

2014-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19901/#review39515 --- Ship it! Ship It! - Ian Downes On April 2, 2014, 5:20 a.m., Till

Re: Review Request 19901: Added Termination protobuf message.

2014-04-03 Thread Ian Downes
> On April 2, 2014, 3:55 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, lines 482-483 > > > > > > I think we can simplify this sentence; the container can be killed for > > various reasons - register timeo

Re: Review Request 19901: Added Termination protobuf message.

2014-04-03 Thread Till Toenshoff
> On April 2, 2014, 3:55 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, lines 482-483 > > > > > > I think we can simplify this sentence; the container can be killed for > > various reasons - register timeo

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2041

2014-04-03 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Removed unreliable setsid test from subprocess_tests. -- [...truncated 29202 lines...] 2014-04-04 03:46:24,234:2412(0x2b16490b9

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2040

2014-04-03 Thread Apache Jenkins Server
See

Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/ --- Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and C

Review Request 20025: Rename CgroupsLauncher to LinuxLauncher

2014-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/ --- Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and C

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39501 --- Patch looks great! Reviews applied: [19981, 19982, 19702] All test

Re: Review Request 20023: Removed unreliable setsid test from subprocess_tests

2014-04-03 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20023/#review39500 --- Ship it! Ship It! - Benjamin Hindman On April 4, 2014, 1:31 a.m.

Review Request 20023: Removed unreliable setsid test from subprocess_tests

2014-04-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20023/ --- Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone. Rep

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/ --- (Updated April 4, 2014, 1:31 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19795: Changed Executor::info to executor info future.

2014-04-03 Thread Niklas Nielsen
> On April 2, 2014, 5:47 p.m., Vinod Kone wrote: > > Thanks for the thorough review Vinod! The new patch captures some of the trivial changes but some of the bigger issues are still outstanding. I have raised questions inline. Also, I think it makes sense to break out the Executor::resources

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2039

2014-04-03 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Updated os::read(fd, size) to not seek. [benjamin.hindman] Enable automake 1.14. [vinod] Fixed ProcTest.MultipleThreads test. [benjamin.hi

Re: Review Request 20004: Link to Javadoc, reorg framework developer links

2014-04-03 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20004/#review39499 --- Ship it! Ship It! - Ross Allen On April 3, 2014, 4:30 p.m., Tobi

Re: Review Request 18403: Added support for launching tasks by TaskInfo.

2014-04-03 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18403/ --- (Updated April 3, 2014, 5:37 p.m.) Review request for mesos, Ian Downes and Vin

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2040

2014-04-03 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Updated os::read(fd, size) to not seek. [benjamin.hindman] Enable automake 1.14. [vinod] Fixed ProcTest.MultipleThreads test. [benjamin.hindman] Adds a "setup" functi

Re: Review Request 19795: Changed Executor::info to executor info future.

2014-04-03 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19795/ --- (Updated April 3, 2014, 5:22 p.m.) Review request for mesos, Ian Downes and Vin

[jira] [Commented] (MESOS-1102) Further extensions to process::subprocess

2014-04-03 Thread Till Toenshoff (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959452#comment-13959452 ] Till Toenshoff commented on MESOS-1102: --- commit c313c71ac5aa690abe1ec17aaf5050fb342e

Re: Review Request 18601: Added command line argument option in mesos-executor.

2014-04-03 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18601/#review39497 --- Dropping this issue per our off-line discussion. - Niklas Nielsen

Re: Review Request 19951: Change cgroups::assign to assign all threads.

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19951/#review39495 --- Patch looks great! Reviews applied: [19951] All tests passed. - M

[jira] [Commented] (MESOS-1191) ProcTest unit tests flaky

2014-04-03 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959423#comment-13959423 ] Ian Downes commented on MESOS-1191: --- [~bhuvan] are you not seeing flaky OsTests? Is ther

[jira] [Updated] (MESOS-1191) ProcTest unit tests flaky

2014-04-03 Thread Bhuvan Arumugam (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhuvan Arumugam updated MESOS-1191: --- Summary: ProcTest unit tests flaky (was: OsTest and ProcTest unit tests flaky) > ProcTest u

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review39493 --- Ship it! Awesome Till, I'll get this committed now. - Benjamin Hin

[jira] [Resolved] (MESOS-1152) ProcTest.MultipleThreads is flaky

2014-04-03 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone resolved MESOS-1152. --- Resolution: Fixed commit 7601fd1e18602e977daee1d693e8581677f7a6a3 Author: Ian Downes Date: Thu Apr

Re: Review Request 19952: Reduce stack size for threads in proc tests.

2014-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19952/#review39488 --- Ship it! Ship It! - Vinod Kone On April 3, 2014, 10:59 p.m., Ian

Re: Review Request 19951: Change cgroups::assign to assign all threads.

2014-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19951/ --- (Updated April 3, 2014, 10:59 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19952: Reduce stack size for threads in proc tests.

2014-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19952/ --- (Updated April 3, 2014, 10:59 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review39486 --- Ship it! Ship It! - Dominic Hamon On April 3, 2014, 3:46 p.m., T

Re: Review Request 19761: Added a benchmark test for Registrar which is enabled by 'make bench'.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/#review39484 --- src/tests/registrar_tests.cpp

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
> On April 3, 2014, 7:45 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 141-144 > > > > > > Can we comment that we're doing this before we fork because it might > > not be async-signal

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/ --- (Updated April 3, 2014, 10:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
> On April 3, 2014, 7:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 79 > > > > > > It just feels a little restrictive, in that I might want to pass > > arguments. > > Benja

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/ --- (Updated April 3, 2014, 10:44 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19762: Improved Registrar performance by using a hashset on SlaveIDs.

2014-04-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19762/ --- (Updated April 3, 2014, 3:30 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 19761: Added a benchmark test for Registrar which is enabled by 'make bench'.

2014-04-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/ --- (Updated April 3, 2014, 3:28 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 19952: Reduce stack size for threads in proc tests.

2014-04-03 Thread Benjamin Hindman
> On April 3, 2014, 9:41 p.m., Vinod Kone wrote: > > LGTM modulo using the new os::read() (once that gets submitted). Just got submitted! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 19952: Reduce stack size for threads in proc tests.

2014-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19952/#review39478 --- Ship it! LGTM modulo using the new os::read() (once that gets submi

Re: Review Request 20017: Added 'make bench' make target to run benchmark tests under 'src'.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/#review39477 --- Ship it! Looks good. Have you seen https://github.com/google/bench

[jira] [Created] (MESOS-1192) Try::get() but state == ERROR: The cpuacct subsystem is co-mounted at /sys/fs/cgroup/cpuacct with other subsytems

2014-04-03 Thread Vinson Lee (JIRA)
Vinson Lee created MESOS-1192: - Summary: Try::get() but state == ERROR: The cpuacct subsystem is co-mounted at /sys/fs/cgroup/cpuacct with other subsytems Key: MESOS-1192 URL: https://issues.apache.org/jira/browse/MES

[jira] [Commented] (MESOS-1191) OsTest and ProcTest unit tests flaky

2014-04-03 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959251#comment-13959251 ] Ian Downes commented on MESOS-1191: --- Flaky ProcTest.MultipleThreads is also being tracke

Review Request 20017: Added 'make bench' make target to run benchmark tests under 'src'.

2014-04-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/ --- Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone. Bugs

[jira] [Updated] (MESOS-1191) OsTest and ProcTest unit tests flaky

2014-04-03 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1191: -- Component/s: (was: build) test > OsTest and ProcTest unit tests flaky > --

[jira] [Updated] (MESOS-1191) OsTest and ProcTest unit tests flaky

2014-04-03 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1191: -- Labels: (was: test-fail) > OsTest and ProcTest unit tests flaky > ---

[jira] [Commented] (MESOS-995) Extend Subprocess to support environment variables, changing user and working directory

2014-04-03 Thread Bhuvan Arumugam (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959187#comment-13959187 ] Bhuvan Arumugam commented on MESOS-995: --- Filed MESOS-1191 to track fix for flaky test

[jira] [Commented] (MESOS-1191) OsTest and ProcTest unit tests flaky

2014-04-03 Thread Bhuvan Arumugam (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959186#comment-13959186 ] Bhuvan Arumugam commented on MESOS-1191: It also happen with review-bot https://re

[jira] [Created] (MESOS-1191) OsTest and ProcTest unit tests flaky

2014-04-03 Thread Bhuvan Arumugam (JIRA)
Bhuvan Arumugam created MESOS-1191: -- Summary: OsTest and ProcTest unit tests flaky Key: MESOS-1191 URL: https://issues.apache.org/jira/browse/MESOS-1191 Project: Mesos Issue Type: Bug

[jira] [Commented] (MESOS-995) Extend Subprocess to support environment variables, changing user and working directory

2014-04-03 Thread Till Toenshoff (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959157#comment-13959157 ] Till Toenshoff commented on MESOS-995: -- Ow and I also feel confident that this is enti

[jira] [Commented] (MESOS-995) Extend Subprocess to support environment variables, changing user and working directory

2014-04-03 Thread Till Toenshoff (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959154#comment-13959154 ] Till Toenshoff commented on MESOS-995: -- The review-bot just saw this problem on one of

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Benjamin Hindman
> On April 3, 2014, 7:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 141 > > > > > > Change Envp to take an Option and skip the loop over the passed in > > map if it's None()? I think

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review39467 --- Bad patch! Reviews applied: [19259] Failed command: make check Er

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review39464 --- I think we can simplify by just having the forked child use '_exit'

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review37440 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Benjamin Hindman
> On April 1, 2014, 8:50 p.m., Benjamin Hindman wrote: > > src/Makefile.am, lines 161-163 > > > > > > I suggested pulling out the offending translation units so that people > > could have some context to understand wh

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19854/#review39463 --- Ship it! Ship It! - Benjamin Hindman On April 3, 2014, 2:31 p.m.

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/ --- (Updated April 3, 2014, 7:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
> On April 3, 2014, 4:18 a.m., Benjamin Hindman wrote: > > This looks pretty good Till. Just a few cleanups and then let's get it > > submitted. Thanks Ben! > On April 3, 2014, 4:18 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp, lines 342-344 > >

Re: Review Request 19259: Added ability to process::subprocess to run function within child context

2014-04-03 Thread Till Toenshoff
> On March 17, 2014, 7:28 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 75 > > > > > > It might be better to add a second method. The way this is written, > > anyone wanting to

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Timothy St. Clair
> On April 1, 2014, 8:50 p.m., Benjamin Hindman wrote: > > src/Makefile.am, lines 161-163 > > > > > > I suggested pulling out the offending translation units so that people > > could have some context to understand wh

Re: Review Request 18155: High Availability doc update

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18155/#review39455 --- Patch looks great! Reviews applied: [18155] All tests passed. - M

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19991/#review39453 --- Ship it! Ship It! - Vinod Kone On April 3, 2014, 6:35 a.m., Benj

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Vinod Kone
> On April 3, 2014, 5:57 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 52-58 > > > > > > I'm confused about these semantics. What is the rationale? AFAICT, > > read() d

[jira] [Created] (MESOS-1190) Add make bench target for benchmark tests.

2014-04-03 Thread Yan Xu (JIRA)
Yan Xu created MESOS-1190: - Summary: Add make bench target for benchmark tests. Key: MESOS-1190 URL: https://issues.apache.org/jira/browse/MESOS-1190 Project: Mesos Issue Type: Sub-task R

[jira] [Updated] (MESOS-95) Add performance tests

2014-04-03 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu updated MESOS-95: Assignee: (was: Yan Xu) > Add performance tests > - > > Key: MESOS-95 >

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Ian Downes
> On April 3, 2014, 5:57 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 52-58 > > > > > > I'm confused about these semantics. What is the rationale? AFAICT, > > read() d

Re: Review Request 20004: Link to Javadoc, reorg framework developer links

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20004/#review39445 --- Patch looks great! Reviews applied: [20004] All tests passed. - M

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Benjamin Hindman
> On April 3, 2014, 5:57 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 52-58 > > > > > > I'm confused about these semantics. What is the rationale? AFAICT, > > read() d

Re: Review Request 19988: Enabled readability/todo rule for cpplint.

2014-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19988/#review39437 --- 3rdparty/libprocess/src/decoder.hpp

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Benjamin Hindman
> On April 1, 2014, 8:50 p.m., Benjamin Hindman wrote: > > src/Makefile.am, lines 161-163 > > > > > > I suggested pulling out the offending translation units so that people > > could have some context to understand wh

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19991/#review39428 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp

Re: Review Request 19965: Enabled whitespace/semicolon rule for cpplint.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19965/#review39430 --- src/tests/cgroups_tests.cpp

Re: Review Request 19966: Enabled whitespace/blank_line rule for cpplint.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19966/#review39429 --- Ship it! Looks good, as long as the broad approach is approved. -

Re: Review Request 19967: Enabled whitespace/operators rule for cpplint.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19967/#review39427 --- 3rdparty/libprocess/include/process/pid.hpp

Re: Review Request 19968: Enabled whitespace/end_of_line rule for cpplint.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19968/#review39426 --- Ship it! Looks good, as long as the broad approach is approved. -

Re: Review Request 19982: Allowed IP and MAC to be created from u32 value and byte array.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19982/#review39425 --- 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39422 --- configure.ac

Re: Review Request 19988: Enabled readability/todo rule for cpplint.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19988/#review39421 --- Ship it! Looks good, assuming this approach is broadly approved. -

Re: Review Request 19988: Enabled readability/todo rule for cpplint.

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19988/#review39420 --- Patch looks great! Reviews applied: [19775, 19988] All tests passe

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19991/#review39419 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp

[jira] [Commented] (MESOS-995) Extend Subprocess to support environment variables, changing user and working directory

2014-04-03 Thread Bhuvan Arumugam (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958945#comment-13958945 ] Bhuvan Arumugam commented on MESOS-995: --- Nevermind. I'm unable to reproduce this fail

Review Request 20004: Link to Javadoc, reorg framework developer links

2014-04-03 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20004/ --- Review request for mesos, Dave Lester and Ross Allen. Repository: mesos-git D

Re: Review Request 19966: Enabled whitespace/blank_line rule for cpplint.

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19966/#review39415 --- Patch looks great! Reviews applied: [19775, 19966] All tests passe

Re: [VOTE] Release Apache Mesos 0.18.0 (rc6)

2014-04-03 Thread Tim St Clair
from 'hdfs://grid7.lab.bos.redhat.com:8020/spark/spark-0.9.tar.gz' to '/var/run/mesos/slaves/20140403-103606-1898713098-5050-28035-0/frameworks/20140403-103606-1898713098-5050-28035-/executors/20140403-103606-1898713098-5050-28035-0/runs/7e2a86e9-5b4c-4a19-940f-0cdd6148d66b/spa

Re: Review Request 19991: Updated os::read(fd, size) to not seek.

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19991/#review39414 --- Bad patch! Reviews applied: [19991] Failed command: make check Er

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19854/#review39413 --- Patch looks great! Reviews applied: [19854] All tests passed. - M

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19854/ --- (Updated April 3, 2014, 2:31 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 19854: Enable automake 1.14

2014-04-03 Thread Timothy St. Clair
> On April 1, 2014, 8:50 p.m., Benjamin Hindman wrote: > > src/Makefile.am, lines 161-163 > > > > > > I suggested pulling out the offending translation units so that people > > could have some context to understand wh

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2037

2014-04-03 Thread Apache Jenkins Server
See