Review Request 20080: Introducing ContainerInfo as part of CommandInfo

2014-04-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20080/ --- Review request for mesos, Benjamin Hindman, Ian Downes, Niklas Nielsen, and

Re: Review Request 20080: Introducing ContainerInfo as part of CommandInfo

2014-04-07 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20080/#review39674 --- Is this RR really dependent on r19795, r18403? It seems to me that

Re: Review Request 12365: Reservations 4 - Expose Resources for scheduler writers

2014-04-07 Thread Tobias Weingartner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12365/#review39687 --- src/common/resources.cpp

Re: Review Request 12365: Reservations 4 - Expose Resources for scheduler writers

2014-04-07 Thread Tobias Weingartner
On April 7, 2014, 4:26 p.m., Tobias Weingartner wrote: src/common/resources.cpp, line 543 https://reviews.apache.org/r/12365/diff/3/?file=323798#file323798line543 This is comparison of: double == 0 Which is likely somewhat ill defined. Thanks to:

Re: Review Request 20070: Added 'mesos-usage' for use by external containerizers.

2014-04-07 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20070/#review39695 --- Ship it! src/usage/main.cpp

Re: Review Request 20080: Introducing ContainerInfo as part of CommandInfo

2014-04-07 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20080/#review39696 --- src/slave/containerizer/mesos_containerizer.cpp

Re: Review Request 18155: High Availability doc update

2014-04-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18155/#review39702 --- Ship it! I'll address the remaining formatting issues and get it

Re: Review Request 19835: Refactored State::names to return a set instead of vector.

2014-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19835/#review39707 --- Ship it! Good to see this! - Ben Mahler On March 31, 2014, 7:11

Re: Review Request 19007: Added log implementation for state storage.

2014-04-07 Thread Ben Mahler
On March 20, 2014, 1:03 a.m., Ben Mahler wrote: src/state/log.cpp, line 340 https://reviews.apache.org/r/19007/diff/1/?file=515951#file515951line340 This line is broken with the new const Option::get semantics! Benjamin Hindman wrote: That is nasty nasty nasty, looking

Re: Review Request 20072: Better error message for protobuf::write.

2014-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20072/#review39712 --- Ship it!

[jira] [Created] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Timothy St. Clair (JIRA)
Timothy St. Clair created MESOS-1195: Summary: Systemd : cgroups fails on co-mounted subsystem Key: MESOS-1195 URL: https://issues.apache.org/jira/browse/MESOS-1195 Project: Mesos Issue

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/ --- (Updated April 7, 2014, 6:25 p.m.) Review request for mesos, Benjamin Hindman,

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962103#comment-13962103 ] Timothy St. Clair commented on MESOS-1195: -- FWIW the logic fails in cgroups.cpp

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962107#comment-13962107 ] Nikita Vetoshkin commented on MESOS-1195: - Are you trying to make mesos manipulate

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962114#comment-13962114 ] Timothy St. Clair commented on MESOS-1195: -- Correct, but the issue is due to the

[jira] [Updated] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Downes updated MESOS-1195: -- Affects Version/s: (was: 0.19.0) 0.18.0 Systemd : cgroups fails on

Question about LOST status on custom executor

2014-04-07 Thread David Greenberg
I'm working on porting my executor from the CommandExecutor to a custom executor, in order to take advantage of other features of Mesos. I started by changing the TaskInfo in the scheduler to define ExecutorInfo instead of CommandInfo, where the ExecutorInfo's command is the same as the original

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962118#comment-13962118 ] Nikita Vetoshkin commented on MESOS-1195: - Is it a good idea? I mean doesn't

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962123#comment-13962123 ] Timothy St. Clair commented on MESOS-1195: -- It is not required, for some time, to

[jira] [Updated] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy St. Clair updated MESOS-1195: - Description: When attempting to configure mesos to use systemd slices on a 'rawhide/f21'

Re: Mesos Wire Protocol Documentation

2014-04-07 Thread Benjamin Mahler
Unfortunately you will need to learn this by looking at the code in libprocess, as the message passing format is not explicitly documented at the current time. Start with calls like ProtobufProcess::send() and dig your way down. On Sat, Apr 5, 2014 at 7:52 AM, Vladimir Vivien

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962124#comment-13962124 ] Nikita Vetoshkin commented on MESOS-1195: - I see, thanks! Systemd : cgroups

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962129#comment-13962129 ] Ian Downes commented on MESOS-1195: --- The reasoning behind not supporting multiple

Re: Load simulator/benchmark tool

2014-04-07 Thread Benjamin Mahler
Jie recently pointed me to the Sparrow talk: http://www.youtube.com/watch?v=A4k0WqjUY9A In light of the concerns over the latency penalty of centralized scheduler systems, it would be awesome to measure task / update / message latencies when dealing with very large clusters. Does mesosaurus aim

Re: Mesos Wire Protocol Documentation

2014-04-07 Thread Vetoshkin Nikita
Or, just to get to know - you can take tcpdump and take a look :) I personally wouldn't call that HTTP. Something HTTP-like would describe it better. Because it's not request-response. It's just message passing, no need to wait for the answer - send new message one after another. Every message is

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2042

2014-04-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2042/changes

Re: Review Request 20055: Modifed getHostName to use the correct error code.

2014-04-07 Thread Jie Yu
It has been submitted. Please mark it as submitted. On Mon, Apr 7, 2014 at 12:26 PM, Jie Yu yujie@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20055/ Ship it! Ship It! - Jie Yu On April 7th, 2014, 7:12 p.m. UTC, Chi

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-07 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/ --- (Updated April 7, 2014, 8:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/#review39582 --- Please add some tests to exercise the new code path.

Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-764

[jira] [Commented] (MESOS-982) Relax slave (re-)registration retries and add a backoff mechanism.

2014-04-07 Thread Adam B (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962246#comment-13962246 ] Adam B commented on MESOS-982: -- Shouldn't we still be concerned about the network load on the

Re: Question about LOST status on custom executor

2014-04-07 Thread David Greenberg
So, I don't need to notify about STARTING? But I should inform RUNNING, FINISHED, and FAILED? On Mon, Apr 7, 2014 at 4:54 PM, Benjamin Mahler benjamin.mah...@gmail.comwrote: Why is your executor failing? When you say failing, is your executor crashing or simply exiting after doing the

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/#review39727 --- Patch looks great! Reviews applied: [20026] All tests passed. -

Re: Question about LOST status on custom executor

2014-04-07 Thread Benjamin Mahler
Yes you should inform for RUNNING, FINISHED, FAILED. If you have a non-trivial amount of work to perform to get the task into a RUNNING state, you may want to also consider sending STARTING immediately when you get the task: E.g.: receive task send(STARTING) do some work task is now running

[jira] [Comment Edited] (MESOS-982) Relax slave (re-)registration retries and add a backoff mechanism.

2014-04-07 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962279#comment-13962279 ] Benjamin Mahler edited comment on MESOS-982 at 4/7/14 9:25 PM:

[jira] [Reopened] (MESOS-982) Relax slave (re-)registration retries and add a backoff mechanism.

2014-04-07 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler reopened MESOS-982: --- [~adam-mesos] thanks for bringing that up, we should indeed be prudent and add the retry logic

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-07 Thread Benjamin Mahler
Hi Ritwik, please add 'mesos' to the 'Groups' field on the review as well, this ensures it is sent out on the dev@ list. On Mon, Apr 7, 2014 at 2:33 PM, Ritwik ritwik.ya...@gmail.com wrote: +dev@mesos.apache.org -- Forwarded message -- From: Ritwik Yadav

Re: Review Request 19857: Consolidated slave re-registration Timers into a single Timer.

2014-04-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19857/#review39731 --- Ship it! Ship It! - Jiang Yan Xu On April 7, 2014, 12:03 p.m.,

Review Request 20104: Added task reconciliation for unknown slaves and tasks.

2014-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20104/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-764

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-07 Thread Ritwik Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/ --- (Updated April 7, 2014, 9:45 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/#review39730 --- Ship it! src/master/master.cpp

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-07 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39716 --- configure.ac https://reviews.apache.org/r/19702/#comment72329

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/#review39735 --- Patch looks great! Reviews applied: [20106] All tests passed. -

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39739 --- Patch looks great! Reviews applied: [19981, 19982, 19702] All

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/#review39742 --- Great! How about a test that demonstrates the flattening for TryT?

Re: Adding JobServer to Mesos Frameworks page

2014-04-07 Thread Adam Bordelon
Looks like you already have it implemented as a Framework. So, you just want it added to the list at http://mesos.apache.org/documentation/latest/mesos-frameworks/ ? Easy enough. You can even make the change yourself and submit the patch:

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-07 Thread Benjamin Hindman
On April 7, 2014, 11:23 p.m., Ben Mahler wrote: 3rdparty/libprocess/include/process/future.hpp, lines 89-90 https://reviews.apache.org/r/20106/diff/1/?file=552187#file552187line89 Let's avoid doing ResultT for now since supporting an implicit constructor requires template

[jira] [Created] (MESOS-1196) create annotated tag for v0.19.0

2014-04-07 Thread Bhuvan Arumugam (JIRA)
Bhuvan Arumugam created MESOS-1196: -- Summary: create annotated tag for v0.19.0 Key: MESOS-1196 URL: https://issues.apache.org/jira/browse/MESOS-1196 Project: Mesos Issue Type: Task

Re: Review Request 20080: Introducing ContainerInfo as part of CommandInfo

2014-04-07 Thread Benjamin Hindman
On April 7, 2014, 2:50 p.m., Niklas Nielsen wrote: Is this RR really dependent on r19795, r18403? It seems to me that we could land this independently (while the others are in flight). I agree that this does not depend on 19795 or 18403, so let's remove those and commit this

Re: Review Request 20104: Added task reconciliation for unknown slaves and tasks.

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20104/#review39748 --- Patch looks great! Reviews applied: [20104] All tests passed. -

Re: Review Request 19795: Changed Executor::info to executor info future.

2014-04-07 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19795/ --- (Updated April 7, 2014, 4:53 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 19795: Changed Executor::info to executor info future.

2014-04-07 Thread Niklas Nielsen
On April 7, 2014, 11:33 a.m., Ian Downes wrote: src/slave/slave.cpp, line 992 https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line992 I believe Vinod is saying the future argument to __runTask is the same as the member variable executor-info. You can do any error

Re: Review Request 19795: Changed Executor::info to executor info future.

2014-04-07 Thread Niklas Nielsen
On April 2, 2014, 5:47 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 2299 https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line2299 Why is this returning a Future? Is this for future proofing (no pun intended). This is the future that executor-info is set to

Re: Review Request 20080: Introducing ContainerInfo as part of CommandInfo

2014-04-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20080/#review39749 --- src/slave/containerizer/mesos_containerizer.cpp

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/#review39751 --- Patch looks great! Reviews applied: [19857, 20097] All tests

[jira] [Created] (MESOS-1197) Adding signal safe os::system

2014-04-07 Thread Jie Yu (JIRA)
Jie Yu created MESOS-1197: - Summary: Adding signal safe os::system Key: MESOS-1197 URL: https://issues.apache.org/jira/browse/MESOS-1197 Project: Mesos Issue Type: Task Reporter: Jie Yu

[jira] [Updated] (MESOS-1197) Adding signal safe os::system

2014-04-07 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Yu updated MESOS-1197: -- Description: There exist a few scenarios in which we need to execute a shell command inside the child context

Re: Review Request 19702: Added linux routing library for network isolation.

2014-04-07 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39752 --- src/linux/routing.cpp

Re: Review Request 20055: Modifed getHostName to use the correct error code.

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20055/#review39757 --- Bad patch! Reviews applied: [20055] Failed command: git apply

Re: Review Request 20025: Rename CgroupsLauncher to LinuxLauncher

2014-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/#review39760 --- Bad patch! Reviews applied: [20025] Failed command: make check

[jira] [Commented] (MESOS-1197) Adding signal safe os::system

2014-04-07 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962522#comment-13962522 ] Jie Yu commented on MESOS-1197: --- For ::system, the calling process ignoring SIGINT and