Re: Review Request 23771: Added a Docker containerizer.

2014-07-24 Thread Timothy Chen
On July 22, 2014, 11:26 p.m., Ian Downes wrote: src/docker/docker.cpp, line 149 https://reviews.apache.org/r/23771/diff/1/?file=637643#file637643line149 Any specific reason why you use --net=host here? Should this be exposed so bridge can be used too? This will be addressed in

Re: Review Request 23771: Added a Docker containerizer.

2014-07-24 Thread Timothy Chen
On July 22, 2014, 11:26 p.m., Ian Downes wrote: src/linux/cgroups.cpp, line 1902 https://reviews.apache.org/r/23771/diff/1/?file=637648#file637648line1902 Don't you mean memory? I believe you're looking at a old revision? Ben's last commit changed this already. - Timothy

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review48480 --- Looks good Thomas, just a few cleanups and we'll get this

Re: mesos slave sometimes does not send launchTask to executor?

2014-07-24 Thread Henning Schmiedehausen
-master.WARNING:W0724 02:51:59.583686 26949 master.cpp:1769] Ignoring launch tasks message for offer [ 20140724-004359-3078776074-5050-26927-854 ] of framework 20140724-004359-3078776074-5050-26927- from '2594d2b8-c859-44fc-b9c0-7ebead6740bd@10.0.2.15:56713' because it is not from the registered framework

Re: Review Request 23874: Removed unused code from future.hpp.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23874/#review48662 --- You are right that it would be inconvenient if the caller still

Re: Review Request 22796: Add timeout to rescind unused offers

2014-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/#review48670 --- src/master/master.cpp

Re: Review Request 22796: Add timeout to rescind unused offers

2014-07-24 Thread Ben Mahler
On July 24, 2014, 6:27 p.m., Ben Mahler wrote: src/master/master.cpp, lines 3451-3457 https://reviews.apache.org/r/22796/diff/7/?file=634636#file634636line3451 I forgot to mention the bug here in my comment! With using an offerTimeout function, you can properly get the

Re: Review Request 22796: Add timeout to rescind unused offers

2014-07-24 Thread Benjamin Mahler
https://issues.apache.org/jira/browse/MESOS-1452 :) On Thu, Jul 24, 2014 at 11:28 AM, Ben Mahler benjamin.mah...@gmail.com wrote: On July 24, 2014, 6:27 p.m., Ben Mahler wrote: src/master/master.cpp, lines 3451-3457

Re: Review Request 23868: Added a ping timeout in the slave to trigger a re-detection.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23868/#review48685 --- Chatted with BenM. We've been having this problem:

Open call to be incl on Mesos support and services list

2014-07-24 Thread Dave Lester
Hi All, I wanted to revisit a previous thread http://markmail.org/message/o3nlnihmwqtgsm7d where I suggested that we add a section to the Mesos website to list companies that provide Mesos services and development. At that time, we heard interest from: * Grand Logic * Mesosphere * Big Data Open

Re: Review Request 23874: Removed unused code from future.hpp.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23874/#review48689 --- Ship it! Ship It! - Jiang Yan Xu On July 23, 2014, 7:55 p.m.,

Re: Review Request 23867: Handle discards on the master detection futures.

2014-07-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23867/#review48691 --- Ship it! src/master/detector.cpp

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Brian Wickman
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: Looks good Thomas, just a few cleanups and we'll get this committed! Also, I still have a few questions regarding the naming/structure of the modules. ;-) In particular, if we didn't have a native component, would we still

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Thomas Rampelberg
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: Looks good Thomas, just a few cleanups and we'll get this committed! Also, I still have a few questions regarding the naming/structure of the modules. ;-) In particular, if we didn't have a native component, would we still

Re: question about mesos RPM for CentOS7

2014-07-24 Thread Niklas Nielsen
Hi Xiuwen, I am not in the loop on our RPM builds but know that Tim St. Clair is doing this in context of Red Hat builds. I have CC'ed the Mesos dev list so you can get more precise pointers and help :-) Cheers, Niklas On 24 July 2014 14:59, Xiuwen Yang kevinenj...@gmail.com wrote: Hi

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Thomas Rampelberg
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: src/Makefile.am, lines 939-941 https://reviews.apache.org/r/23224/diff/9/?file=625487#file625487line939 Weird indenting here? -1 space maybe? No, these are all dep targets for make. Is there a better syntax for this? On July

Re: Review Request 23771: Added a Docker containerizer.

2014-07-24 Thread Timothy Chen
On July 22, 2014, 11:26 p.m., Ian Downes wrote: src/slave/containerizer/docker.hpp, line 50 https://reviews.apache.org/r/23771/diff/2/?file=638778#file638778line50 This can be private. We actually want to maintain it open so we can inherit this class in tests. I can leave a

Re: Review Request 23868: Added a ping timeout in the slave to trigger a re-detection.

2014-07-24 Thread Ben Mahler
On July 24, 2014, 10:08 p.m., Jiang Yan Xu wrote: src/master/constants.hpp, line 26 https://reviews.apache.org/r/23868/diff/2/?file=641173#file641173line26 What is this for? MIN_MEM is a Bytes object. - Ben --- This is an

Review Request 23911: multihashmap.getKey() method (useful for fixing MESOS-947)

2014-07-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23911/ --- Review request for mesos. Bugs: MESOS-947

Re: Review Request 23911: multihashmap.getKey() method (useful for fixing MESOS-947)

2014-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23911/#review48705 --- 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp

Re: Review Request 23911: multihashmap.getKey() method (useful for fixing MESOS-947)

2014-07-24 Thread Ben Mahler
On July 25, 2014, 12:51 a.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, line 42 https://reviews.apache.org/r/23911/diff/1/?file=641620#file641620line42 Aren't there potentially multiple keys for a particular value? i.e.

Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

2014-07-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/ --- Review request for mesos. Bugs: MESOS-947

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

2014-07-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/ --- (Updated July 24, 2014, 6:01 p.m.) Review request for mesos. Changes ---

Review Request 23913: Add C++11 (and boost) atomic support to stout

2014-07-24 Thread Craig Hansen-Sturm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23913/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs:

Re: Review Request 23911: multihashmap.getKey() method (useful for fixing MESOS-947)

2014-07-24 Thread Bernd Mathiske
On July 24, 2014, 5:51 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, line 42 https://reviews.apache.org/r/23911/diff/1/?file=641620#file641620line42 Aren't there potentially multiple keys for a particular value? i.e.