Review Request 24177: Pass executor directory to Isolator::prepare().

2014-08-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git

Review Request 24178: Basic filesystem isolator for Linux.

2014-08-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-1586

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-08-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24123/ --- (Updated July 31, 2014, 11:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-08-01 Thread Jiang Yan Xu
On July 30, 2014, 5:12 p.m., Ben Mahler wrote: src/tests/zookeeper_tests.cpp, lines 202-205 https://reviews.apache.org/r/24123/diff/1/?file=646315#file646315line202 What's stopping it from being even lower? Say, 100 milliseconds? Ok so with 100 milliseconds I have seen

JIRA Kanban Board

2014-08-01 Thread Benjamin Hindman
Hello! I love seeing the number of committers, issues, and reviews grow! But so too does the complexity of the project: who's working on what, what needs a shepherd, what needs to get reviewed, etc. To help, we've slowly been getting around to improving our use of JIRA. Some of you are already

Re: Review Request 23771: Added a Docker containerizer.

2014-08-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review49328 --- src/tests/docker_containerizer_tests.cpp

Re: Review Request 23707: Fix line comments end punctuation in mesos source

2014-08-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23707/#review49331 --- Ship it! Ship It! - Adam B On July 19, 2014, 1:49 a.m., Timothy

Re: Review Request 23709: Fix line comments end punctuation in libprocess

2014-08-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23709/#review49332 --- Ship it! LGTM 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 23710: Add line comments end punctuation style rule

2014-08-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/#review49333 --- support/cpplint.patch

Re: Review Request 23771: Added a Docker containerizer.

2014-08-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review49338 --- src/docker/docker.cpp

Re: Review Request 23710: Add line comments end punctuation style rule

2014-08-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/#review49349 --- support/cpplint.py

Re: Review Request 23771: Added a Docker containerizer.

2014-08-01 Thread Timothy Chen
On Aug. 1, 2014, 11:53 a.m., Adam B wrote: src/slave/slave.cpp, line 2429 https://reviews.apache.org/r/23771/diff/10/?file=647996#file647996line2429 Is this an existing non-docker-related bug in the slave code? How about renaming 'future' to make it clear what the bool

Python bindings are changing!

2014-08-01 Thread Thomas Rampelberg
- What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be distributed easily. This forces python projects using mesos to copy protobufs around and forces a onerous dependency on anyone

Re: Review Request 23771: Added a Docker containerizer.

2014-08-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/ --- (Updated Aug. 1, 2014, 4:36 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23700/ --- (Updated Aug. 1, 2014, 10:54 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-01 Thread Jiang Yan Xu
On July 30, 2014, 11:18 a.m., Jiang Yan Xu wrote: Talked to Jie. This script looks for the newest (most recently started) process in this session and this may sometimes be not what we want. If some tests themselves fork subprocesses and depending on whether setsid() is called what we

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-08-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24123/#review49368 --- Ship it! Are these tests faster given the split? I see this test

Re: Review Request 24123: Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling

2014-08-01 Thread Jiang Yan Xu
On Aug. 1, 2014, 11:15 a.m., Ben Mahler wrote: Are these tests faster given the split? I see this test used to take 10 seconds to run. yeah. 200 ms each because the wait is removed. - Jiang Yan --- This is an automatically

Re: Review Request 23453: Unbundle glog

2014-08-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/#review49373 --- @tim: can you test and confirm that this works with a prefix

Re: Review Request 24128: Add 'max_num_executors' flag for use with network isolation

2014-08-01 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24128/ --- (Updated Aug. 1, 2014, 12:37 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24194: Fixed bug in io::poll.

2014-08-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/ --- (Updated Aug. 1, 2014, 8:05 p.m.) Review request for mesos, Ben Mahler and Jie

Review Request 24194: Fixed bug in io::poll.

2014-08-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/ --- Review request for mesos and Jie Yu. Bugs: MESOS-1658

Re: Python bindings are changing!

2014-08-01 Thread Thomas Rampelberg
`pip install mesos.interface` now works =) On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg tho...@saunter.org wrote: - What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be

Re: Python bindings are changing!

2014-08-01 Thread Jie Yu
Thomas, Thank you for the heads-up. One question: what if mesos and python binding have different versions? For example, is it ok to use a 0.19.0 python binding and having a 0.20.0 mesos? Same question for the reverse. - Jie On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg tho...@saunter.org

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2280

2014-08-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2280/changes Changes: [benjamin.hindman] Refactored the python bindings into multiple modules. -- [...truncated 3891 lines...] [==] Running 145 tests from 29 test

Jenkins build is back to normal : mesos-reviewbot #1263

2014-08-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1263/changes

Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-08-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review49383 --- Patch looks great! Reviews applied: [24177, 24178] All tests

Re: Python bindings are changing!

2014-08-01 Thread Tom Arnfeld
Woah, this is really awesome Thomas! Especially the pip install ;-) Looking forward to bringing pesos up to speed with this. On 1 August 2014 21:30, Jie Yu yujie@gmail.com wrote: Thomas, Thank you for the heads-up. One question: what if mesos and python binding have different versions?

Review Request 24197: Reap interval time adjusted from 1second to 250 milliseconds

2014-08-01 Thread Craig Hansen-Sturm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24197/ --- Review request for mesos and Ian Downes. Summary (updated) -

Re: Review Request 24197: Reap interval time adjusted from 1second to 250 milliseconds

2014-08-01 Thread Craig Hansen-Sturm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24197/ --- (Updated Aug. 1, 2014, 11 p.m.) Review request for mesos and Ian Downes.

Re: Review Request 24128: Add 'max_num_executors' flag for use with network isolation

2014-08-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24128/#review49400 --- We probably wanna go with this patch for 0.20.0. See MESOS-1466 for

Re: Review Request 23771: Added a Docker containerizer.

2014-08-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/ --- (Updated Aug. 1, 2014, 11:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 24128: Add 'max_num_executors' flag for use with network isolation

2014-08-01 Thread Dominic Hamon
On Aug. 1, 2014, 4:30 p.m., Jie Yu wrote: src/master/master.cpp, line 3434 https://reviews.apache.org/r/24128/diff/4/?file=648800#file648800line3434 Could you please add an optional filer for 'resourcesRecovered' (similar to that in 'resourcesUnused'), and use a default filter

Re: Review Request 24128: Add 'max_num_executors' flag for use with network isolation

2014-08-01 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24128/ --- (Updated Aug. 1, 2014, 5:03 p.m.) Review request for mesos, Benjamin Hindman

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2281

2014-08-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2281/changes

Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.

2014-08-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23700/ --- (Updated Aug. 1, 2014, 6:55 p.m.) Review request for mesos and Vinod Kone.

Build failed in Jenkins: Mesos-Ubuntu-distcheck #246

2014-08-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/246/changes Changes: [benjamin.hindman] Refactored the python bindings into multiple modules. [yan] Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling -- [...truncated 4546 lines...]