On Aug. 26, 2014, 5:58 p.m., Ben Mahler wrote:
It was done using macro expansion because variadic templates require C++11.
We're not yet able to assume C++11:
https://issues.apache.org/jira/browse/MESOS-750
Niklas Nielsen wrote:
But as this reduce compile time for folks with
On Aug. 26, 2014, 7:36 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [25079]
Failed command: ./support/mesos-style.py
Error:
Checking 506 files using filter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/
---
(Updated Aug. 27, 2014, 5:20 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/#review51666
---
Bad patch!
Reviews applied: [25079]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
Review request for mesos, Adam B and Benjamin Hindman.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 27, 2014, 5:59 p.m.)
Review request for mesos, Adam B and
Glad to see that you are really thinking this through.
Yes it's explicit that resources won't be revoked and will stay outstanding
in this case but I would just add that the slave won't enter the drained
state. It's just hard to follow the drain/revoke/outstanding/inverse
offer/reclaim
On Aug. 26, 2014, 9:58 p.m., Ben Mahler wrote:
It was done using macro expansion because variadic templates require C++11.
We're not yet able to assume C++11:
https://issues.apache.org/jira/browse/MESOS-750
Niklas Nielsen wrote:
But as this reduce compile time for folks with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/
---
(Updated Aug. 27, 2014, 6:10 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51669
---
src/slave/containerizer/isolators/cgroups/blkio.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51672
---
First pass looks great. See Tim Chen's review too!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 27, 2014, 6:37 p.m.)
Review request for mesos, Adam B and
On Mon, Aug 25, 2014 at 5:03 PM, Vinod Kone vinodk...@gmail.com wrote:
See my answers inline.
Based on what you say, looks like there are more HTTP endpoints (rw)
exposed to slaves and frameworks, like /shutdown. We don't want to
implement auth for these endpoints, atm.
Yes. There are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 27, 2014, 6:40 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 27, 2014, 6:50 p.m.)
Review request for mesos, Adam B and
On Aug. 26, 2014, 12:38 a.m., Timothy St. Clair wrote:
configure.ac, line 407
https://reviews.apache.org/r/25030/diff/1/?file=668368#file668368line407
Can we just do the compile check?
I will add a TODO for using AX_CXX_CHECK_LIB once we resolve the legal issue.
For now, I'll just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51678
---
Please close issues once you've addressed them.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1739
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/#review51680
---
src/common/attributes.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 27, 2014, 7:48 p.m.)
Review request for mesos, Adam B and
On Aug. 27, 2014, 7:40 p.m., Timothy Chen wrote:
src/common/attributes.cpp, line 162
https://reviews.apache.org/r/25111/diff/1/?file=670376#file670376line162
We can't support C++11 yet.
We've removed the c++11 auto moved back to foreach
- Patrick
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/#review51687
---
src/master/master.hpp
@67.195.81.186:49273 with id 20140827-203623-3125920579-49273-18008
I0827 20:36:23.645206 18024 master.cpp:1218] Elected as the leading master!
I0827 20:36:23.645217 18024 master.cpp:1036] Recovering from registrar
I0827 20:36:23.645447 18030 registrar.cpp:313] Recovering registrar
I0827 20:36:23.64 18029
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
---
(Updated Aug. 27, 2014, 8:45 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25116/
---
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25116/
---
(Updated Aug. 27, 2014, 8:46 p.m.)
Review request for mesos, Benjamin Hindman
On Aug. 27, 2014, 11:32 a.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, lines 440-441
https://reviews.apache.org/r/25105/diff/1/?file=670315#file670315line440
Let's use put the units at the end. Also, we can pull out read vs
write:
disk_read_total_iops
On Aug. 27, 2014, 8:29 p.m., Timothy Chen wrote:
src/master/master.hpp, line 1169
https://reviews.apache.org/r/25111/diff/2/?file=670389#file670389line1169
I don't think you need a bool either.
It should either succeed or not, and when it doesn't you throw an error
anyways
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25121/
---
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1735
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 27, 2014, 9:10 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 27, 2014, 9:28 p.m.)
Review request for mesos, Adam B and
On Aug. 27, 2014, 8:29 p.m., Timothy Chen wrote:
src/master/master.hpp, line 1169
https://reviews.apache.org/r/25111/diff/2/?file=670389#file670389line1169
I don't think you need a bool either.
It should either succeed or not, and when it doesn't you throw an error
anyways
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 27, 2014, 9:38 p.m.)
Review request for mesos, Adam B and
While playing with Rendler https://github.com/mesosphere/RENDLER I
noticed that if the task (read: python executor) crashes, the underlying
executor stays alive and therefore is not reaped, which renders the task
running indefinitely. Here
https://gist.github.com/rukletsov/4a74743c5b67f304e661 is
There are at least two mechanisms for shutdown by timeout in mesos:
* through the separate ShutdownProcess (src/exec/exec.cpp:383)
* delay in the same process (src/launcher/executor.cpp:325)
Why do we need two different ways of doing that?
Regards,
Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25124/
---
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25126/
---
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25128/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-1705
A crashed thread does not terminate the Python interpreter, so the
executor here will stay alive. If you want an abnormal thread exit to
result in an executor termination, you will have to implement that behavior
explicitly. We use a thread liveness detector that looks something like:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25126/#review51714
---
Ship it!
Ship It!
- Jie Yu
On Aug. 27, 2014, 10:50 p.m., Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25128/#review51715
---
Ship it!
Ship It!
- Jie Yu
On Aug. 27, 2014, 10:54 p.m., Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25129/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-1729
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25124/#review51716
---
src/net-bench/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25129/#review51718
---
Ship it!
src/logging/logging.cpp
On Aug. 27, 2014, 4:01 p.m., Dominic Hamon wrote:
src/net-bench/main.cpp, line 166
https://reviews.apache.org/r/25124/diff/1/?file=670615#file670615line166
it might be worth (for a future version) allowing this to be a random
string of user-defined length and also tracking
On Aug. 27, 2014, 4:01 p.m., Dominic Hamon wrote:
src/net-bench/main.cpp, line 166
https://reviews.apache.org/r/25124/diff/1/?file=670615#file670615line166
it might be worth (for a future version) allowing this to be a random
string of user-defined length and also tracking
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2369/changes
Changes:
[vinodkone] Fixed signal handling for stout.
[vinodkone] Fixed signal handling in libprocess.
[vinodkone] Fixed signal handling for Mesos.
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25116/#review51722
---
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 27, 2014, 8:46
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2370/changes
Changes:
[vinodkone] Improved the signal handling comment in Mesos tests.
[benjamin.hindman] Fix External Containerizer creation.
--
[...truncated 260
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51724
---
src/slave/containerizer/isolators/cgroups/blkio.cpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2346/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 28, 2014, 12:27 a.m.)
Review request for mesos, Adam B and
On Aug. 27, 2014, 6:32 p.m., Benjamin Hindman wrote:
src/slave/containerizer/isolators/cgroups/blkio.hpp, line 35
https://reviews.apache.org/r/25105/diff/1/?file=670317#file670317line35
This doesn't compile. ;-)
Yeah I'm not quite sure how I ended up with an unescaped # causing the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51728
---
src/slave/containerizer/isolators/cgroups/blkio.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 28, 2014, 12:48 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25084/
---
(Updated Aug. 28, 2014, 12:51 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51730
---
src/slave/containerizer/isolators/cgroups/blkio.hpp
On Aug. 28, 2014, 12:56 a.m., Timothy Chen wrote:
src/slave/containerizer/isolators/cgroups/blkio.hpp, line 36
https://reviews.apache.org/r/25105/diff/8/?file=670662#file670662line36
Are you working on unit tests?
[~tnachen] they are currently being worked on.
- Patrick
See https://builds.apache.org/job/mesos-reviewbot/1421/
--
[...truncated 5416 lines...]
rm -f slave/containerizer/isolators/network/.dirstamp
rm -f sched/*.o
rm -f slave/containerizer/mesos/.deps/.dirstamp
rm -f slave/containerizer/mesos/.dirstamp
rm -f
See https://builds.apache.org/job/mesos-reviewbot/1422/changes
60 matches
Mail list logo
