Re: Review Request 24810: Added Resources support to return the port range for the given number of ports.

2014-09-02 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24810/#review52033 --- src/common/resources.cpp

Re: Review Request 25218: Updated a comment and some syntax formatting.

2014-09-02 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/#review52034 --- Ship it! Thanks - I struggled with the wording there. - Dominic

Re: Review Request 25207: Fixed a bug in the allocator that causes filter to be unnecessarily installed.

2014-09-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25207/ --- (Updated Sept. 2, 2014, 5:04 p.m.) Review request for mesos, Dominic Hamon and

Re: Review Request 24987: Fail when no command provided with shell enabled in docker

2014-09-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24987/#review52042 --- Tim, can you close this review? It's submitted. - Jie Yu On Aug.

Re: Review Request 25207: Fixed a bug in the allocator that causes filter to be unnecessarily installed.

2014-09-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25207/#review52046 --- Ship it! Ship It! - Vinod Kone On Sept. 2, 2014, 5:04 p.m., Jie

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

2014-09-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 2, 2014, 5:44 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25035: Fix for MESOS-1688

2014-09-02 Thread Martin Weindel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 2, 2014, 5:52 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25035: Fix for MESOS-1688

2014-09-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review52048 --- Mind writing a test for this in allocator_tests.cpp?

Re: Review Request 25207: Fixed a bug in the allocator that causes filter to be unnecessarily installed.

2014-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25207/#review52057 --- Patch looks great! Reviews applied: [25207] All tests passed. -

Re: Shutdown by timeout in mesos

2014-09-02 Thread Benjamin Mahler
Are you still wondering about this? ShutdownProcess is inside the libmesos executor driver and ensures that we forcibly shutdown an executor if it doesn't comply with the shutdown request within the timeout. The second bullet in your list is the Command Executor, which is the executor that is

Reviewboard - submitted.

2014-09-02 Thread Tim St Clair
Has something changed with review-board? I'm not able to mark as submitted. -- Cheers, Timothy St. Clair Red Hat Inc.

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2375

2014-09-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2375/changes

Re: Reviewboard - submitted.

2014-09-02 Thread Vinod Kone
what is the error? On Tue, Sep 2, 2014 at 12:00 PM, Tim St Clair tstcl...@redhat.com wrote: Has something changed with review-board? I'm not able to mark as submitted. -- Cheers, Timothy St. Clair Red Hat Inc.

Re: Review Request 24407: Use curl-config to locate lib curl when possible

2014-09-02 Thread Timothy St. Clair
On Aug. 26, 2014, 12:56 a.m., Timothy St. Clair wrote: Sorry for the lag, I'm still catching up post #MesosCon You can mark as submitted. commit a56be86b950c2f64fa98d7f55488afbc7c68e468 Author: Chris Heller hellert...@gmail.com Date: Tue Aug 26 11:08:01 2014 -0500 - Timothy

Re: Review Request 25261: Check for variadic template and default/deleted function support

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review52067 --- Just something to note here, there's a bug in earlier GCC versions

Re: Design Review: Maintenance Primitives

2014-09-02 Thread Benjamin Mahler
Re: terminology An offer can be rescinded, resources can be revoked. Only inverse offers with a hard deadline can lead to the revocation of the resources. In this sense, an inverse offer is more akin to a request to release allocated resources; hard inverse offers are also a revocation

Re: Review Request 25035: Fix for MESOS-1688

2014-09-02 Thread Martin Weindel
On Sept. 2, 2014, 5:53 nachm., Vinod Kone wrote: src/master/hierarchical_allocator_process.hpp, lines 825-840 https://reviews.apache.org/r/25035/diff/2/?file=672690#file672690line825 I suggest to delete this comment altogether because frameworks can utilize offers with either no

Re: Review Request 25205: Fix command executor path check

2014-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/ --- (Updated Sept. 2, 2014, 8:43 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 25205: Fix command executor path check

2014-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/ --- (Updated Sept. 2, 2014, 8:43 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git

Review Request 25272: Added instructions for getting started with centos.

2014-09-02 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Re: Review Request 25272: Added instructions for getting started with centos.

2014-09-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/#review52083 --- Ship it! im assuming you tested this on a stock centos6.5 box?

Review Request 25273: Update the containerizers failed to launch error message in the slave

2014-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25273/ --- Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.

Re: Review Request 25272: Added instructions for getting started with centos.

2014-09-02 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/ --- (Updated Sept. 2, 2014, 9:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 25272: Added instructions for getting started with centos.

2014-09-02 Thread Thomas Rampelberg
On Sept. 2, 2014, 9:05 p.m., Vinod Kone wrote: im assuming you tested this on a stock centos6.5 box? vagrant? Yup, stock centos6.5 (base GCE image). On Sept. 2, 2014, 9:05 p.m., Vinod Kone wrote: docs/getting-started.md, lines 66-68

Re: Review Request 25272: Added instructions for getting started with centos.

2014-09-02 Thread Vinod Kone
On Sept. 2, 2014, 9:05 p.m., Vinod Kone wrote: im assuming you tested this on a stock centos6.5 box? vagrant? Thomas Rampelberg wrote: Yup, stock centos6.5 (base GCE image). cool. committed this with a minor fix (s/Centos/CentOS/). - Vinod

Re: Review Request 24264: Installed python libraries during make install.

2014-09-02 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Sept. 2, 2014, 9:25 p.m.) Review request for mesos and Benjamin

Mesos 0.20.0 blog post

2014-09-02 Thread Jie Yu
Hi, I've drafted the blog post for the 0.20.0 release (the link below). Please let me know if you have any suggestion or comments. The plan is to publish it tomorrow. https://docs.google.com/document/d/1fz9M96KX7BoA2hWUdUmFRCiJnSxdyYPn3Qnwhh1JBZw/edit?usp=sharing - Jie

Re: Review Request 24810: Added Resources support to return the port range for the given number of ports.

2014-09-02 Thread Zuyu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24810/ --- (Updated Sept. 2, 2014, 5:30 p.m.) Review request for mesos and Vinod Kone.

Re: Shutdown by timeout in mesos

2014-09-02 Thread Alex Rukletsov
Thanks for the answer, Benjamin. Let me reformulate my question a bit. For me it looks like both do the same thing: after a certain timeout perform hard shutdown. Maybe it makes sense to choose one approach and apply it everywhere for consistency? On Tue, Sep 2, 2014 at 8:56 PM, Benjamin Mahler

Review Request 25274: Update the Mesos C++ Style Guide.

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25274/ --- Review request for mesos, Adam B, Niklas Nielsen, and Timothy Chen.

Review Request 25275: Introduce ClangFormat to Mesos.

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25275/ --- Review request for mesos, Adam B, Niklas Nielsen, and Timothy Chen.

Re: Review Request 25275: Introduce ClangFormat to Mesos.

2014-09-02 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25275/#review52102 --- Fantastic - I don't know if you saw my work on this but i linked

Re: Review Request 25261: Check for variadic template and default/deleted function support

2014-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review52106 --- Patch looks great! Reviews applied: [25261] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #1455

2014-09-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1455/changes

Re: Review Request 25275: Introduce ClangFormat to Mesos.

2014-09-02 Thread Michael Park
On Sept. 2, 2014, 7:22 p.m., Dominic Hamon wrote: docs/clang-format.md, line 67 https://reviews.apache.org/r/25275/diff/1/?file=674485#file674485line67 this is great! however, i think it's too much overhead to expect people to use it. for broad adoption we should stick to one

Re: Review Request 25275: Introduce ClangFormat to Mesos.

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25275/ --- (Updated Sept. 2, 2014, 8:34 p.m.) Review request for mesos, Adam B, Niklas

Re: Review Request 25275: Introduce ClangFormat to Mesos.

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25275/ --- (Updated Sept. 2, 2014, 8:43 p.m.) Review request for mesos, Adam B, Cody

Re: Review Request 25274: Update the Mesos C++ Style Guide.

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25274/ --- (Updated Sept. 2, 2014, 8:44 p.m.) Review request for mesos, Adam B, Cody

Re: Review Request 25275: Introduce ClangFormat to Mesos.

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25275/ --- (Updated Sept. 2, 2014, 8:44 p.m.) Review request for mesos, Adam B, Cody

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2081

2014-09-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2081/changes Changes: [vinodkone] Added instructions for getting started with CentOS. -- [...truncated 3453 lines...] mesos.__init__: module references __path__ creating dist

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #311

2014-09-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/311/changes

Re: Shutdown by timeout in mesos

2014-09-02 Thread Benjamin Mahler
The essential one you have not mentioned is the shutdown escalation in the slave. The executor driver and command executor shutdowns are orthogonal and are not strictly required given that Mesos will attempt to reliably shutdown the executor. However, a good executor implementation will comply

Re: Mesos 0.20.0 blog post

2014-09-02 Thread Benjamin Hindman
LGTM! On Tuesday, September 2, 2014, Jie Yu yujie@gmail.com wrote: Hi, I've drafted the blog post for the 0.20.0 release (the link below). Please let me know if you have any suggestion or comments. The plan is to publish it tomorrow.

Build failed in Jenkins: mesos-reviewbot #1456

2014-09-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1456/ -- [...truncated 5389 lines...] rm -f scheduler/.dirstamp rm -rf files/.libs files/_libs rm -f scheduler/*.lo rm -f slave/.deps/.dirstamp rm -rf java/jni/.libs java/jni/_libs rm -f slave/*.o rm -f