Re: Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/#review53658 --- Ship it! Did we lose the test? We need that back to Ship It

Build failed in Jenkins: mesos-reviewbot #1592

See https://builds.apache.org/job/mesos-reviewbot/1592/ -- [...truncated 4022 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Re: Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/ --- (Updated Sept. 17, 2014, 8:23 a.m.) Review request for mesos and Benjamin

Build failed in Jenkins: mesos-reviewbot #1593

See https://builds.apache.org/job/mesos-reviewbot/1593/ -- [...truncated 4022 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Build failed in Jenkins: mesos-reviewbot #1594

See https://builds.apache.org/job/mesos-reviewbot/1594/ -- [...truncated 4022 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Re: Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/#review53675 --- Ship it! src/tests/docker_tests.cpp

Review Request 25735: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/ --- Review request for mesos. Bugs: MESOS-1805

Re: Review Request 25735: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/ --- (Updated Sept. 17, 2014, 4:25 p.m.) Review request for mesos. Bugs:

Re: Review Request 25735: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/ --- (Updated Sept. 17, 2014, 4:25 p.m.) Review request for mesos. Bugs:

Build failed in Jenkins: mesos-reviewbot #1595

See https://builds.apache.org/job/mesos-reviewbot/1595/ -- [...truncated 4021 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Build failed in Jenkins: mesos-reviewbot #1596

See https://builds.apache.org/job/mesos-reviewbot/1596/ -- [...truncated 4021 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/ --- (Updated Sept. 17, 2014, 3:48 p.m.) Review request for mesos, Benjamin

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/#review53682 --- Just rebased on master - Timothy Chen On Sept. 17, 2014, 3:48

Build failed in Jenkins: mesos-reviewbot #1597

See https://builds.apache.org/job/mesos-reviewbot/1597/ -- [...truncated 4022 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Build failed in Jenkins: mesos-reviewbot #1598

See https://builds.apache.org/job/mesos-reviewbot/1598/changes Changes: [benjamin.hindman] Override entrypoint when shell enabled in Docker. -- [...truncated 4022 lines...] make[6]: Leaving directory

Re: Review Request 25735: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/#review53688 --- Ship it! I'm not convinced that this is necessarily the way we

Build failed in Jenkins: mesos-reviewbot #1599

See https://builds.apache.org/job/mesos-reviewbot/1599/ -- [...truncated 4022 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Re: Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/ --- (Updated Sept. 17, 2014, 4:45 p.m.) Review request for mesos, Benjamin Hindman

Build failed in Jenkins: mesos-reviewbot #1600

See https://builds.apache.org/job/mesos-reviewbot/1600/ -- [...truncated 4022 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Re: Review Request 24776: Add docker containerizer destroy tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53692 --- Bad patch! Reviews applied: [24776] Failed command: git apply

Jenkins build is back to normal : mesos-reviewbot #1601

See https://builds.apache.org/job/mesos-reviewbot/1601/changes

Build failed in Jenkins: Mesos-Ubuntu-distcheck #335

See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/335/changes Changes: [benjamin.hindman] Override entrypoint when shell enabled in Docker. -- [...truncated 3905 lines...] libtool: link: g++ -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o tests

Re: Review Request 25735: change const pass-by-value to const reference in stout

On Sept. 17, 2014, 6:32 p.m., Dominic Hamon wrote: I'm not convinced that this is necessarily the way we want to go, given the benefits of move semantics in modern compilers, but for consistency we can ship this until we have proof that performance favours the alternative. Isn't move

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2107

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2107/changes Changes: [benjamin.hindman] Override entrypoint when shell enabled in Docker. -- [...truncated 3716 lines...] byte-compiling

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/ --- (Updated Sept. 17, 2014, 11:12 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

On Sept. 16, 2014, 11:20 a.m., Ben Mahler wrote: src/master/detector.cpp, lines 396-404 https://reviews.apache.org/r/25663/diff/1/?file=689921#file689921line396 Any way to explicitly ignore the no node case? Here we're ignoring all failures, which is a bit scary, since

Re: Build failed in Jenkins: mesos-reviewbot #1600

On Wed, Sep 17, 2014 at 9:56 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: ../../src/tests/docker_tests.cpp: In member function 'virtual void DockerTest_ROOT_DOCKER_CheckPortResource_Test::TestBody()': ../../src/tests/docker_tests.cpp:263:28: error: 'AWAIT_EXPECTED_FAILED' was

Re: Review Request 25735: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/#review53704 --- Patch looks great! Reviews applied: [25735] All tests passed. -

Re: Build failed in Jenkins: mesos-reviewbot #1600

This should already been fixed with the latest master. Tim On Wed, Sep 17, 2014 at 2:17 PM, Vinod Kone vinodk...@gmail.com wrote: On Wed, Sep 17, 2014 at 9:56 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: ../../src/tests/docker_tests.cpp: In member function 'virtual void

Re: Review Request 25035: Updated allocator to offer cpu only or memory only resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 17, 2014, 6:36 p.m.) Review request for mesos and Vinod Kone.

Build failed in Jenkins: mesos-reviewbot #1603

See https://builds.apache.org/job/mesos-reviewbot/1603/changes Changes: [yujie.jay] Added per-container egress rate limit for port mapping network isolator. -- [...truncated 5415 lines...] rm -f slave/containerizer/*.lo rm -f

Re: Review Request 25549: Basic filesystem isolator for Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53710 --- I'll take a look once the outstanding issues are addressed. -

Re: Review Request 25655: Add alternate os::chown taking uid and gid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25655/#review53714 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 8 p.m., Ian

Re: Review Request 25261: Check for variadic template support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review53715 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:26 p.m.,

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2377

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2377/changes

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review53718 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:20 p.m.,

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/#review53719 --- Bad patch! Reviews applied: [25663] Failed command:

Jenkins build is back to normal : mesos-reviewbot #1604

See https://builds.apache.org/job/mesos-reviewbot/1604/changes

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #336

See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/336/changes

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/ --- (Updated Sept. 17, 2014, 12:26 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/#review53739 --- Patch looks great! Reviews applied: [25663] All tests passed. -

Re: Review Request 25735: change const pass-by-value to const reference in stout

On Sept. 17, 2014, 9:32 a.m., Dominic Hamon wrote: I'm not convinced that this is necessarily the way we want to go, given the benefits of move semantics in modern compilers, but for consistency we can ship this until we have proof that performance favours the alternative. Kamil

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2108

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2108/changes Changes: [benjamin.hindman] Add Docker pull to docker abstraction. [yujie.jay] Added per-container egress rate limit for port mapping network isolator. --

Review Request 25756: post-reviews.py: added --no-color to git log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- Review request for mesos. Repository: mesos-git Description --- - For

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/#review53755 --- Ship it! Ship It! - Timothy Chen On Sept. 17, 2014, 10:26 p.m.,

Re: Review Request 25565: Added a removeExecutor helper in the Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25565/ --- (Updated Sept. 17, 2014, 10:47 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25565: Added a removeExecutor helper in the Master.

On Sept. 12, 2014, 9:45 p.m., Vinod Kone wrote: src/master/master.cpp, line 3312 https://reviews.apache.org/r/25565/diff/1/?file=687298#file687298line3312 We do have a executorLost() callback now! Just send it already and fix MESOS-313? Yikes! I'm a bit weary of sneaking that in

Review Request 25755: Replace os::Release with Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/ --- Review request for mesos. Repository: mesos-git Description --- Version

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/#review53762 --- Ship it! Thanks for adding the test! Too bad there is so much

Re: Review Request 25755: Replace os::Release with Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/#review53763 --- Ship it! Ship It! - Ian Downes On Sept. 17, 2014, 3:50 p.m.,

Re: Review Request 25755: Replace os::Release with Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/#review53764 --- Ship it! Looks great! Thanks for following up. I will split this

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/#review53765 --- Can you add a little more description as to what this is fixing?

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 11:11 p.m.) Review request for mesos, Benjamin

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53767 --- src/slave/containerizer/docker.cpp

Re: Review Request 25755: Replace os::Release with Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/#review53766 --- Whoops, looks like the test fails for me. Since we need to fix it,

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

On Sept. 17, 2014, 11:20 p.m., Adam B wrote: src/slave/containerizer/docker.cpp, lines 353-358 https://reviews.apache.org/r/24776/diff/4/?file=692992#file692992line353 Why call new DockerContainerizerProcess twice? Oops, bad merge! - Timothy

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 11:22 p.m.) Review request for drill, Benjamin

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 11:22 p.m.) Review request for mesos, Benjamin

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2109

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2109/changes Changes: [vinodkone] Updated allocator to offer cpu only or memory only resources. [adam] Added CHANGELOG for 0.20.1. [dhamon] Check for variadic template support

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/#review53772 --- Patch looks great! Reviews applied: [25756] All tests passed. -

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- (Updated Sept. 17, 2014, 7:35 p.m.) Review request for mesos. Changes

Review Request 25758: Modify docker pull to call inspect after pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25758/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 25755: Replace os::Release with Version.

On Sept. 17, 2014, 7:20 p.m., Ben Mahler wrote: Whoops, looks like the test fails for me. Since we need to fix it, can you split the patch while you're at it? I think the parsing needs to be more advanced to handle OSes with labels on the versions. Not just labels, but also more

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2110

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2110/changes

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53781 --- Patch looks great! Reviews applied: [24776] All tests passed. -

[VOTE] Release Apache Mesos 0.20.1 (rc2)

Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, etc. The CHANGELOG for the release is

Re: Review Request 25755: Replace os::Release with Version.

On Sept. 17, 2014, 11:20 p.m., Ben Mahler wrote: Whoops, looks like the test fails for me. Since we need to fix it, can you split the patch while you're at it? I think the parsing needs to be more advanced to handle OSes with labels on the versions. Kapil Arya wrote: Not

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/ --- (Updated Sept. 17, 2014, 6:47 p.m.) Review request for mesos. Changes

Re: [VOTE] Release Apache Mesos 0.20.1 (rc2)

Update: The vote is open until Mon Sep 22 10:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. On Wed, Sep 17, 2014 at 6:27 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/#review53790 --- Patch looks great! Reviews applied: [23912] All tests passed. -

Re: [VOTE] Release Apache Mesos 0.20.1 (rc2)

+1 (binding) make check passes on CentOS 5.5 w/ gcc 4.8.2. On Wed, Sep 17, 2014 at 7:42 PM, Adam Bordelon a...@mesosphere.io wrote: Update: The vote is open until Mon Sep 22 10:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. On Wed, Sep 17, 2014 at 6:27 PM,

Re: Review Request 25758: Modify docker pull to call inspect after pull

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25758/ --- (Updated Sept. 18, 2014, 5:51 a.m.) Review request for mesos and Benjamin

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2381

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2381/changes Changes: [yan] MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected. --

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2111

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2111/changes Changes: [yan] MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected. -- [...truncated 64967 lines...]