---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/#review56492
---
Ship it!
Ship It!
- Benjamin Hindman
On Sept. 29, 2014, 9:22
:07.863620 25671 master.cpp:2968] Registering slave at
slave(48)@67.195.81.187:33243 (pomona.apache.org) with id
20141014-061007-3142697795-33243-25643-1
I1014 06:10:07.863755 25671 registrar.cpp:445] Applied 1 operations in 16652ns;
attempting to update the 'registry'
I1014 06:10:07.865200 25673
On Sept. 26, 2014, 9:47 a.m., Timothy Chen wrote:
src/master/master.cpp, line 3181
https://reviews.apache.org/r/25184/diff/2/?file=681985#file681985line3181
Period in the end of the comment.
Chengwei Yang wrote:
I'm not sure if I understand you correctly, if not please
On Oct. 9, 2014, 2:14 a.m., Adam B wrote:
3rdparty/libprocess/src/httpd.cpp, lines 32-37
https://reviews.apache.org/r/26473/diff/1/?file=716312#file716312line32
Why are you removing this here? Doesn't seem related to the abort
change. Or did you just notice that these are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26472/#review56498
---
Ship it!
Minor consistency nit, but otherwise quite shippable.
configure.ac to fix --with-sasl.
--
[...truncated 60828 lines...]
I1014 07:45:16.772703 29155 gc.cpp:56] Scheduling
'/tmp/StatusUpdateManagerTest_DuplicateTerminalUpdateAfterAck_Ptf7B0/meta/slaves/20141014-074516-3142697795-60149-29137-0/frameworks/20141014-074516
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2166/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2440/changes
On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote:
Thanks for proposing this patch Evelina.
Could you please split this into seperate patches for stout, libprocess and
mesos itself?
What do you mean by three separate patches? I suppose three different commits
...
It is not very
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2167/changes
Changes:
[adam] stout: Always use stout ABORT() rather than system abort()
[adam] libprocess: Always use stout ABORT() rather than system abort()
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26634/#review56504
---
It looks to me that adding this functionality imposes a restriction
On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote:
Thanks for proposing this patch Evelina.
Could you please split this into seperate patches for stout, libprocess and
mesos itself?
Evelina Dumitrescu wrote:
What do you mean by three separate patches? I suppose three different
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review56526
---
Ship it!
I tested locally but not to any great extent, and it
On Oct. 14, 2014, 2:21 p.m., Timothy St. Clair wrote:
I tested locally but not to any great extent, and it passed my make check.
Could you please elaborate on your testing in the review.
On second ship-it + updated test comment I'll push post haste.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56533
---
The latest diff looks broken - Thomas, mind updating it (if you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56536
---
Bad patch!
Reviews applied: [17431]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26670/#review56537
---
Ship it!
Sounds great!
- Dominic Hamon
On Oct. 13, 2014, 5:36
Thanks to both of you.
@David Idempotence (and functional style) will both mitigate the issue of
testing.
@Sharma #3 looks impressive and I hear the pain. Few questions:
* Since you already have the state machine modeling, can't the scheduler
actions also be modeled as a state machine
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56538
---
Ship it!
Ship It!
- Tobi Knaup
On Jan. 18, 2014, 1:05 a.m.,
On Oct. 14, 2014, 9:38 a.m., Tobi Knaup wrote:
Ship It!
Awesome - will land this today.
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56538
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26669/#review56539
---
docs/reconciliation.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21277/#review56549
---
LGTM but needs rebase. Would be sweet to get in: much more robust
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56551
---
Patch looks great!
Reviews applied: [17082]
All tests passed.
-
On Oct. 14, 2014, 4:02 p.m., Niklas Nielsen wrote:
The latest diff looks broken - Thomas, mind updating it (if you still want
this to go in)?
Why in the world didn't this get in. I'll fix it up =)
- Thomas
---
This is an
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2168/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26697/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26699/
---
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26700/
---
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26698/
---
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/
---
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26702/
---
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26702/#review56559
---
Patch looks great!
Reviews applied: [26697, 26698, 26699, 26700,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/
---
(Updated Oct. 14, 2014, 12:08 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/
---
(Updated Oct. 14, 2014, 7:48 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
---
(Updated Oct. 14, 2014, 1:09 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review56564
---
Bad patch!
Reviews applied: [26289]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/
---
(Updated Oct. 14, 2014, 1:31 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/
---
(Updated Oct. 14, 2014, 1:31 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/
---
(Updated Oct. 14, 2014, 1:33 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/
---
(Updated Oct. 14, 2014, 1:33 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/
---
(Updated Oct. 14, 2014, 1:34 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/
---
(Updated Oct. 14, 2014, 1:34 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
---
(Updated Oct. 14, 2014, 1:35 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review56567
---
src/linux/cgroups.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26669/#review56566
---
Ship it!
LGTM.
docs/reconciliation.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review56568
---
src/slave/containerizer/linux_launcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/#review56569
---
src/slave/containerizer/mesos/containerizer.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/#review56573
---
configure.ac
https://reviews.apache.org/r/26426/#comment96918
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/
---
(Updated Oct. 14, 2014, 9:27 p.m.)
Review request for mesos and Niklas
On Oct. 13, 2014, 9:47 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/tests/benchmarks.cpp, line 25
https://reviews.apache.org/r/26150/diff/3/?file=719696#file719696line25
This is the first time we use std::thread - do you have some references
that it is supported across our
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/
---
(Updated Oct. 14, 2014, 9:30 p.m.)
Review request for mesos and Niklas
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26580/
---
(Updated Oct. 14, 2014, 9:44 p.m.)
Review request for mesos, Benjamin Hindman
On Oct. 10, 2014, 5:15 p.m., Dominic Hamon wrote:
3rdparty/libprocess/src/process.cpp, line 1631
https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1631
this can't land until https://reviews.apache.org/r/26289/ which
contains the configure.ac check for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26709/
---
Review request for mesos.
Bugs: MESOS-1925
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26709/#review56585
---
src/docker/docker.cpp
On Oct. 14, 2014, 10:18 p.m., Timothy Chen wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
Since this method doesn't simple kill anymore, can you also refactor
the method name? Good to provide some comments as well
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review56584
---
src/tests/mesos.cpp
On Oct. 10, 2014, 6:24 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 1413
https://reviews.apache.org/r/23912/diff/8/?file=716689#file716689line1413
It is weird to me that you remove the task here but (potentially)
remove the executor up in _runTask(). It's not obvious to me
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/#review56589
---
Patch looks great!
Reviews applied: [25864, 25965]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26698/#review56583
---
src/messages/messages.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
---
(Updated Oct. 14, 2014, 10:52 p.m.)
Review request for mesos and Ross Allen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
---
(Updated Oct. 14, 2014, 10:53 p.m.)
Review request for mesos and Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
---
(Updated Oct. 14, 2014, 10:54 p.m.)
Review request for mesos, Michael Lunøe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26697/#review56593
---
Ship it!
Ship It!
- Adam B
On Oct. 14, 2014, 10:58 a.m., Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review56595
---
Bad patch!
Reviews applied: [25864, 25865]
Failed command: git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26712/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
On Oct. 10, 2014, 5:15 p.m., Dominic Hamon wrote:
3rdparty/libprocess/src/process.cpp, line 1631
https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1631
this can't land until https://reviews.apache.org/r/26289/ which
contains the configure.ac check for
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/
---
(Updated Oct. 14, 2014, 11:07 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26712/#review56600
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 14, 2014, 4:01 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26289/
---
(Updated Oct. 14, 2014, 4:29 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26709/#review56602
---
src/docker/docker.cpp
On Oct. 14, 2014, 11:39 p.m., Ankur Chauhan wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
A 30 second timeout seems pretty arbitrary. I would suggest allowing
the user to specify this as a arg. Something on the
On Oct. 14, 2014, 11:39 p.m., Ankur Chauhan wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
A 30 second timeout seems pretty arbitrary. I would suggest allowing
the user to specify this as a arg. Something on the
On Oct. 14, 2014, 11:39 p.m., Ankur Chauhan wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
A 30 second timeout seems pretty arbitrary. I would suggest allowing
the user to specify this as a arg. Something on the
On Oct. 14, 2014, 11:39 p.m., Ankur Chauhan wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
A 30 second timeout seems pretty arbitrary. I would suggest allowing
the user to specify this as a arg. Something on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review56609
---
Patch looks great!
Reviews applied: [26273, 25861, 24177, 25655,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26709/#review56611
---
src/docker/docker.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/#review56614
---
Bad patch!
Reviews applied: [26150]
Failed command:
On Oct. 15, 2014, 12:15 a.m., Timothy Chen wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
I'm not sure what executor timeout you're referring to, but for example
the executor signal escalation timeout although
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
On Oct. 15, 2014, 12:15 a.m., Timothy Chen wrote:
src/docker/docker.cpp, line 472
https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472
I'm not sure what executor timeout you're referring to, but for example
the executor signal escalation timeout although
On Oct. 15, 2014, 12:22 a.m., Ben Mahler wrote:
Looks good modulo some issues below, would like to take a final pass when
you update the APR() abstraction to be thread safe.
Hm.. have you looked at whether the other calls here are thread safe?
For example, svn_pool_create().
- Ben
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2444/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26723/
---
Review request for mesos and Adam B.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56636
---
Patch looks great!
Reviews applied: [17431]
All tests passed.
-
On Oct. 14, 2014, 11:11 p.m., Dominic Hamon wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/2/?file=721143#file721143line281
aside: you might want to consider Os for release. It'll keep the size
down and will often be as performant, even without rigourous
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26724/
---
Review request for mesos and Dominic Hamon.
Repository: mesos-git
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2170/changes
Changes:
[dhamon] Add configuration check to libprocess for std::unique_ptr and std::move
--
[...truncated 29021 lines...]
I1015 01:32:22.666582 20672
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26728/
---
Review request for mesos, Cody Maloney and Niklas Nielsen.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56642
---
Patch looks great!
Reviews applied: [26715]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/
---
(Updated Oct. 15, 2014, 10:23 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 15, 2014, 3:06 a.m.)
Review request for mesos, Adam B and Vinod
On Oct. 15, 2014, 1:25 a.m., Vinod Kone wrote:
src/master/master.hpp, line 1308
https://reviews.apache.org/r/25525/diff/8/?file=717604#file717604line1308
This should be CHECK_SOME(compatible).
True, a incompatible change shouldn't get that far because there are advance
checks, but
- Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review56590
---
On Oct. 15, 2014, 3:13 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 15, 2014, 3:13 a.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26723/#review56644
---
LGTM, but can you include some motivation here, since there's no
1 - 100 of 108 matches
Mail list logo
