Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56900 --- Patch looks great! Reviews applied: [26674] All tests passed. - M

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review56897 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

> On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote: > > support/apply-review.sh, line 20 > > > > > > Update usage? > > Cody Maloney wrote: > I was explicitly leaving it out because process wise committers should > lo

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

> On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote: > > support/apply-review.sh, line 20 > > > > > > Update usage? I was explicitly leaving it out because process wise committers should look at the diff before they commi

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/#review56894 --- Ship it! support/apply-review.sh

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/ --- (Updated Oct. 16, 2014, 5:36 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56893 --- Bad patch! Reviews applied: [26789] Failed command: git apply --in

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

> On Oct. 16, 2014, 5:01 a.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 123 > > > > > > So I'm coming from this is a shared function that is applicable for all > > paths

Re: Review Request 26794: Install mesos git helper scripts on bootstrap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26794/#review56891 --- Ship it! Ship It! - Vinod Kone On Oct. 16, 2014, 4:30 a.m., Cody

Re: Review Request 26791: Properly qualify process::Failure() in posix.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26791/#review56887 --- Patch looks great! Reviews applied: [26791] All tests passed. - M

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review56885 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 14, 2014, 9:03 p.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 26799: Added a protobuf::append function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26799/ --- (Updated Oct. 16, 2014, 4:52 a.m.) Review request for mesos and Vinod Kone. S

Review Request 26800: Added a protobuf::append test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26800/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Review Request 26799: Added a protobuf::append test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26799/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review56883 --- 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp

Re: Review Request 26794: Install mesos git helper scripts on bootstrap

> On Oct. 16, 2014, 2:41 a.m., Vinod Kone wrote: > > bootstrap, line 15 > > > > > > Are you sure this symlink works? > > > > IIRC, it had to be > > > > ln -s ../../support/hooks/pre-commit .git/hooks/p

Re: Review Request 26794: Install mesos git helper scripts on bootstrap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26794/ --- (Updated Oct. 16, 2014, 4:30 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

> On Oct. 16, 2014, 3:07 a.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 35 > > > > > > IMO calling asAbsolute("") sounds more like a bug then just returning > > "/". Prac

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 4:03 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26715/#review56880 --- Patch looks great! Reviews applied: [26715] All tests passed. - M

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/ --- (Updated Oct. 15, 2014, 11:48 p.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 26797: Added --isolation flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/ --- (Updated Oct. 15, 2014, 11:48 p.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/ --- (Updated Oct. 15, 2014, 11:46 p.m.) Review request for mesos, Niklas Nielsen an

Review Request 26797: Added --isolation flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos-

Re: Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/ --- (Updated Oct. 15, 2014, 11:45 p.m.) Review request for mesos and Niklas Nielsen

Re: Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/ --- (Updated Oct. 15, 2014, 11:45 p.m.) Review request for mesos and Niklas Nielsen

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review56865 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review56876 --- Patch looks great! Reviews applied: [26476] All tests passed. - M

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

> On Oct. 16, 2014, 2:50 a.m., Cody Maloney wrote: > > Bad patch! > > > > Reviews applied: [25525] > > > > Failed command: ['./support/appy-review.sh', '-r', '25525'] > > > > Error: > > -r: ./support/appy-review.sh: No such file or directory Ignore this. I was testing out some changes to the

Re: Review Request 25549: Basic filesystem isolator for Linux.

> On Oct. 16, 2014, 2:48 a.m., Cody Maloney wrote: > > Bad patch! > > > > Reviews applied: [26273] > > > > Failed command: ['./appy-review.sh', '-r', '26273'] > > > > Error: > > -r: ./appy-review.sh: No such file or directory Ignore this. I was testing out some changes to the review checking

Re: Review Request 26727: Hooked Isolator module to mesos containerizer.

> On Oct. 16, 2014, 2:50 a.m., Cody Maloney wrote: > > Bad patch! > > > > Reviews applied: [26727] > > > > Failed command: ['./support/appy-review.sh', '-r', '26727'] > > > > Error: > > -r: ./support/appy-review.sh: No such file or directory Ignore this. I was testing out some changes to the

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review56872 --- Bad patch! Reviews applied: [25525] Failed command: ['./support/ap

Re: Review Request 26727: Hooked Isolator module to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/#review56871 --- Bad patch! Reviews applied: [26727] Failed command: ['./support/ap

Re: Review Request 25549: Basic filesystem isolator for Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review56870 --- Bad patch! Reviews applied: [26273] Failed command: ['./appy-revie

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Descriptio

Re: Review Request 26794: Install mesos git helper scripts on bootstrap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26794/#review56867 --- bootstrap A

Review Request 26794: Install mesos git helper scripts on bootstrap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26794/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1932 https://issues.ap

Re: Review Request 26723: Escape JSON object keys

> On Oct. 16, 2014, 1:32 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 377 > > > > > > It looks like this could have been a one line change..? > > > > ``` > >

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56862 --- Bad patch! Reviews applied: [26509] Failed command: git apply --in

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/ --- (Updated Oct. 15, 2014, 9:57 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 26229: Expose poll interval from the reaper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review56860 --- Ship it! Will commit this shortly. 3rdparty/libprocess/src/reap.c

Re: Review Request 26783: Fix race condition in Latch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26783/#review56858 --- Patch looks great! Reviews applied: [26783] All tests passed. - M

Re: Review Request 26071: Sample isolator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 9:38 p.m.) Review request for mesos, Bernd Mathiske, Ia

Re: Review Request 26723: Escape JSON object keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/#review56857 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 15, 2014, 9:19 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26791: Properly qualify process::Failure() in posix.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26791/#review56852 --- Ship it! Ship It! - Niklas Nielsen On Oct. 15, 2014, 6:03 p.m.,

Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26715/ --- (Updated Oct. 16, 2014, 1:09 a.m.) Review request for mesos, Ben Mahler and Vin

Review Request 26791: Properly qualify process::Failure() in posix.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26791/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Descriptio

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56850 --- LGTM module my comments src/module/manager.cpp

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:41 a.m.) Review request for mesos and Niklas Nielsen

Re: Review Request 26702: Updated reconciliation semantics to take the task's unacknowledged state into account.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/#review56849 --- Bad patch! Reviews applied: [26697, 26698, 26699, 26700, 26701] Fa

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

> On Oct. 16, 2014, 12:26 a.m., Vinod Kone wrote: > > Hey Thomas. Can you add more description on what the bug is and what the > > fix is here? Also, please assign it to a reviewer (me?). Yup, let me add some more context =) - Thomas -

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:35 a.m.) Review request for mesos. Repository: mes

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:29 a.m.) Review request for mesos. Repository: mes

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/#review56847 --- Hey Thomas. Can you add more description on what the bug is and what

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review56846 --- A few higher level questions: (1) What motivated this? Concretely,

Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

> On Oct. 15, 2014, 5:55 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 288 > > > > > > shouldn't this be a hex value? > > > > also, why are the hex values different

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 15, 2014, 8:18 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26775: Added module loading support for local clusters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775/#review56844 --- Patch looks great! Reviews applied: [26775] All tests passed. - M

Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos-

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 15, 2014, 11:51 p.m.) Review request for mesos. Repository: mes

Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 15, 2014, 11:50 p.m.) Review request for mesos. Summary (update

Review Request 26788: Added DISTRIBUTE_EGG reference so that protobuf egg can be built locally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- Review request for mesos. Repository: mesos-git Description --- Added DI

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/ --- (Updated Oct. 15, 2014, 7:34 p.m.) Review request for mesos, Benjamin Hindman a

Re: updating website copy

Bump. :) I would also like to see the "Features" list updated: -Slaves in mesos are fault tolerant as well. (we only say the master is fault tolerant in the copy). -Should we highlight Docker support? -Containerization and Isolation are now flexible and pluggable. -Resource monitoring. -We're als

Re: Review Request 26150: Libprocess Benchmark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review56839 --- Bad patch! Reviews applied: [26150] Failed command: ./support/meso

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review56833 --- Bad patch! Reviews applied: [26736] Failed command: git apply --in

Re: Review Request 25966: Use pid namespace in LinuxLauncher::destroy().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25966/ --- (Updated Oct. 15, 2014, 3:37 p.m.) Review request for mesos, Jie Yu and Vinod K

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review56832 --- Patch looks great! Reviews applied: [25525] All tests passed. - M

Re: Review Request 26727: Hooked Isolator module to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/#review56831 --- Let's add a test too that use one of the test isolator modules to ru

Re: Review Request 26727: Hooked Isolator module to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/ --- (Updated Oct. 15, 2014, 3:08 p.m.) Review request for mesos, Ian Downes and Nik

Review Request 26783: Fix race condition in Latch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26783/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: meso

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56825 --- Ship it! Ship It! - Niklas Nielsen On Oct. 12, 2014, 1:11 p.m.,

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56822 --- src/master/flags.hpp

Re: Review Request 25549: Basic filesystem isolator for Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review56823 --- Ship it! Ship It! - Timothy Chen On Oct. 15, 2014, 7:25 p.m., Ia

Re: Review Request 26669: Added a document for reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26669/#review56818 --- docs/reconciliation.md

Re: Review Request 26578: Memory cleanup: libprocess gc finalize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26578/ --- (Updated Oct. 15, 2014, 9:37 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 26702: Updated reconciliation semantics to take the task's unacknowledged state into account.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/ --- (Updated Oct. 15, 2014, 9:32 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 26702: Updated reconciliation semantics to take the task's unacknowledged state into account.

> On Oct. 15, 2014, 7:41 a.m., Adam B wrote: > > src/master/master.cpp, lines 3920-3927 > > > > > > Should reconciliation on slave reregistration return to the slave each > > task's latest state, or its latest unackn

Re: Review Request 26701: Updated master to update task unacknowledged state properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26701/ --- (Updated Oct. 15, 2014, 9:32 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 26701: Updated master to update task unacknowledged state properly.

> On Oct. 15, 2014, 7:23 a.m., Adam B wrote: > > src/master/master.cpp, line 2826 > > > > > > When would the uuids ever be different? If the scheduler re-acked a > > previous terminal update when the master expected

Re: Review Request 26700: Updated StatusUpdateManager to send latest task state in update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26700/ --- (Updated Oct. 15, 2014, 9:30 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 26700: Updated StatusUpdateManager to send latest task state in update.

> On Oct. 15, 2014, 4:52 a.m., Adam B wrote: > > I like the direction this is going. Our internal bandaid fix set the > > latest/terminal_state in stream->next instead of forward(), but I don't > > think it makes much of a difference. A few questions: > > - Where does the uuid come into play? >

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/ --- (Updated Oct. 15, 2014, 9:29 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- (Updated Oct. 15, 2014, 9:29 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 6:26 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 1014 > > > > > > What are your guarantees that task_id() is in the states map? Maybe > > guard it? it is inside a "if states contain

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 4:03 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 25966: Use pid namespace in LinuxLauncher::destroy().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25966/#review56815 --- Bad patch! Reviews applied: [25864, 25864] Failed command: git app

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26698/ --- (Updated Oct. 15, 2014, 9:27 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

> On Oct. 15, 2014, 6:17 p.m., Niklas Nielsen wrote: > > src/slave/status_update_manager.cpp, lines 292-293 > > > > > > Can you use stream->next() instead ? done. - Vinod --

Re: Review Request 26697: Added StartSlave() overload that takes status update manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26697/#review56814 --- Ship it! Ship It! - Ben Mahler On Oct. 15, 2014, 9:26 p.m., Vino

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

> On Oct. 14, 2014, 10:51 p.m., Adam B wrote: > > src/messages/messages.proto, line 45 > > > > > > Maybe 'unacknowledged_status' would be more accurate, since the uuid is > > associated with the StatusUpdate message it

Re: Review Request 26697: Added StartSlave() overload that takes status update manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26697/ --- (Updated Oct. 15, 2014, 9:26 p.m.) Review request for mesos and Ben Mahler. C

Review Request 26775: Added module loading support for local clusters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775/ --- Review request for mesos, Kapil Arya and Niklas Nielsen. Bugs: MESOS-1927 h

Re: Review Request 25549: Basic filesystem isolator for Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review56810 --- Patch looks great! Reviews applied: [26273, 25861, 24177, 25655, 25

Large changes on the codebase due to MESOS-1872

Hi, When I picked this issue, I didn't thought that the code changes will raise this kind of problems. :)) Therefore, I share the same opinion: we should be aware of this for the further commits and adapt the coding style step by step to the C++11 standard. Also, I think that Github doesn't us

Re: Review Request 26578: Memory cleanup: libprocess gc finalize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26578/#review56803 --- 3rdparty/libprocess/include/process/gc.hpp

  1   2   >