Re: Review Request 26861: Schedule docker containers for removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/#review57112 --- Patch looks great! Reviews applied: [26610, 26861] All tests

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/ --- (Updated Oct. 17, 2014, 2:11 a.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review57113 --- Bad patch! Reviews applied: [26610, 26861, 26862] Failed command:

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 17, 2014, 6:53 a.m.) Review request for mesos and Benjamin

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57120 --- Patch looks great! Reviews applied: [26855] All tests passed. -

Re: Review Request 26767: MESOS-1878: Fix files/files.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26767/#review57121 --- src/files/files.cpp

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review57122 --- Patch looks great! Reviews applied: [26610, 26861, 26862] All

how to debug task lost in custom scheduler?

added debug logs in a file to check, and no file is created), but I see no error in master logs (console) nor slave logs. In master I can see: I1017 16:50:30.601210 25794 master.cpp:3559] Sending 1 offers to framework 20141017-141022-16777343-5050-25774-0047 I1017 16:50:30.608912 25789 master.cpp

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

On Oct. 10, 2014, 11:24 a.m., Vinod Kone wrote: src/slave/slave.cpp, line 1413 https://reviews.apache.org/r/23912/diff/8/?file=716689#file716689line1413 It is weird to me that you remove the task here but (potentially) remove the executor up in _runTask(). It's not obvious to me

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/ --- (Updated Oct. 17, 2014, 9:25 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/#review57159 --- Bad patch! Reviews applied: [23912] Failed command:

Re: Review Request 26382: Add source and reason to TaskStatus.

On Oct. 16, 2014, 1:44 p.m., Alexander Rukletsov wrote: src/examples/balloon_framework.cpp, line 134 https://reviews.apache.org/r/26382/diff/2/?file=723169#file723169line134 You say it's reason, but output message. Is it on purpose? I changed the output from 'Reason' to 'Message'

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 17, 2014, 10:07 a.m.) Review request for mesos, Vinod Kone and

Review Request 26879: Fixed a file descriptor leak in StatusUpdateManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26879/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1858

Re: Review Request 26879: Fixed a file descriptor leak in StatusUpdateManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26879/#review57169 --- Ship it! Ship It! - Vinod Kone On Oct. 17, 2014, 5:21 p.m., Jie

Re: how to debug task lost in custom scheduler?

. In master I can see: I1017 16:50:30.601210 25794 master.cpp:3559] Sending 1 offers to framework 20141017-141022-16777343-5050-25774-0047 I1017 16:50:30.608912 25789 master.cpp:2169] Processing reply for offers: [ 20141017-141022-16777343-5050-25774-97 ] on slave 20141017-141022-16777343-5050-25774-0

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/#review57172 --- Ship it! Ship It! - Vinod Kone On Oct. 17, 2014, 4:25 p.m.,

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

On Oct. 17, 2014, 5:39 p.m., Vinod Kone wrote: Ship It! I committed this after some minor fixes. Thanks Bernd! - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/#review57172

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review57176 --- Patch looks great! Reviews applied: [26817, 26382] All tests

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

On Oct. 7, 2014, 11:54 a.m., Jie Yu wrote: src/slave/containerizer/mesos/containerizer.cpp, lines 991-1002 https://reviews.apache.org/r/25861/diff/2/?file=711202#file711202line991 Can you use f.onAny here so that you don't need to change the signature of `___destroy`? Appears to

Re: Review Request 26846: Updated status update manager to forward updates via slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26846/#review57168 --- Looks great! Main two comments from below are: (1) Could we now

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57166 --- src/tests/module_tests.hpp

Re: Review Request 26783: Fix race condition in Latch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26783/#review57188 --- Hey Joris, Can you file a JIRA ticket on the issue? Also, do you

Re: Review Request 26797: Added --isolation flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/#review57189 --- Are you sure this will work? Try take a look at:

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/#review57185 --- Looks good, mainly just comments about adding more comments for

Re: Review Request 26775: Added module loading support for local clusters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775/#review57192 --- Looks like you changed more than just loading flags (hoisting flags

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57193 --- Mind referring to the JIRA ticket? :) - Niklas Nielsen On Oct.

Re: Review Request 26700: Updated Slave to send latest task state in update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26700/#review57198 --- Flying by. src/slave/slave.cpp

Re: Review Request 26817: Split authorization from task validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/#review57190 --- src/master/master.hpp

Re: Review Request 26861: Schedule docker containers for removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/ --- (Updated Oct. 17, 2014, 7:32 p.m.) Review request for mesos and Benjamin

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 17, 2014, 7:33 p.m.) Review request for mesos and Benjamin

Re: Review Request 26817: Split authorization from task validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/ --- (Updated Oct. 17, 2014, 7:53 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 26486: Fix containerizer not receiving destroy/update calls when launching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26486/ --- (Updated Oct. 17, 2014, 7:55 p.m.) Review request for mesos and Benjamin

Re: Review Request 26486: Fix containerizer not receiving destroy/update calls when launching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26486/ --- (Updated Oct. 17, 2014, 7:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 26817: Split authorization from task validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/#review57202 --- Hm.. could you please split the code movement out into a separate

Re: Review Request 26817: Split authorization from task validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/ --- (Updated Oct. 17, 2014, 1:09 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 26817: Split authorization from task validation.

On Oct. 17, 2014, 12:29 p.m., Vinod Kone wrote: src/master/master.cpp, lines 2358-2361 https://reviews.apache.org/r/26817/diff/1/?file=723143#file723143line2358 We should only proceed with authorization if validations succeeded. Otherwise there is no point. Also, it

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review57208 --- Patch looks great! Reviews applied: [26610, 26861, 26862] All

Re: Review Request 26817: Split authorization from task validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/ --- (Updated Oct. 17, 2014, 1:46 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 17, 2014, 1:55 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 26766: MESOS-1878: Add additional helper functions to stout/path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/#review57213 --- Hey Cody, just took a quick look at this, had a few high level

Re: Review Request 26486: Fix containerizer not receiving destroy/update calls when launching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26486/#review57218 --- Patch looks great! Reviews applied: [26486] All tests passed. -

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [26736] Failed command: git apply --index 26736.patch Error: error: patch failed: src/docker/docker.cpp:472 error: src/docker/docker.cpp: patch does not apply error: patch failed:

Re: Review Request 26700: Updated Slave to send latest task state in update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26700/#review57219 --- Ship it! src/messages/messages.proto

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review57226 --- Bad patch! Reviews applied: [26817, 26382] Failed command:

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/ --- (Updated Oct. 17, 2014, 5:45 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [26736] Failed command: git apply --index 26736.patch Error: error: patch failed: src/docker/docker.cpp:472 error: src/docker/docker.cpp: patch does not apply error: patch failed:

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/ --- (Updated Oct. 17, 2014, 9:55 p.m.) Review request for mesos. Changes ---

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [26736] Failed command: git apply --index 26736.patch Error: error: patch failed: src/docker/docker.cpp:472 error: src/docker/docker.cpp: patch does not apply error: patch failed:

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57234 --- Patch looks great! Reviews applied: [26855] All tests passed. -

Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1359

Review Request 26896: Add privileged option to docker info

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26896/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Review Request 26897: Support lxc configurations in docker info

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26897/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Review Request 26898: Add hostname option to docker info

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 17, 2014, 10:57 p.m.) Review request for mesos and Benjamin

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review57237 --- Bad patch! Reviews applied: [26736] Failed command:

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

On Oct. 17, 2014, 11:02 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [26736] Failed command: ./support/apply-review.sh -n -r 26736 Error: --2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)...

Re: Review Request 26436: Avoid docker inspect on each usage call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/ --- (Updated Oct. 17, 2014, 11:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

On Oct. 17, 2014, 11:02 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [26736] Failed command: ./support/apply-review.sh -n -r 26736 Error: --2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)...

Re: updating website copy

I updated this language and also added a few of the features Ben Mahler mentioned; feedback welcome. http://mesos.apache.org There is a lot to be desired for in terms of design; patches are welcome! The website source for folks that do not already know is available here:

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review57250 --- Patch looks great! Reviews applied: [26894] All tests passed. -

Re: Review Request 26214: Add apr and svn to configure.ac

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/ --- (Updated Oct. 18, 2014, 12:12 a.m.) Review request for mesos and Benjamin

Review Request 26903: Added functions to manipulate LD_LIBRARY_PATH to os::libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26903/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository:

Review Request 26904: Replace ModuleManager::expandLibraryName with os::libraries::expandName.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26904/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository:

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/ --- (Updated Oct. 17, 2014, 8:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26436: Avoid docker inspect on each usage call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review57257 --- Patch looks great! Reviews applied: [26610, 26861, 26862, 26896,

Re: Review Request 26214: Add apr and svn to configure.ac

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/#review57258 --- Bad patch! Reviews applied: [24535, 24536] Failed command:

Review Request 26906: Check kind before creating a module instance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26906/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository:

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57260 --- Patch looks great! Reviews applied: [26903, 26904, 26855] All

Re: Review Request 26906: Check kind before creating a module instance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26906/#review57261 --- Patch looks great! Reviews applied: [26903, 26904, 26855, 26906]

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/ --- (Updated Oct. 18, 2014, 3:51 a.m.) Review request for mesos. Changes ---

Re: Review Request 26622: Command Executor is broken when used with shell=false

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/ --- (Updated Oct. 17, 2014, 11:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review57262 --- Patch looks great! Reviews applied: [26736] All tests passed. -

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/ --- (Updated Oct. 18, 2014, 4:59 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

On Oct. 15, 2014, 7:06 p.m., Ben Mahler wrote: src/state/log.cpp, lines 364-369 https://reviews.apache.org/r/24536/diff/4/?file=719263#file719263line364 This appears to be incorrect: Say we have 2 Snapshots: A: (diff=0, position=11) B: (diff=3, position=10)