> On Oct. 7, 2014, 11:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 991-1002 > > <https://reviews.apache.org/r/25861/diff/2/?file=711202#file711202line991> > > > > Can you use f.onAny here so that you don't need to change the signature > > of `___destroy`?
Appears to be necessary for the compiler to correctly infer the types. > On Oct. 7, 2014, 11:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 969 > > <https://reviews.apache.org/r/25861/diff/2/?file=711202#file711202line969> > > > > What's the purpose of that? Appears to be necessary for the compiler to correctly infer the types. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review55674 ----------------------------------------------------------- On Oct. 14, 2014, 1:34 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25861/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 1:34 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Change from doing in parallel and collect()ing to serial according to the > vector of isolators (reversed order for cleanup). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > bf246ca649ca4a461cebf1aee6908a2d58eec362 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > > Diff: https://reviews.apache.org/r/25861/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
