Re: Review Request 28387: stout: Create IP address abstraction

2014-11-25 Thread Benjamin Hindman
> On Nov. 24, 2014, 5:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp, line 14 > > > > > > Flying by. Do not have context. Is the plan to replace the existing > > "IP" in stout

Re: Review Request 28415: Add tests for socket interface.

2014-11-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63016 --- 3rdparty/libprocess/src/tests/socket_tests.cpp

Re: Review Request 28322: Introduce libevent clock implementation.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/ --- (Updated Nov. 26, 2014, 5:34 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28323: Introduce libevent poll implementation.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/ --- (Updated Nov. 26, 2014, 5:34 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28321: Introduce libevent header and implementation.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28321/ --- (Updated Nov. 26, 2014, 5:34 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28320: Add multiple include guard to libev.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28320/ --- (Updated Nov. 26, 2014, 5:34 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28317: Move libev specific parts of clock into libev_clock.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28317/ --- (Updated Nov. 26, 2014, 5:33 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/ --- (Updated Nov. 26, 2014, 5:34 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28318: Move last references of libev out of process.cpp.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28318/ --- (Updated Nov. 26, 2014, 5:33 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28316: Reorganize clock event callback functions.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28316/ --- (Updated Nov. 26, 2014, 5:32 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 28315: Refactor clock to simplify libev cut.

2014-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/ --- (Updated Nov. 26, 2014, 5:31 a.m.) Review request for mesos, Benjamin Hindman a

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2319

2014-11-25 Thread Apache Jenkins Server
See Changes: [vinodkone] Removed some DiskInfo validations from C++ Resources in favor of doing -- [...truncated 73640 lines...] I1126 02:37:28.341378 27130 replic

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2597

2014-11-25 Thread Apache Jenkins Server
See Changes: [vinodkone] Removed some DiskInfo validations from C++ Resources in favor of doing -- [...truncated 67880 lines...] I1

Re: Review Request 28387: stout: Create IP address abstraction

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp, line 14 > > > > > > Flying by. Do not have context. Is the plan to replace the existing > > "IP" in stout

Re: Review Request 28387: stout: Create IP address abstraction

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp, line 14 > > > > > > Flying by. Do not have context. Is the plan to replace the existing > > "IP" in stout

Re: Review Request 28387: stout: Create IP address abstraction

2014-11-25 Thread Benjamin Hindman
> On Nov. 24, 2014, 5:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp, line 14 > > > > > > Flying by. Do not have context. Is the plan to replace the existing > > "IP" in stout

Re: [proposal] Module extension: hooks

2014-11-25 Thread Niklas Nielsen
Hi again, (Sorry for the copy paste, but the discussion has been going on in both JIRA and this thread) Just had a chat with BenH and Kapil, and think that we came up with a safer solution which would fit our needs (at the cost of some general flexibility). Here is the idea; instead of thinking

Re: Review Request 28429: Removed a few DiskInfo validation from C++ Resources.

2014-11-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28429/#review63084 --- I'm committing this since I want this for one of my reviews. - Vino

Re: Using mesos to manage windows processes?

2014-11-25 Thread Ian Downes
Windows isn't POSIX (but has some UNIX interoperability library in Server) so you can't run Mesos directly on Windows. I believe what Tim and Niklas are suggesting is to run Mesos on Linux and use VMs to run Windows. Just wanted to make sure that was clear On Tue, Nov 25, 2014 at 2:31 PM, Niklas N

Re: Review Request 28444: Expanded labels comment in mesos.proto.

2014-11-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28444/#review63076 --- Ship it! include/mesos/mesos.proto

Re: Review Request 28387: stout: Create IP address abstraction

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp, line 14 > > > > > > Flying by. Do not have context. Is the plan to replace the existing > > "IP" in stout

Re: Review Request 28383: stout: Introduce SockaddrStorage structure for dealing with sockets of different families

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 6:05 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 67 > > > > > > How about calling it SocketAddress so that it's consistent with > > IPAddress? thanks for

Re: Review Request 28386: Create IP address abstraction

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:34 p.m., Dominic Hamon wrote: > > src/common/protobuf_utils.cpp, line 123 > > > > > > oof, this seems clumsy. how will it extend to IPv6? do we need to > > define a protobuf IPAddress soon? A Ma

Re: Review Request 28386: Create IP address abstraction

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:34 p.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2519 > > > > > > Please add methods to IPAddress to return the sockaddr (or even the > > net::I

Re: [proposal] Module extension: hooks

2014-11-25 Thread Niklas Nielsen
On 24 November 2014 at 12:24, Vinod Kone wrote: > On Fri, Nov 21, 2014 at 4:56 PM, Niklas Nielsen > wrote: > > > That aside, our use-case involves hanging meta-data off the task with > > labels which we cannot do with an event stream alone. > > The metadata we need is produced by a 3rd party sec

Re: [proposal] Module extension: hooks

2014-11-25 Thread Niklas Nielsen
On 22 November 2014 at 11:02, Alex Rukletsov wrote: > I like the idea of a cluster event stream very much! With this feature > implemented, we will be able to gather cluster health status, various > statistics for on-the-fly or offline analysis. AFAIK, the only way to > gather some stats now is t

Re: Review Request 28388: libprocess: Create IP address abstraction

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:36 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/pid.cpp, line 145 > > > > > > probably should be some way to set the ip address which checks the > > family of the incoming in_addr and s

Re: Review Request 28384: libprocess: Introduce SockaddrStorage structure for dealing with sockets of different families

2014-11-25 Thread Evelina Dumitrescu
> On Nov. 24, 2014, 5:21 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 1277 > > > > > > how are you going to extend this to IPv6? the family field from IPAddress(see Node) and the sa_family

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2318

2014-11-25 Thread Apache Jenkins Server
See

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2596

2014-11-25 Thread Apache Jenkins Server
on (18 bytes) to leveldb took 299193ns I1125 22:41:00.492799 15420 sched.cpp:1364] Asked to stop the driver I1125 22:41:00.492838 15420 sched.cpp:1364] Asked to stop the driver I1125 22:41:00.492846 15442 sched.cpp:805] Stopping framework '20141125-224100-3193029443-33268-15420-0002' I1125

Re: Review Request 28401: Introduced Hooks API for Master

2014-11-25 Thread Niklas Nielsen
> On Nov. 24, 2014, 12:28 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 2485-2493 > > > > > > Modifying the task, framework and slave this late in the launch cyle is > > dangerous. > > > > What is

Re: Using mesos to manage windows processes?

2014-11-25 Thread Niklas Nielsen
We landed isolator and authenticator modules to start with and containerizer modules should be a relatively easy task to do. It has not been a priority for us yet to get those in before the end of the year, but would be happy to assist if anyone is willing to take this on. It will look much like t

RE: Using mesos to manage windows processes?

2014-11-25 Thread Jonathan Dietrich
Do you know where I can learn more about the " containerizer module" and when it is intended to land? Thanks. JCD -Original Message- From: Niklas Nielsen [mailto:nik...@mesosphere.io] Sent: November-25-14 4:44 PM To: dev Subject: Re: Using mesos to manage windows processes? You should

Re: Using mesos to manage windows processes?

2014-11-25 Thread Niklas Nielsen
You should be able to use the external containerizer API to do this (Say with KVM), or you can wait until containerizer module land and do it natively. Niklas On 25 November 2014 at 13:32, Timothy Chen wrote: > The latter would be much easier to do comparing to try to run > mesos-slave on windo

Re: Using mesos to manage windows processes?

2014-11-25 Thread Timothy Chen
The latter would be much easier to do comparing to try to run mesos-slave on windows. Tim On Tue, Nov 25, 2014 at 1:26 PM, Jonathan Dietrich wrote: > I would like to be able to manage my apps in my heterogeneous environment > using mesos. > > Was wondering if anyone has looked at getting mesos-

Using mesos to manage windows processes?

2014-11-25 Thread Jonathan Dietrich
I would like to be able to manage my apps in my heterogeneous environment using mesos. Was wondering if anyone has looked at getting mesos-slave running on windows? I realize at least a new Containerizer would be needed. I'm thinking to start I would just use windows processes. (no real isolati

Re: Review Request 28442: Updated WhitelistWatcher to watch only if a file is given.

2014-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28442/#review63033 --- Patch looks great! Reviews applied: [28442] All tests passed. - M

Re: Review Request 28444: Expanded labels comment in mesos.proto.

2014-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28444/#review63022 --- Patch looks great! Reviews applied: [28444] All tests passed. - M

Re: Review Request 14286: Added /master/slaves and /master/frameworks/{framework}/tasks/{task} endpoints.

2014-11-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14286/ --- (Updated Nov. 25, 2014, 11:13 a.m.) Review request for mesos, Ben Mahler and Ro

Re: Review Request 28442: Updated WhitelistWatcher to watch only if a file is given.

2014-11-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28442/#review63020 --- Ship it! Ship It! - Niklas Nielsen On Nov. 25, 2014, 10:55 a.m.,

Re: Review Request 28415: Add tests for socket interface.

2014-11-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63015 --- 3rdparty/libprocess/src/tests/socket_tests.cpp

Re: Review Request 28442: Updated WhitelistWatcher to watch only if a file is given.

2014-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28442/ --- (Updated Nov. 25, 2014, 6:55 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 28444: Expanded labels comment in mesos.proto.

2014-11-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28444/ --- Review request for mesos. Repository: mesos-git Description --- See summ

Re: Review Request 28444: Expanded labels comment in mesos.proto.

2014-11-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28444/ --- (Updated Nov. 25, 2014, 10:27 a.m.) Review request for mesos, Ben Mahler and Ti

Re: Review Request 28442: Updated WhitelistWatcher to watch only if a file is given.

2014-11-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28442/#review63011 --- Ship it! src/watcher/whitelist_watcher.cpp

Re: Review Request 28442: Updated WhitelistWatcher to watch only if a file is given.

2014-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28442/#review63001 --- Patch looks great! Reviews applied: [28442] All tests passed. - M

Review Request 28442: Updated WhitelistWatcher to watch only if a file is given.

2014-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28442/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas Nielsen.