Re: Using mesos to manage windows processes?

2014-11-26 Thread Jonathan Dietrich
It is understood, thanks. From: Ian Downes Sent: 25 November 2014 18:53 To: dev@mesos.apache.org Subject: Re: Using mesos to manage windows processes? Windows isn't POSIX (but has some UNIX interoperability library in Server) so you can't run Mesos direct

Re: Review Request 28415: Add tests for socket interface.

2014-11-26 Thread Joris Van Remoortere
> On Nov. 25, 2014, 7:06 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/socket_tests.cpp, lines 94-100 > > > > > > Can you use the Socket.connect() call? If not, why? In order to build up confidence in t

Re: Review Request 28415: Add tests for socket interface.

2014-11-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/ --- (Updated Nov. 26, 2014, 10:50 p.m.) Review request for mesos, Benjamin Hindman

Review Request 28484: Rename Socket read to recv. This is more consistent: send/recv vs. send/read.

2014-11-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28484/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: meso

Review Request 28485: Provide a default bind() in Socket: any port localhost.

2014-11-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28485/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: meso

Re: Review Request 28415: Add tests for socket interface.

2014-11-26 Thread Joris Van Remoortere
> On Nov. 25, 2014, 7:06 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/socket_tests.cpp, line 79 > > > > > > This defaults to? Localhost? Added an overload for bind in r28485 that makes this pattern mor

Re: Review Request 28415: Add tests for socket interface.

2014-11-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63158 --- Patch looks great! Reviews applied: [28484, 28485, 28415] All test

Re: Review Request 28485: Provide a default bind() in Socket: any port localhost.

2014-11-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28485/#review63178 --- Ship it! 3rdparty/libprocess/include/process/node.hpp

Re: Review Request 28484: Rename Socket read to recv. This is more consistent: send/recv vs. send/read.

2014-11-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28484/#review63179 --- Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 28415: Add tests for socket interface.

2014-11-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63180 --- 3rdparty/libprocess/src/tests/socket_tests.cpp