Re: Review Request 32150: Enable the master to handle reservation operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review76837 --- src/master/master.cpp

Re: Review Request 29748: Added tests for phase 1 of dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review76762 --- Great job wiring up tests! I've left some comments, some of them are

Re: Review Request 32149: Enable 'Resources::apply' to handle reservation operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review76859 --- LGTM. - Alexander Rukletsov On March 17, 2015, 4:06 a.m., Michael

Re: Review Request 32139: Add 'Resource::ReservationInfo' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review76764 --- include/mesos/mesos.proto

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review76752 --- src/common/resources.cpp

Re: Review Request 32180: Updated scheduler Event/Call protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32180/#review76857 --- Patch looks great! Reviews applied: [32179, 32180] All tests passe

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review76846 --- Patch looks great! Reviews applied: [31439, 31440, 31441, 31442, 31

Re: Docker labels lands

Mesos 0.22 will also support task labels https://issues.apache.org/jira/browse/MESOS-2120 These could easily be tied to docker image/container labels as those are launched as Mesos tasks. This is in addition to the existing slave --attributes. On Tue, Mar 17, 2015 at 7:21 AM, haosdent wrote: > H

Re: Review Request 31324: Updated changelog for 0.22.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31324/ --- (Updated March 17, 2015, 4:11 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 32180: Updated scheduler Event/Call protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32180/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Isabel Jimenez. Bug

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/ --- (Updated March 17, 2015, 3:44 p.m.) Review request for mesos, Chi Zhang, Domini

Review Request 32179: Deleted intermediate Call/Event based scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32179/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1127

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/#review76833 --- Patch looks great! Reviews applied: [32130] All tests passed. - M

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/ --- (Updated March 17, 2015, 10:36 p.m.) Review request for mesos, Niklas Nielsen a

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/#review76830 --- Ship it! modulo nik's comments. - Vinod Kone On March 17, 2015,

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/#review76829 --- Ship it! src/slave/slave.hpp

Re: Review Request 31028: Added slave run task hook tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review76826 --- Ship it! src/examples/test_hook_module.cpp

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/ --- (Updated March 17, 2015, 9:54 p.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/ --- (Updated March 17, 2015, 9:50 p.m.) Review request for mesos, Niklas Nielsen an

Jenkins build is back to normal : mesos-reviewbot #4653

See

Re: Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review76820 --- Patch looks great! Reviews applied: [26147] All tests passed. - M

Re: Review Request 30962: Enabled environment decorator to override.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review76819 --- Ship it! src/examples/test_hook_module.cpp

Re: Review Request 30961: Enabled label decorator to override.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review76816 --- Ship it! src/examples/test_hook_module.cpp

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32152/ --- (Updated March 17, 2015, 9:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32151: Add MESOS_{MAJOR|MINOR|PATCH}_VERSION to libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32151/ --- (Updated March 17, 2015, 9:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/#review76814 --- Ship it! Ship It! - Kapil Arya On March 13, 2015, 5:49 p.m., Ale

Re: Review Request 31262: Moved allocator actions before TestAllocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31262/#review76811 --- SGTM minus the following change in the description: s/before the are

Re: Review Request 31267: Added a test allocator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/#review76810 --- Ship it! LGTM minus the issue below. src/examples/test_allocator_

Re: Review Request 31266: Added support for allocator modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31266/#review76808 --- Ship it! Ship It! - Kapil Arya On March 13, 2015, 5:44 p.m., Ale

Re: Build failed in Jenkins: mesos-reviewbot #4651

Newly added 'cloud-slave' jenkin nodes do not seem to have the prereqs to build mesos. Adjusted the job label to not land on them. On Tue, Mar 17, 2015 at 12:56 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > --

Re: Review Request 31776: Moved allocator to public headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/#review76805 --- Ship it! The review looks good to me. However I have added one issu

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/#review76801 --- Ship it! Ship It! - Kapil Arya On March 13, 2015, 3:30 p.m., Ale

Build failed in Jenkins: mesos-reviewbot #4652

See -- [...truncated 305 lines...] Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'sr

Re: Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- (Updated March 17, 2015, 8:02 p.m.) Review request for mesos, Benjamin Hindman,

Build failed in Jenkins: mesos-reviewbot #4651

See -- [...truncated 261 lines...] Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'sr

Re: Review Request 32133: Refactor port isolator tests to break out helper functions for testing of bandwidth limit statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32133/#review76785 --- src/tests/port_mapping_tests.cpp

Re: Review Request 31503: Add classid to Filter

> On March 12, 2015, 2:02 a.m., Jie Yu wrote: > > Cong, I addressed the comments for you and try to commit. Looks like > > rtnl_u32_get_classid is not in libnl-3.2.25. That means we need a newer > > version of libnl for this to work! > > Cong Wang wrote: > I have addressed your comments lo

Re: Review Request 31503: Add classid to Filter

> On March 11, 2015, 7:02 p.m., Jie Yu wrote: > > Cong, I addressed the comments for you and try to commit. Looks like > > rtnl_u32_get_classid is not in libnl-3.2.25. That means we need a newer > > version of libnl for this to work! > > Cong Wang wrote: > I have addressed your comments lo

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review76770 --- include/mesos/mesos.proto

Re: Review Request 31503: Add classid to Filter

> On March 12, 2015, 2:02 a.m., Jie Yu wrote: > > Cong, I addressed the comments for you and try to commit. Looks like > > rtnl_u32_get_classid is not in libnl-3.2.25. That means we need a newer > > version of libnl for this to work! > > Cong Wang wrote: > I have addressed your comments lo

Re: Review Request 32123: Fix destroying containerizer during isolator prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32123/#review76757 --- src/slave/containerizer/mesos/containerizer.hpp

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

> On March 17, 2015, 5:59 p.m., Vinod Kone wrote: > > > > Alexander Rukletsov wrote: > Vinod, we can avoid all these dances if we pass update by value. I would > prefer this approach, but it's with our codebase, therefore I went for a > copy. What do you think? SGTM - Vinod --

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

> On March 17, 2015, 6:24 p.m., Joerg Schad wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 349 > > > > > > Could you mention this as well in the description? As it is another operator. Don'

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/#review76759 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

> On March 17, 2015, 5:59 p.m., Vinod Kone wrote: > > Vinod, we can avoid all these dances if we pass update by value. I would prefer this approach, but it's with our codebase, therefore I went for a copy. What do you think? - Alexander -

Jenkins build is back to normal : mesos-reviewbot #4646

See

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/#review76756 --- Patch looks great! Reviews applied: [32163] All tests passed. - M

Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/#review76750 --- src/slave/slave.cpp

Re: Review Request 32133: Refactor port isolator tests to break out helper functions for testing of bandwidth limit statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32133/#review76744 --- src/tests/port_mapping_tests.cpp

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/ --- (Updated March 17, 2015, 6:08 p.m.) Review request for mesos, Benjamin Hindman,

Build failed in Jenkins: mesos-reviewbot #4645

See -- [...truncated 261 lines...] Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'sr

Re: Docker labels lands

HDFS also support this. https://issues.apache.org/jira/browse/HDFS-2006 :-) More convenient for user. On Tue, Mar 17, 2015 at 10:10 PM, Tim St Clair wrote: > Very useful in image management and clustering. > > https://github.com/docker/docker/pull/9882 > > -- > Cheers, > Timothy St. Clair > Red

Docker labels lands

Very useful in image management and clustering. https://github.com/docker/docker/pull/9882 -- Cheers, Timothy St. Clair Red Hat Inc.

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 17, 2015, 6:59 a.m.) Review request for mesos, Adam B, Benjamin

Jenkins build is back to normal : mesos-reviewbot #4642

See

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 17, 2015, 4:52 a.m.) Review request for mesos, Adam B, Benjamin