Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/#review79117 --- Hi haosdent, I added some higher level comments in the JIRA ticket f

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

> On April 7, 2015, 1:17 a.m., Joris Van Remoortere wrote: > > src/slave/containerizer/external_containerizer.cpp, line 374 > > > > > > Can we remove the capture by reference here? I know it's not in the > > style gui

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79113 --- Ship it! src/slave/paths.cpp

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79104 --- Patch looks great! Reviews applied: [32911] All tests passed. - M

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79103 --- src/slave/containerizer/external_containerizer.cpp

Re: Review Request 29334: Add option to launch docker containers with helper containers.

> On Jan. 18, 2015, 12:18 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.hpp, line 219 > > > > > > IMHO readability is subverted by prolonging the underscore scheme when > > there is no strict series o

Re: Review Request 29334: Add option to launch docker containers with helper containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29334/ --- (Updated April 7, 2015, 12:46 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29333: Add docker_socket to slave flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated April 7, 2015, 12:45 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29333: Add docker_socket to slave flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated April 7, 2015, 12:45 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29333: Add docker_socket to slave flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated April 7, 2015, 12:45 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29333: Add docker_sock to slave flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated April 7, 2015, 12:44 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29332: Add docker_mesos_image flag to slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29332/ --- (Updated April 7, 2015, 12:44 a.m.) Review request for mesos, Benjamin Hindman

Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/ --- Review request for mesos, Benjamin Hindman and Ian Downes. Bugs: MESOS-2592

Re: Review Request 29332: Add docker_mesos_image flag to slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29332/ --- (Updated April 7, 2015, 12:39 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29330: Integrate docker executor into containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29330/ --- (Updated April 7, 2015, 12:39 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29329: Add executor for docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated April 7, 2015, 12:39 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29333: Add docker_sock to slave flags

> On Feb. 15, 2015, 3:01 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, line 320 > > > > > > Why not "docker_socket" ? Why not :) - Timothy --- This is an

Re: Review Request 29331: Re-enable docker recover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29331/ --- (Updated April 7, 2015, 12:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29330: Integrate docker executor into containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29330/ --- (Updated April 7, 2015, 12:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29329: Add executor for docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated April 7, 2015, 12:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29328/ --- (Updated April 7, 2015, 12:28 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29328/ --- (Updated April 7, 2015, 12:26 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

> On Jan. 17, 2015, 1:34 a.m., Ben Mahler wrote: > > Just curious, what happens to the orphans if you don't kill them? Was there > > a ticket for this? > > Timothy Chen wrote: > the orphans remains untouched. there is a jira ticket for adding this > flag, i can fimd it later once im next t

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

> On March 11, 2015, 5:25 p.m., Joerg Schad wrote: > > src/slave/flags.hpp, line 325 > > > > > > Could you add this flag also the the docs/configuration.md? This is fixed in a later commit. - Timothy -

Re: Review Request 29327: Add slave id to docker container name prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29327/ --- (Updated April 7, 2015, 12:22 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32906: Add safety check for staged but uncommitted changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32906/#review79087 --- Patch looks great! Reviews applied: [32906] All tests passed. - M

Re: Review Request 32903: Eliminate the use of 'echo -n' in EC2 scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32903/#review79077 --- Patch looks great! Reviews applied: [32903] All tests passed. - M

Review Request 32906: Add safety check for staged but uncommitted changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32906/ --- Review request for mesos and Ian Downes. Bugs: mesos-598 https://issues.apa

Re: Review Request 32898: Eliminate use of 'echo -n'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/#review79072 --- Patch looks great! Reviews applied: [32898] All tests passed. - M

Re: Review Request 32833: Added os::signals::install to install signal handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32833/#review79067 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp

Review Request 32903: Eliminate the use of 'echo -n' in EC2 scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32903/ --- Review request for mesos and Ian Downes. Bugs: mesos-1424 https://issues.ap

Re: Review Request 32898: Eliminate use of 'echo -n'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/ --- (Updated April 6, 2015, 10:05 p.m.) Review request for mesos and Ian Downes.

Re: Regarding old frameworks in Mesos repository

+1 on removing deploy_jar, haproxy+apache, torque. For mesos-submit, it seems that this should instead be a mesos CLI command. On Mon, Apr 6, 2015 at 2:04 PM, Vinod Kone wrote: > +1 > > On Mon, Apr 6, 2015 at 12:28 PM, Adam Bordelon wrote: > > > +1 to moving these out to https://github.com/mes

Re: Review Request 32001: Required a period in trailing comments in the style guide.

> On March 12, 2015, 9:20 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, line 30 > > > > > > Hm, isn't this captured by ending each sentence with a period above? > > Alexander Rukletsov wrote: > Yes and

Re: Review Request 32001: Required a period in trailing comments in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32001/#review79062 --- Ship it! docs/mesos-c++-style-guide.md

Re: Review Request 32001: Required a period in trailing comments in the style guide.

> On March 12, 2015, 2:20 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, line 30 > > > > > > Hm, isn't this captured by ending each sentence with a period above? > > Alexander Rukletsov wrote: > Yes and

Re: Regarding old frameworks in Mesos repository

+1 On Mon, Apr 6, 2015 at 12:28 PM, Adam Bordelon wrote: > +1 to moving these out to https://github.com/mesos/ even if > they > are used, in which case we should open an issue tracker for each separate > project and give write permissions to that repo to anyone willing to > maintain it. > > On M

Re: Review Request 32898: Eliminate use of 'echo -n'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/#review79055 --- Can you please split this into two separate reviews, one for the ec2

Re: Review Request 32898: Eliminate use of 'echo -n'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/#review79053 --- Patch looks great! Reviews applied: [32898] All tests passed. - M

Re: Review Request 32895: Environment variables are case sensitive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32895/#review78974 --- Patch looks great! Reviews applied: [32895] All tests passed. - M

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

> On March 23, 2015, 10:10 p.m., Jay Buffington wrote: > > src/slave/containerizer/mesos/launch.cpp, line 107 > > > > > > This list-initialization doesn't work in gcc 4.4.7. That's the version > > I had with a stock

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

> On March 18, 2015, 12:09 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 94-100 > > > > > > The typedef is not needed to me. Not needed in what sense: I think it really helps to describe all t

Re: Regarding old frameworks in Mesos repository

+1 to moving these out to https://github.com/mesos/ even if they are used, in which case we should open an issue tracker for each separate project and give write permissions to that repo to anyone willing to maintain it. On Mon, Apr 6, 2015 at 12:10 PM, Yan Xu wrote: > There exist a couple of fr

Re: Review Request 32898: Eliminate use of 'echo -n'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/ --- (Updated April 6, 2015, 7:27 p.m.) Review request for mesos and Ian Downes. B

Review Request 32898: Eliminate use of 'echo -n'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/ --- Review request for mesos. Bugs: mesos-1424 https://issues.apache.org/jira/b

Ticket cleanup

bcc dev@ Hi, As part of FixIt week at Twitter we are doing ticket cleanup of Mesos. So you might see a deluge of emails on issues@. Apologies for any convenience, Vinod

Regarding old frameworks in Mesos repository

There exist a couple of frameworks in the Mesos codebase under /frameworks: deploy_jar haproxy+apache mesos-submit torque (See https://github.com/apache/mesos/tree/master/frameworks) Anyone still uses them? These frameworks are not trivial implementations like the ones under src/examples to

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review78965 --- Patch looks great! Reviews applied: [32891, 31444] All tests passe

Review Request 32895: Environment variables are case sensitive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32895/ --- Review request for mesos and Ian Downes. Bugs: mesos-1801 https://issues.ap

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/ --- (Updated April 6, 2015, 11:02 a.m.) Review request for mesos, Chi Zhang, Domini

Review Request 32891: Support for entering and configuring a Linux chroot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32891/ --- Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach. B

Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/#review78934 --- Patch looks great! Reviews applied: [32859] All tests passed. - M

Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/ --- (Updated April 6, 2015, 4:36 p.m.) Review request for mesos and Niklas Nielsen.

Re: Suggestion: Mesos 0.22.1 point release

+1 - Original Message - > From: "Niklas Nielsen" > To: "dev" > Sent: Friday, April 3, 2015 5:47:47 PM > Subject: Re: Suggestion: Mesos 0.22.1 point release > > Based on input from Vinod and Adam; I will reduce the scope on the point > release to focus on MESOS-1795 and MESOS-2583. > I