Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-22 Thread Alexandra Sava
) - 3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp 5f763e52a6a3d5a7cb38110ea650283b7a9fa789 Diff: https://reviews.apache.org/r/24700/diff/ Testing --- * make check * run master binary and send it SIGTERM signal with kill Thanks, Alexandra Sava

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-18 Thread Alexandra Sava
--- On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-18 Thread Alexandra Sava
5f763e52a6a3d5a7cb38110ea650283b7a9fa789 Diff: https://reviews.apache.org/r/24700/diff/ Testing (updated) --- * make check * run master binary and send it SIGTERM signal with kill Thanks, Alexandra Sava

Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Alexandra Sava
--- Thanks, Alexandra Sava

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Alexandra Sava
--- On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/ --- (Updated

Re: Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

2014-07-28 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22754/#review48314 --- On July 21, 2014, 2:09 p.m., Alexandra Sava wrote: --- This is an automatically

Re: Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

2014-07-28 Thread Alexandra Sava
--- Thanks, Alexandra Sava

Re: Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

2014-07-21 Thread Alexandra Sava
f2ca6599eb165c4c1bc4580175fa439f797c832b src/master/master.hpp 7e7a75bd7e0fafc084ad2663c894e76e5fb35edd src/master/master.cpp 896be5e8db45e819ce9f3a4e24c4017605283f12 Diff: https://reviews.apache.org/r/22754/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

2014-07-17 Thread Alexandra Sava
8641f2dfe711481133869f876715b56728dc1bc0 src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 Diff: https://reviews.apache.org/r/22754/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-11 Thread Alexandra Sava
On June 30, 2014, 4:13 p.m., Dominic Hamon wrote: src/master/master.cpp, line 4354 https://reviews.apache.org/r/23147/diff/1/?file=620068#file620068line4354 have you considered renaming the metrics? Alexandra Sava wrote: How do you suggest to rename them? slaves_registered

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-11 Thread Alexandra Sava
582f52d73eba0e3ab089ec573d9a6c43bff0339e Diff: https://reviews.apache.org/r/23147/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-11 Thread Alexandra Sava
On June 30, 2014, 6:44 a.m., Adam B wrote: src/master/master.hpp, lines 852-854 https://reviews.apache.org/r/23147/diff/1/?file=620067#file620067line852 // We mark a slave 'inactive' ... bool active; Alexandra Sava wrote: I have some concerns in changing

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-11 Thread Alexandra Sava
/#review47434 --- On July 11, 2014, 1:28 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-07 Thread Alexandra Sava
--- On July 7, 2014, 7:05 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147/ --- (Updated

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-07 Thread Alexandra Sava
--- On July 7, 2014, 7:05 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147/ --- (Updated July 7, 2014, 7:05

Re: Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

2014-07-01 Thread Alexandra Sava
--- Thanks, Alexandra Sava

Re: Review Request 22367: Second phase: Mesos-slave support for node drain

2014-06-30 Thread Alexandra Sava
582f52d73eba0e3ab089ec573d9a6c43bff0339e Diff: https://reviews.apache.org/r/22367/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-06-30 Thread Alexandra Sava
--- On June 28, 2014, 4:19 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147

Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-06-28 Thread Alexandra Sava
/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/23147/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22367: Second phase: Mesos-slave support for node drain

2014-06-28 Thread Alexandra Sava
: https://reviews.apache.org/r/22367/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22367: Second phase: Mesos-slave support for node drain

2014-06-28 Thread Alexandra Sava
Diff: https://reviews.apache.org/r/22367/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22367: Second phase: Mesos-slave support for node drain

2014-06-19 Thread Alexandra Sava
src/slave/slave.cpp ed3483ff1762d93837f328d1e647c490cf9e14c4 Diff: https://reviews.apache.org/r/22367/diff/ Testing --- Thanks, Alexandra Sava

Review Request 22722: Refactor os::user method

2014-06-18 Thread Alexandra Sava
, Alexandra Sava

Re: Review Request 22722: Refactor os::user method

2014-06-18 Thread Alexandra Sava
/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-06-18 Thread Alexandra Sava
-mail. To reply, visit: https://reviews.apache.org/r/21379/#review45445 --- On June 8, 2014, 10:42 a.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply

Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

2014-06-18 Thread Alexandra Sava
--- Test to check the SIGUSR1 signal is properly delivered to the slave. The slave should then shutdown. Diffs - src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca Diff: https://reviews.apache.org/r/22737/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

2014-06-18 Thread Alexandra Sava
9a73348abefe7aad4a64d4911836b6eba682a7ca Diff: https://reviews.apache.org/r/22737/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

2014-06-18 Thread Alexandra Sava
9a73348abefe7aad4a64d4911836b6eba682a7ca Diff: https://reviews.apache.org/r/22737/diff/ Testing --- Thanks, Alexandra Sava

Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

2014-06-18 Thread Alexandra Sava
. Diffs - src/master/http.cpp 5d869767cd3ed48aae1e702e8d014a37ef371123 src/master/master.hpp 286e2674df6e11f4c2915ed324fcc103532c src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 Diff: https://reviews.apache.org/r/22754/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

2014-06-18 Thread Alexandra Sava
/ Diffs - src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca Diff: https://reviews.apache.org/r/22737/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 22367: Second phase: Mesos-slave support for node drain

2014-06-10 Thread Alexandra Sava
643c0882a4bab1b612b3fb6fd1004e09edf5f368 Diff: https://reviews.apache.org/r/22367/diff/ Testing --- Thanks, Alexandra Sava

Review Request 22367: commit this

2014-06-09 Thread Alexandra Sava
relies on https://reviews.apache.org/r/21379/ Diffs - src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62 src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 Diff: https://reviews.apache.org/r/22367/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-06-08 Thread Alexandra Sava
34687e555e6ba07863c45840aa6d07717388cf62 src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 Diff: https://reviews.apache.org/r/21379/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-06-08 Thread Alexandra Sava
/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 Diff: https://reviews.apache.org/r/21379/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-06-08 Thread Alexandra Sava
--- On June 8, 2014, 10:42 a.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21379

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-05-22 Thread Alexandra Sava
sec). Diffs (updated) - src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7 Diff: https://reviews.apache.org/r/21379/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-05-22 Thread Alexandra Sava
not need to send a 'signal' number to the slave, right? Alexandra Sava wrote: Yes it's true, but I tried removing the signal parameter from message.proto file (and also from where the protobuf handlers are installed in slave.cpp) and I receive a compile error because the compiler does

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-05-18 Thread Alexandra Sava
4a8adf0efdd9a230a1f91d8d944fc6145a26b7c4 Diff: https://reviews.apache.org/r/21379/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-05-18 Thread Alexandra Sava
--- On May 18, 2014, 10:07 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21379/ --- (Updated May 18

Review Request 21379: First phase: Mesos-slave support for node drain

2014-05-13 Thread Alexandra Sava
: https://reviews.apache.org/r/21379/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 21379: First phase: Mesos-slave support for node drain

2014-05-13 Thread Alexandra Sava
3a4ae38e06a1c23daafebf5421d996e649a07ca5 Diff: https://reviews.apache.org/r/21379/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 20850: Customize the configuration of logging level

2014-05-12 Thread Alexandra Sava
--- On May 1, 2014, 11:09 a.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20850

Re: Review Request 20850: Customize the configuration of logging level

2014-05-10 Thread Alexandra Sava
Hi guys, Any feedback for my changes would be welcomed. Thanks, Alexandra On 1 May 2014 14:16, Alexandra Sava alexandrasav...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20850/ On April 29th, 2014, 7:18 p.m. UTC, *Ben

Re: Review Request 20850: Customize the configuration of logging level

2014-05-01 Thread Alexandra Sava
, Alexandra Sava

Re: Review Request 20850: Customize the configuration of logging level

2014-05-01 Thread Alexandra Sava
: https://reviews.apache.org/r/20850/#review41757 --- On May 1, 2014, 11:09 a.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-04-29 Thread Alexandra Sava
as an option, we could update the pailer component of the webui show the underlying error from the backend instead of FAILED TO INITIALIZE...RETRYING', thoughts? On March 25th, 2014, 8:04 a.m. UTC, *Alexandra Sava* wrote: When a FATAL log is been issued, the program exits(this is how glog works) so

Review Request 20850: Customize the configuration of logging level

2014-04-29 Thread Alexandra Sava
f205dca43f10697862e3fd3f435f1127a9d0aecb src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4 src/webui/master/static/js/controllers.js 4b8487e0c285f892ad352993c81637f38df1429f Diff: https://reviews.apache.org/r/20850/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 20850: Customize the configuration of logging level

2014-04-29 Thread Alexandra Sava
, Alexandra Sava

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-04-28 Thread Alexandra Sava
is accessible in the browse Thanks, Alexandra Sava

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-04-28 Thread Alexandra Sava
? Also, seems like this code could be cleaned up to be just: LOG(severity) Logging google::getLogSeverity(severity) level started; Alexandra Sava wrote: LOG(severity) does not work. You get a compilation error ( error: 'COMPACT_GOOGLE_LOG_severity

OPW 2014 - Slave unregistration in Mesos

2014-04-24 Thread Alexandra Sava
Hi guys, My name is Alexandra and I'm a Computer Science graduate from Bucharest, Romania. I've been an open source enthusiast for more than 5 years, when I first installed on my pc a Linux distribution (Ubuntu that is). I've been using it ever since because I like the fact that I can configure

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-25 Thread Alexandra Sava
24, 2014, 12:51 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19357/ --- (Updated March 24, 2014, 12:51

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-24 Thread Alexandra Sava
://reviews.apache.org/r/19357/#review38121 --- On March 19, 2014, 11:38 a.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19357

Review Request 19580: Fix minor issues.

2014-03-24 Thread Alexandra Sava
://reviews.apache.org/r/19580/diff/ Testing --- Thanks, Alexandra Sava

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-24 Thread Alexandra Sava
- the log file for INFO logs is accessible in the browse Thanks, Alexandra Sava

Review updated changes

2014-03-21 Thread Alexandra Sava
Hi guys, When you have some time, can you please give some feedback to the updated changes[1]? [1]https://reviews.apache.org/r/19357/ Thanks, Alexandra

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-21 Thread Alexandra Sava
this? Alexandra Sava wrote: If you try to access the log file in the browser, you get the following message: 'FAILED TO INITIALIZE...RETRYING' I'll mark this issue as dropped because without this change, 'FAILED TO INITIALIZE...RETRYING' will appear and it does not provide any relevant information

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-19 Thread Alexandra Sava
--- On March 18, 2014, 5 p.m., Alexandra Sava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19357

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-19 Thread Alexandra Sava
in the browser 5.Test5 - run master and slave with log_dir and quiet flags defined - expected results: - no logs (just FATAL) are displayed at stderr - the log file for INFO logs is accessible in the browse Thanks, Alexandra Sava

[jira] [Assigned] (MESOS-1067) Specifying minimum logging level doesn't work

2014-03-18 Thread Alexandra Sava (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandra Sava reassigned MESOS-1067: - Assignee: Alexandra Sava Specifying minimum logging level doesn't work

Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-18 Thread Alexandra Sava
defined - expected results: - no logs (just FATAL) are displayed at stderr - the log file for INFO logs is accessible in the browse Thanks, Alexandra Sava

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-18 Thread Alexandra Sava
) - no log file is accessible in the browser 5.Test5 - run master and slave with log_dir and quiet flags defined - expected results: - no logs (just FATAL) are displayed at stderr - the log file for INFO logs is accessible in the browse Thanks, Alexandra

Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag

2014-03-18 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19357/#review37632 --- On March 18, 2014, 5 p.m., Alexandra Sava wrote: --- This is an automatically

[jira] [Commented] (MESOS-1067) Specifying minimum logging level doesn't work

2014-03-16 Thread Alexandra Sava (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937052#comment-13937052 ] Alexandra Sava commented on MESOS-1067: --- Hi guys, Can you please assign this ticket

Re: [Request] contributors list request

2014-03-15 Thread Alexandra Sava
searching your name, can you point me to your JIRA profile? On Fri, Mar 14, 2014 at 5:10 PM, Alexandra Sava alexandrasav...@gmail.comwrote: Hi guys, I have a fix for MESOS-1067 ticket. Can you please add me to the 'contributors' list and assign that ticket to me (alexandra.sava is my

[Request] contributors list request

2014-03-14 Thread Alexandra Sava
Hi guys, I have a fix for MESOS-1067 ticket. Can you please add me to the 'contributors' list and assign that ticket to me (alexandra.sava is my JIRA username)? Thanks, Alexandra