> On Jan. 8, 2015, 8:03 a.m., Timothy Chen wrote:
> > src/tests/disk_quota_tests.cpp, line 55
> > <https://reviews.apache.org/r/29689/diff/1/?file=810332#file810332line55>
> >
> > Why would this be less?
>
> Jie Yu wrote:
> This is a bit tric
> On Jan. 8, 2015, 7:59 a.m., Timothy Chen wrote:
> > src/slave/containerizer/isolators/disk_quota.cpp, line 386
> > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line386>
> >
> > I think one problem that I hit in when reading docker ps
org/r/29602/#comment80>
let's group this into another block.
src/module/isolator.hpp
<https://reviews.apache.org/r/29602/#comment83>
Any reason why we take off the slave namespace too?
- Timothy Chen
On Jan. 6, 2015, 10:39 p.m.,
p
<https://reviews.apache.org/r/29718/#comment111217>
Captialize the first word of the comment and all other comments please.
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/29718/#comment111218>
Space before comment.
-
/tests/slave_tests.cpp
<https://reviews.apache.org/r/29720/#comment111223>
Can you use EXPECT_TRUE here? I think we still want to cleanly shut down in
the end.
- Timothy Chen
On Jan. 8, 2015, 6:43 p.m., Nishant Suneja wrote:
>
> -
690/#comment111280>
ah, the disk:1.
It's hard to tell what the units is from that, I wonder if it will be clear
if you add a more descriptive amount in comment. Just a sugggestion :)
- Timothy Chen
On Jan. 8, 2015, 12:45 a.m., J
tps://reviews.apache.org/r/29603/#comment111299>
I wonder if it makes sense to keep the slave namespace and folder?
mesos/slave/isolator.hpp
src/slave/containerizer/isolator.hpp
<https://reviews.apache.org/r/29603/#comment111300>
why __MESOS__?
- Timothy Chen
On Jan. 6, 2015, 10:39 p.m.
727/#comment111312>
Comment needs to end with a period
src/common/http.cpp
<https://reviews.apache.org/r/29727/#comment111311>
BenH's comment: This all actually can be called as JSON::Protobuf(discovery)
- Timothy Chen
On Jan. 8, 2015, 10:39 p.m., Christo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29605/#review67322
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 6, 2015, 10:39 p.m
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review67030
---
On Jan. 6, 2015, 10:15 p.m., Timothy Chen wrote:
>
> ---
sue if this is the
> > case.)
It is a general assumption across everywhere using subprocess, I can put it
here again.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/293
/
Testing
---
make, tests are fixed in next commit
Thanks,
Timothy Chen
/diff/
Testing
---
make, tests are fixed in next commit
Thanks,
Timothy Chen
/
Testing
---
make, tests are fixed in next commit
Thanks,
Timothy Chen
check
Thanks,
Timothy Chen
---
make check
Thanks,
Timothy Chen
and Bernd Mathiske.
Repository: mesos-git
Description
---
Integrate docker executor into containerizer.
Diffs (updated)
-
src/slave/containerizer/docker.cpp 5f4b4ce
Diff: https://reviews.apache.org/r/29330/diff/
Testing
---
make check
Thanks,
Timothy Chen
and Bernd Mathiske.
Repository: mesos-git
Description
---
Add docker_mesos_image flag to slave flags.
Diffs (updated)
-
src/slave/flags.hpp f1b8dfb
Diff: https://reviews.apache.org/r/29332/diff/
Testing
---
make check
Thanks,
Timothy Chen
and Bernd Mathiske.
Repository: mesos-git
Description
---
Re-enable docker recover test.
Diffs (updated)
-
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29331/diff/
Testing
---
make check
Thanks,
Timothy Chen
b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29335/diff/
Testing
---
make check
Thanks,
Timothy Chen
/29336/diff/
Testing
---
make check
Thanks,
Timothy Chen
rizer/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29337/diff/
Testing
---
make check.
Thanks,
Timothy Chen
and Bernd Mathiske.
Repository: mesos-git
Description
---
Install docker as part of the mesos docker build.
Diffs
-
Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b
Diff: https://reviews.apache.org/r/29338/diff/
Testing
---
docker build
Thanks,
Timothy Chen
Hindman.
Repository: mesos-git
Description
---
Install docker as part of the mesos docker build.
Diffs
-
Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b
Diff: https://reviews.apache.org/r/29338/diff/
Testing
---
docker build
Thanks,
Timothy Chen
and Bernd Mathiske.
Repository: mesos-git
Description
---
Skip docker validation in docker executor.
Diffs (updated)
-
src/docker/executor.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29339/diff/
Testing
---
Thanks,
Timothy Chen
,
Timothy Chen
/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
Diff: https://reviews.apache.org/r/29341/diff/
Testing
---
make check
Thanks,
Timothy Chen
as ok leaving the delay scheduled since
it's what is happening before.
What do you think Ben?
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29718/#review67305
-------
On Jan. 9,
r/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29335/diff/
Testing
---
make check
Thanks,
Timothy Chen
782/#comment111604>
Since it's a cpp file, let's just use the namespace to avoid this long
namespace everywhere.
src/slave/slave.cpp
<https://reviews.apache.org/r/29782/#comment111605>
?
- Timothy Chen
On Jan. 9, 2015, 10:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29781/#review67568
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 9, 2015, 10:58 p.m
h succeeded. Likewise, I'm asking
> why you chose to call `delay` to the timeout _regardless of whether_ the
> launch succeeded. If it doesn't need to be called when the launch fails (the
> two if cases), then we could the call to `delay` down. Otherwise, there's
> s
Are those containerId same? And in generally, Is it possible running two
>> tasks on the same executor with same containerId simultaneously?
>>
>> Thanks in advance,
>> JL
>>
>> On Fri, Jan 2, 2015 at 5:39 PM, Jongyoul Lee > > wrote:
>>
>>&
t will actually get to
LOG(FATAL).
Can you modify the test to see if the future still end up getting called
when you set the promise, and verify we get the LOG(FATAL) and fix it?
- Timothy Chen
On Jan. 10, 2015, 4:21 p.m., Nishant Suneja
> On Jan. 11, 2015, 1:25 a.m., Timothy Chen wrote:
> > src/slave/slave.cpp, line 2918
> > <https://reviews.apache.org/r/29720/diff/3/?file=816041#file816041line2918>
> >
> > So thinking about this more, if we call executorTimeout because of the
> >
Hi Joe,
Yes the processes you open through python is still under the same
cgroup, unless you explicitly move or create a new one.
Tim
On Mon, Jan 12, 2015 at 9:23 AM, Joe Stein wrote:
> Hi, if I have a python script (lets call that process X) and Mesos launches
> X. Within X I then open a sub
containerizer/fetcher.cpp
<https://reviews.apache.org/r/29809/#comment111746>
Why empty file?
- Timothy Chen
On Jan. 12, 2015, 3:40 p.m., Bernd Mathiske wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/#review67732
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 10, 2015, 7:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/#review67733
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 10, 2015, 7:43 a.m
603/#comment111825>
I don't think this is necessary, given we already import the namespace
- Timothy Chen
On Jan. 10, 2015, 7:42 a.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29597/#review67735
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 10, 2015, 7:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review67736
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 10, 2015, 7:27 a.m
600/#comment111827>
Can we explain in the comments why a internal struct is then exposed in
mesos.proto?
- Timothy Chen
On Jan. 10, 2015, 7:26 a.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail.
see date_utils.hpp is also using /*
Another place is also on the proto definitions too.
- Timothy Chen
On Jan. 12, 2015, 9:41 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
sit:
https://reviews.apache.org/r/29336/#review67660
-------
On Jan. 9, 2015, 1:25 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
make check
Thanks,
Timothy Chen
b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
Diff: https://reviews.apache.org/r/29341/diff/
Testing
---
make check
Thanks,
Timothy Chen
b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
Diff: https://reviews.apache.org/r/29341/diff/
Testing
---
make check
Thanks,
Timothy Chen
y, visit:
https://reviews.apache.org/r/29327/#review67437
---
On Jan. 6, 2015, 10:14 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To rep
e
download code
- Reduce number of parameters passed to download
- Some small refactoring to reduce extra code
Also I cleaned up some existing wierd formatting in the logging.
If you like what I did then take the patch from the gist and apply a new
review.
- Timothy C
782/#comment112003>
Let's just use namespace mesos::slave::state and we can simpify all of this.
src/slave/state.cpp
<https://reviews.apache.org/r/29782/#comment112002>
Let's remove the extra space while you're touching
- Timothy Chen
On Jan. 13, 2015,
> On Jan. 13, 2015, 7:34 p.m., Timothy Chen wrote:
> > src/slave/state.cpp, line 421
> > <https://reviews.apache.org/r/29782/diff/5/?file=819621#file819621line421>
> >
> > Let's remove the extra space while you're touching
>
> Kapil Arya wro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29782/#review67950
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2015, 7:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29602/#review67951
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2015, 4:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/#review67952
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2015, 4:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29780/#review67953
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2015, 4:42 p.m
r.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp f1b8dfb
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
org/r/29889/#review68064
---
On Jan. 14, 2015, 6:35 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> --
hanks,
Timothy Chen
make
Thanks,
Timothy Chen
-git
Description
---
It's not obvious that the disk usage log output is actually about checking disk
room.
Diffs
-
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
Diff: https://reviews.apache.org/r/29891/diff/
Testing
---
make
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29690/#review68086
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 14, 2015, 7:29 p.m
he later commit.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29327/#review67795
---
On Jan. 6, 2015, 10:14 p.m., Timothy Chen
Diff: https://reviews.apache.org/r/29327/diff/
Testing
---
make check
Thanks,
Timothy Chen
Diff: https://reviews.apache.org/r/29327/diff/
Testing
---
make check
Thanks,
Timothy Chen
tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
/diff/
Testing
---
make check
Thanks,
Timothy Chen
/diff/
Testing
---
make check
Thanks,
Timothy Chen
/29329/diff/
Testing
---
make check
Thanks,
Timothy Chen
,
Timothy Chen
and Bernd Mathiske.
Changes
---
rebased
Repository: mesos-git
Description
---
Add docker_mesos_image flag to slave flags.
Diffs (updated)
-
src/slave/flags.hpp a4498e6
Diff: https://reviews.apache.org/r/29332/diff/
Testing
---
make check
Thanks,
Timothy Chen
and Bernd Mathiske.
Changes
---
rebased
Repository: mesos-git
Description
---
Re-enable docker recover test.
Diffs (updated)
-
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29331/diff/
Testing
---
make check
Thanks,
Timothy
and Bernd Mathiske.
Repository: mesos-git
Description
---
Add docker_mesos_image flag to slave flags.
Diffs (updated)
-
src/slave/flags.hpp a4498e6
Diff: https://reviews.apache.org/r/29332/diff/
Testing
---
make check
Thanks,
Timothy Chen
and Bernd Mathiske.
Repository: mesos-git
Description
---
Add docker_sock to slave flags
Diffs (updated)
-
src/slave/flags.hpp a4498e6
Diff: https://reviews.apache.org/r/29333/diff/
Testing
---
make check
Thanks,
Timothy Chen
://reviews.apache.org/r/29334/diff/
Testing
---
make, tests are fixed in next commit
Thanks,
Timothy Chen
b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29335/diff/
Testing
---
make check
Thanks,
Timothy Chen
rizer/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29337/diff/
Testing
---
make check.
Thanks,
Timothy Chen
/r/29336/diff/
Testing
---
make check
Thanks,
Timothy Chen
and Bernd Mathiske.
Changes
---
rebased.
Repository: mesos-git
Description
---
Skip docker validation in docker executor.
Diffs (updated)
-
src/docker/executor.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29339/diff/
Testing
---
Thanks,
Timothy Chen
and Bernd Mathiske.
Changes
---
rebased.
Repository: mesos-git
Description
---
Install docker as part of the mesos docker build.
Diffs (updated)
-
Dockerfile 35abf25
Diff: https://reviews.apache.org/r/29338/diff/
Testing
---
docker build
Thanks,
Timothy Chen
,
Timothy Chen
/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
Diff: https://reviews.apache.org/r/29341/diff/
Testing
---
make check
Thanks,
Timothy Chen
,
Timothy Chen
/30001/diff/
Testing
---
Thanks,
Timothy Chen
://reviews.apache.org/r/30002/diff/
Testing
---
make check gtest_repeat=-1 and gtest_shuffle
Thanks,
Timothy Chen
3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28
src/docker/executor.cpp PRE-CREATION
src/tests/docker_containerizer_tests.cpp
2105ae2c410f01e7e0d10241d5c00df143fd3439
Diff: https://reviews.apache.org/r/30002/diff/
Testing
---
make check gtest_repeat=-1 and gtest_shuffle
Thanks,
Timothy Chen
"exit `...`" do?`
This is actually going to removed in a later commit. I posted my whole commit
chain.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29329/#review68
computer
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review68532
---
On Jan. 17, 2015, 1:26 a.m.
t is
finalized and ill post a wili page on jira
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29334/#review68537
---
On Jan. 17,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30033/#review68640
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 19, 2015, 3:45 p.m
034/#comment112968>
4 spaces instead of 2
- Timothy Chen
On Jan. 19, 2015, 3:51 p.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/#comment112974>
4 spaces
src/tests/fetcher_tests.cpp
<https://reviews.apache.org/r/30036/#comment112973>
4 spaces
src/tests/fetcher_tests.cpp
<https://reviews.apache.org/r/30036/#comment112972>
4 spaces
src/tests/fetcher_tests.cpp
<https://reviews.apache.org/r/3003
rc/slave/containerizer/fetcher.cpp
<https://reviews.apache.org/r/30037/#comment112992>
if (dotIndex
src/slave/containerizer/fetcher.cpp
<https://reviews.apache.org/r/30037/#comment112991>
space before return
src/slave/containerizer/fetcher.cpp
<h
039/#comment112994>
Add a space before the last return
- Timothy Chen
On Jan. 19, 2015, 4:10 p.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
This definitely sounds exciting.
Do you happen to have link to more information about this?
Tim
Sent from my iPhone
> On Jan 19, 2015, at 11:18 AM, Tim St Clair wrote:
>
> Greetings folks -
>
> All of the namespace work "should" be in the next release of Docker(1.5?).
> This would enable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30034/#review68840
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 20, 2015, 8:33 a.m
> On Jan. 19, 2015, 5:48 p.m., Timothy Chen wrote:
> > src/slave/containerizer/fetcher.cpp, line 247
> > <https://reviews.apache.org/r/30036/diff/1/?file=825099#file825099line247>
> >
> > //TODO(bernd-mesos):
>
> Bernd Mathiske wrote:
> This
g/r/30036/#comment113335>
I had to go check when was FetcherInfo introduced as we normally don't want
to change any assigned proto field ids. But since this is not released yet it's
fine, commenting here if anyone trying to verify the same
- Timothy Chen
On Jan. 20, 2015,
30039/#comment113337>
Seems like this should go into the fetchFromCache method.
- Timothy Chen
On Jan. 20, 2015, 3:52 p.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
tent where the log messages go, this should go
into the fetchDirectlyIntoWorkDirectory so any other calls of the method will
also get logged.
- Timothy Chen
On Jan. 21, 2015, 10:18 a.m., Bernd Mathiske wrote:
>
> ---
> This is an aut
701 - 800 of 1060 matches
Mail list logo
