Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 29, 2014, 10:38 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 29, 2014, 10:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 29, 2014, 7:03 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/reap.cpp, line 79 > > > > > > We had discussed this back when Yan worked on this code ... but I don't > > remember what we determined a

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review33104 --- Ship it! 3rdparty/libprocess/include/process/reap.hpp

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 29, 2014, 3:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 27, 2014, 11:25 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32751 --- 3rdparty/libprocess/src/reaper.cpp

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 24, 2014, 8:15 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/reaper.cpp, lines 70-98 > > > > > > Any reason why these two loops cannot be merged now? Definitely! Thanks for pointing this out :) - Ben

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 24, 2014, 5:46 p.m., Ian Downes wrote: > > 3rdparty/libprocess/src/reaper.cpp, line 101 > > > > > > Out of curiosity, why was 1 second originally chosen? It was likely an arbitrary decision based on a compro

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32744 --- 3rdparty/libprocess/src/reaper.cpp

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 24, 2014, 7:40 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/reaper.cpp, lines 31-34 > > > > > > Not your bug, but any reason we can't reuse an existing promise if it's > > already in the map? It

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32734 --- Ship it! Ship It! - Jie Yu On Jan. 24, 2014, 7:05 a.m., Ben Mahl

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32724 --- Ship it! Ship It! - Ian Downes On Jan. 24, 2014, 7:05 a.m., Ben

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32723 --- 3rdparty/libprocess/include/process/reaper.hpp

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32704 --- Ship it! 3rdparty/libprocess/include/process/reaper.hpp

Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Bugs: MESOS