Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 25, 2014, 10:04 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 24, 2014, 10:05 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 24, 2014, 7:42 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1945 > > > > > > Instead of scripts can we use the new Subcommand abstraction here? I think for ::

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 24, 2014, 10:03 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46568 --- Ship it! lgtm include/mesos/mesos.proto

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 24, 2014, 5:01 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 24, 2014, 5 p.m.) Review request for mesos, Ian Downes, Jie Yu, V

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46542 --- Bad diff? - Jie Yu On June 24, 2014, 7:28 a.m., Chi Zhang wrote:

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 24, 2014, 7:28 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 19, 2014, 2:06 a.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 347-349 > > > > > > Why do we drop these? Are there no apps out there which spoof the > > source i

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 24, 2014, 7:26 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46415 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 19, 2014, 2:06 a.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1009-1010 > > > > > > What if it's None? > > Chi Zhang wrote: > it means the link is not foun

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46404 --- Ship it! This is looking very good! A few style nits to address. Ev

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 19, 2014, 2:06 a.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.hpp, line 210 > > > > > > What does this mean? Are there un-managed nonEphemeral ports? commented to say that

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 20, 2014, 12:13 a.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 20, 2014, 12:13 a.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 19, 2014, 2:06 a.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 825 > > > > > > as commented earlier, these should really be called "ephemeral_ports" > > in the fl

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46101 --- include/mesos/mesos.proto

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46111 --- src/launcher/main.cpp

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 18, 2014, 1:16 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 13, 2014, 6:05 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 918 > > > > > > Does this require recent kernel patches? > > Jie Yu wrote: > Yes, it does. If i

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On May 19, 2014, 5:34 a.m., Cong Wang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1411 > > > > > > You probably want to remove this debug option. Cong, turning it on seems pretty use

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

> On June 13, 2014, 6:05 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.hpp, line 79 > > > > > > Why not statically allocate the ranges at construction and then you > > allocate a ra

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review45513 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review45572 --- Patch looks great! Reviews applied: [21594] All tests passed. - M

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 12, 2014, 6:45 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review45455 --- Bad patch! Reviews applied: [21594] Failed command: git apply --in

Re: Review Request 21594: Port-Range Based Network Isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated June 11, 2014, 6:44 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 21594: port-range based network isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review44176 --- Bad patch! Reviews applied: [21594] Failed command: ./support/meso

Re: Review Request 21594: port-range based network isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review43559 --- Partial review only, sorry. Will continue review when back. src/sl

Re: Review Request 21594: port-range based network isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review43534 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 21594: port-range based network isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review43334 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Review Request 21594: port-range based network isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. Reposi

Re: Review Request 21594: port-range based network isolator for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/ --- (Updated May 17, 2014, 12:08 a.m.) Review request for mesos, Ian Downes, Jie Yu