Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-07-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review47752 --- Ship it! Looks great, I made a few comments below. Since everything

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review46979 --- Patch looks great! Reviews applied: [22367] All tests passed. - M

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-30 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/ --- (Updated June 30, 2014, 1:38 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review46951 --- Patch looks great! Reviews applied: [22367] All tests passed. - M

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-28 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/ --- (Updated June 28, 2014, 5:22 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-28 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/ --- (Updated June 28, 2014, 5:22 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review46516 --- Patch looks great! Reviews applied: [22367] All tests passed. - M

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review46247 --- Looks great! The one thing I'm wondering is whether we want to expo

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-19 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/ --- (Updated June 19, 2014, 3:24 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review45525 --- Could you add a test that ensures the unregister message is sent? Yo

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review45326 --- Bad patch! Reviews applied: [22367] Failed command: git apply --in

Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"

2014-06-10 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/ --- (Updated June 10, 2014, 10:13 a.m.) Review request for mesos and Ben Mahler.