Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Chi Zhang
> On July 3, 2014, 12:18 a.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1071 > > > > > > is this sufficient to check BIND_MOUNT_ROOT is _self_ mounted? a little update: -

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/#review47256 --- Throwing this out here: an even better goal is that within the conta

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/#review47262 --- Patch looks great! Reviews applied: [23246] All tests passed. - M

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Jie Yu
> On July 2, 2014, 11:22 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1084 > > > > > > I don't follow why you need to bind mount the directory to itself? > > Can't you

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/#review47254 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/#review47253 --- Ship it! src/slave/containerizer/isolators/network/port_mapping.cp

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/ --- (Updated July 2, 2014, 9:59 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/#review47234 --- Ship it! src/slave/containerizer/isolators/network/port_mapping.cp

Review Request 23246: Used shared bind mount to fix MESOS-1558.

2014-07-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/ --- Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone. Bugs: MESOS-15