---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review50664
---
3rdparty/libprocess/configure.ac
On Aug. 15, 2014, 1:18 a.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, lines 80-86
https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line80
I think you also forgot to plumb this through the configure.ac at the
root of the repo, like you did for other
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review47784
---
3rdparty/libprocess/configure.ac
On July 15, 2014, 5:47 p.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, line 146
https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line146
Sorry for jumping in late, but is there a way to check the
EV_CHILD_ENABLE condition at configure time? I'm afraid
On July 15, 2014, 5:47 p.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, line 146
https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line146
Sorry for jumping in late, but is there a way to check the
EV_CHILD_ENABLE condition at configure time? I'm afraid
On July 15, 2014, 5:47 p.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, line 146
https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line146
Sorry for jumping in late, but is there a way to check the
EV_CHILD_ENABLE condition at configure time? I'm afraid
On July 13, 2014, 8:44 a.m., Adam B wrote:
LGTM. Did you test with/without in interesting combinations?
Standard testing for it.
I took special care around libev, as packagers will likely need to address the
constraint that libev is a rebuild library.
So make check will fail in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review47694
---
Ship it!
LGTM. Did you test with/without in interesting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/
---
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1172
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review47666
---
Patch looks great!
Reviews applied: [23414]
All tests passed.
-
10 matches
Mail list logo