Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52429 --- src/tests/isolator_tests.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52428 --- src/linux/cgroups.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52372 --- src/linux/cgroups.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 11:01 p.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 10:49 p.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51914 --- src/slave/containerizer/isolators/cgroups/blkio.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51948 --- Bad patch! Reviews applied: [25105] Failed command: ./support/meso

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 29, 2014, 8:36 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51860 --- Patch looks great! Reviews applied: [25105] All tests passed. - M

Re: Review Request 25105: Explore disk io isolation in cgroups

> On Aug. 28, 2014, 12:56 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/cgroups/blkio.hpp, line 36 > > > > > > Are you working on unit tests? [~tnachen] they are currently being worked on. - Patrick

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 1:12 a.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51730 --- src/slave/containerizer/isolators/cgroups/blkio.hpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:48 a.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51728 --- src/slave/containerizer/isolators/cgroups/blkio.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

> On Aug. 27, 2014, 6:32 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/isolators/cgroups/blkio.hpp, line 35 > > > > > > This doesn't compile. ;-) Yeah I'm not quite sure how I ended up with an unescaped # c

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:27 a.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51724 --- src/slave/containerizer/isolators/cgroups/blkio.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

> On Aug. 27, 2014, 6:32 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 440-441 > > > > > > Let's use put the "units" at the end. Also, we can pull out read vs > > write: > > > > disk_read

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 9:49 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 9:38 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

> On Aug. 27, 2014, 11:32 a.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 440-441 > > > > > > Let's use put the "units" at the end. Also, we can pull out read vs > > write: > > > > disk_rea

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51678 --- Please close issues once you've addressed them. src/slave/containe

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 6:50 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 6:40 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 6:37 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51672 --- First pass looks great. See Tim Chen's review too! include/mesos/m

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51669 --- src/slave/containerizer/isolators/cgroups/blkio.hpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 5:59 p.m.) Review request for mesos, Adam B and Benjami

Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos-git