Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy Chen
> On Sept. 4, 2014, 8:23 p.m., Timothy St. Clair wrote: > > src/docker/docker.cpp, line 324 > > > > > > Don't you want --host= and --bridge=br(x), in the case where folks > > configure bridges for vlans? Hi Tim, the

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 8:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 8:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52347 --- src/docker/docker.cpp

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-03 Thread Timothy Chen
> On Sept. 3, 2014, 10:59 a.m., Tom Arnfeld wrote: > > What's the reason for not also supporting the `port` resource type? For > > example, the Hadoop framework uses this > > https://github.com/mesos/hadoop/blob/master/src/main/java/org/apache/hadoop/mapred/ResourcePolicy.java#L458-L472. > > I

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-03 Thread Tom Arnfeld
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52158 --- What's the reason for not also supporting the `port` resource type?

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-03 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52154 --- src/docker/docker.cpp

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52150 --- Patch looks great! Reviews applied: [25270] All tests passed. - M

Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git