Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-09-08 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1771

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review52645 --- Patch looks great! Reviews applied: [25448] All tests passed. - M

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-09-18 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53857 --- m4/ax_cxx_compile_stdcxx_11.m4

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-09-19 Thread Dominic Hamon
> On Sept. 18, 2014, 12:56 p.m., Cody Maloney wrote: > > m4/ax_cxx_compile_stdcxx_11.m4, line 76 > > > > > > It would be good to probably have an assert or two here to ensure the > > move worked. > > assert(!p2); >

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-09-19 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- (Updated Sept. 19, 2014, 10:48 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53984 --- Patch looks great! Reviews applied: [25448] All tests passed. - M

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-10-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review57887 --- ping - Dominic Hamon On Sept. 19, 2014, 10:48 a.m., Dominic Hamon

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

2014-10-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review57893 --- m4/ax_cxx_compile_stdcxx_11.m4

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

2014-10-22 Thread Dominic Hamon
> On Oct. 22, 2014, 2:18 p.m., Vinod Kone wrote: > > m4/ax_cxx_compile_stdcxx_11.m4, line 69 > > > > > > why is this in a block? to accentuate that the lifetime of p2 requires a move back to p1. - Dominic -

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

2014-10-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- (Updated Oct. 22, 2014, 2:25 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

2014-10-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review57931 --- Patch looks great! Reviews applied: [25448] All tests passed. - M

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script.

2014-10-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review58173 --- Ship it! Ship It! - Vinod Kone On Oct. 22, 2014, 9:25 p.m., Domi