Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53902 --- Ship it! src/tests/reconciliation_tests.cpp

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53878 --- Bad patch! Reviews applied: [25565] Failed command: git apply --in

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-18 Thread Ben Mahler
> On Sept. 16, 2014, 6:44 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 2329 > > > > > > What is the guarantee that offers2 will be made after task's resources > > are recovered? I forgot to pass the

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/ --- (Updated Sept. 18, 2014, 9:30 p.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53484 --- src/tests/master_tests.cpp

Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1410 h