> On Oct. 29, 2014, 3:57 p.m., Michael Park wrote:
> > We can't make these `const-ref` unfortunately because the second argument
> > of `va_start` cannot be a reference type.
> >
> > N3797: 18.10 Other runtime support [support.runtime]
> >
> > The restrictions that ISO C places on the second p
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review59068
---
We can't make these `const-ref` unfortunately because the second arg
> On Sept. 17, 2014, 4:32 p.m., Dominic Hamon wrote:
> > I'm not convinced that this is necessarily the way we want to go, given the
> > benefits of move semantics in modern compilers, but for consistency we can
> > ship this until we have proof that performance favours the alternative.
>
> Ka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review57923
---
Ship it!
LGTM modulo running "make check" on mesos.
@Kamil: Can yo
> On Sept. 17, 2014, 9:32 a.m., Dominic Hamon wrote:
> > I'm not convinced that this is necessarily the way we want to go, given the
> > benefits of move semantics in modern compilers, but for consistency we can
> > ship this until we have proof that performance favours the alternative.
>
> Ka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review53704
---
Patch looks great!
Reviews applied: [25735]
All tests passed.
- M
> On Sept. 17, 2014, 6:32 p.m., Dominic Hamon wrote:
> > I'm not convinced that this is necessarily the way we want to go, given the
> > benefits of move semantics in modern compilers, but for consistency we can
> > ship this until we have proof that performance favours the alternative.
Isn't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review53688
---
Ship it!
I'm not convinced that this is necessarily the way we want
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
---
(Updated Sept. 17, 2014, 4:25 p.m.)
Review request for mesos.
Bugs: MESOS-180
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
---
Review request for mesos.
Bugs: MESOS-1805
https://issues.apache.org/jira/b
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
---
(Updated Sept. 17, 2014, 4:25 p.m.)
Review request for mesos.
Bugs: MESOS-180
11 matches
Mail list logo