Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 25, 2014, 8:41 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-25 Thread Vinod Kone
> On Sept. 25, 2014, 12:30 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1746 > > > > > > You don't need the `->self()` here and below, dispatch can take a > > pointer to do it for you. thanks! > On Sept

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/#review54480 --- Ship it! src/master/master.cpp

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/#review54240 --- Patch looks great! Reviews applied: [25866, 25867] All tests passe

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 22, 2014, 11:51 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos and Ben Mahler.

Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1668 https://issues.ap