Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56200 --- Patch looks great! Reviews applied: [26535] All tests passed. - M

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56191 --- src/master/registrar.cpp

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Ben Mahler
> On Oct. 10, 2014, 6:27 p.m., Dominic Hamon wrote: > > src/master/registrar.cpp, line 341 > > > > > > we should probably stop the timer whether the recovery succeeded or > > failed. maybe we need a 'cancel' method on

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56188 --- src/master/registrar.cpp

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/ --- (Updated Oct. 10, 2014, 6:25 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Ben Mahler
> On Oct. 10, 2014, 5:02 p.m., Dominic Hamon wrote: > > src/master/registrar.cpp, line 193 > > > > > > could you use the metrics timer instead (and still log the result) so > > that it is exposed on the metrics endpoi

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-10 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56165 --- src/master/registrar.cpp

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56097 --- Patch looks great! Reviews applied: [26535] All tests passed. - M

Re: Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56093 --- Ship it! Ship It! - Vinod Kone On Oct. 10, 2014, 1:51 a.m., Ben

Review Request 26535: Added batch sizes and timings to the Registrar logging.

2014-10-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --