Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 12, 2014, 2:48 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 12, 2014, 2:47 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-12 Thread Till Toenshoff
> On Nov. 11, 2014, 8:49 p.m., Vinod Kone wrote: > > src/messages/messages.proto, line 375 > > > > > > from your description i'm assuming this is backwards compatible? if > > master or slave use different versions (ol

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/#review60846 --- src/messages/messages.proto

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/#review60759 --- Ship it! Ship It! - Adam B On Nov. 10, 2014, 6:24 a.m., Till Toe

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 10, 2014, 2:24 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 9, 2014, 11:17 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 9, 2014, 11:16 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-09 Thread Till Toenshoff
> On Nov. 6, 2014, 6:30 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 620-621 > > > > > > This feels a little awkward. Now, we try to authenticate if > > --authenticatee is set (to non-default) or --credential is

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/#review60251 --- src/slave/flags.hpp

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 6, 2014, 11:21 a.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-06 Thread Till Toenshoff
> On Nov. 6, 2014, 6:30 a.m., Adam B wrote: > > src/messages/messages.proto, line 375 > > > > > > A little more clarity on this change: 'string' and 'bytes' are exactly > > the same on the wire, and both are represent

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-05 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/#review60125 --- Code looks great; almost ready to commit. I just want to open up the

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 6, 2014, 12:19 a.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

2014-11-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 5, 2014, 4:30 p.m.) Review request for mesos, Adam B and Vinod Ko