Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/ --- Review request for mesos, Adam B, Kapil Arya, and Vinod Kone. Bugs: MESOS-1894

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review59965 --- Patch looks great! Reviews applied: [27619] All tests passed. - M

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review60029 --- Ship it! Excellent. Elegant and clean. Just update the comment and

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

> On Nov. 5, 2014, 9:06 p.m., Adam B wrote: > > src/tests/cram_md5_authentication_tests.cpp, line 211 > > > > > > Why was this test explicitly creating new CRAMMD5Authenticator instead > > of using the default initial

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/ --- (Updated Nov. 6, 2014, 12:05 a.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review60243 --- Ship it! Ship It! - Kapil Arya On Nov. 5, 2014, 7:05 p.m., Till

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/ --- (Updated Nov. 9, 2014, 10:14 p.m.) Review request for mesos, Adam B, Kapil Arya

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review60755 --- Ship it! src/tests/module.cpp

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

> On Nov. 11, 2014, 6:14 a.m., Adam B wrote: > > src/tests/module.cpp, line 81 > > > > > > Fix the comment Argh, these rebases are making me go bannanas :) that one slipped in once again - sorry for that. - Til

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/ --- (Updated Nov. 12, 2014, 10:09 p.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review61161 --- Ship it! LGTM. I can fix the spacing before committing. src/authe

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

> On Nov. 13, 2014, 1:25 a.m., Adam B wrote: > > LGTM. I can fix the spacing before committing. Yes please. I did actually try to follow other examples but didn't check properly enough (obviously) as my checks never really turned up a non trivial forward declaring example. I now looked at proc